diff mbox series

[-next] PCI: brcmstb: Fix error return code in brcm_pcie_probe()

Message ID 20210308135619.19133-1-weiyongjun1@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] PCI: brcmstb: Fix error return code in brcm_pcie_probe() | expand

Commit Message

Wei Yongjun March 8, 2021, 1:56 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return negative error code -ENODEV from the unsupported revision
error handling case instead of 0, as done elsewhere in this function.

Fixes: 0cdfaceb9889 ("PCI: brcmstb: support BCM4908 with external PERST# signal controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Wilczyński March 8, 2021, 2:49 p.m. UTC | #1 
Hi,

[...]
>  	if (pcie->type == BCM4908 && pcie->hw_rev >= BRCM_PCIE_HW_REV_3_20) {
>  		dev_err(pcie->dev, "hardware revision with unsupported PERST# setup\n");
> +		ret = -ENODEV;
>  		goto fail;
[...]

Nice catch!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Thank you!

Krzysztof
Florian Fainelli March 8, 2021, 4:34 p.m. UTC | #2 
On 3/8/2021 5:56 AM, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return negative error code -ENODEV from the unsupported revision
> error handling case instead of 0, as done elsewhere in this function.
> 
> Fixes: 0cdfaceb9889 ("PCI: brcmstb: support BCM4908 with external PERST# signal controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Lorenzo Pieralisi March 22, 2021, 5:50 p.m. UTC | #3 
On Mon, 8 Mar 2021 13:56:19 +0000, 'Wei Yongjun wrote:
> Fix to return negative error code -ENODEV from the unsupported revision
> error handling case instead of 0, as done elsewhere in this function.

Applied to pci/brcmstb, thanks!

[1/1] PCI: brcmstb: Fix error return code in brcm_pcie_probe()
      https://git.kernel.org/lpieralisi/pci/c/b5d9209d50

Thanks,
Lorenzo
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index e330e6811f0b..69c999222cc8 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -1296,6 +1296,7 @@  static int brcm_pcie_probe(struct platform_device *pdev)
 	pcie->hw_rev = readl(pcie->base + PCIE_MISC_REVISION);
 	if (pcie->type == BCM4908 && pcie->hw_rev >= BRCM_PCIE_HW_REV_3_20) {
 		dev_err(pcie->dev, "hardware revision with unsupported PERST# setup\n");
+		ret = -ENODEV;
 		goto fail;
 	}