From patchwork Wed Mar 31 03:05:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12174239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8740CC433C1 for ; Wed, 31 Mar 2021 03:07:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F443619DC for ; Wed, 31 Mar 2021 03:07:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F443619DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c0IA0NTTdFkuOCc6lnhsE7Z2lWNYeiNwTy8bGRheWX4=; b=hjrmAHr0MHSHi3nSGiSPPkS2H SiIIg23X/KpFUO65r2S1OW7FM8CN13a1/HO5x9up+pnpFwXgFqSK5Jd55KJXtEQDmRXLGQa6JK2OG vgkjB/Q+2YPNY0qfaqUkr54eEls+nOrnSlm6aEMnoL0RBiBsz65jOR7qXWxu4ZzCmUksrR+0PqMv8 9TR24CHBqN2Y1dhL3I6Q6cHsWsSt6TDbrUlACU/KxfFWb0PkZ+FxEpJxG/3AB7U1MOiZY61W1atz6 w9v8uPQNVDqIFUeePoBq02o+lLGrRcfI2RLhvKqyb11hRMOaFX2RTXXIQgAiOH3c85SwU4wZxRQwT z0LHxRIAQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRRAz-005LuO-CV; Wed, 31 Mar 2021 03:05:49 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRRAh-005LsQ-3P for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 03:05:33 +0000 Received: by mail-pf1-x42f.google.com with SMTP id x126so13488002pfc.13 for ; Tue, 30 Mar 2021 20:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=PeADhDJNiRgIOEcF+wkSPzMcbbUX6gZBKwZAQSjLdgUMl5KM6cQaPet90MQdmPSCyn iGsR23rROUHXJpqZs624kHtm7qVmf506UE+nRNBUhWSDl0c623M4yn2B8R/SJUkvsBpp iMbF2LCL6lbsP8ROhLrMBJmB3Xv2yYGcBXdLo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=FLZpb6e4+yypZ9XwFbp/TebNtCMn0zAIMJme0zUDAqXYBvxFz15CYm0MECuho9lz6N Rlhl+ylzFhkzwHg+AXVuOTPIQTMVAWlR0BNWcI0yGJEf84KKSYpDhR+MuRN/i6FCIpTw cC5eIiUpVZxNZNseEGRxU3XPszPMJMCyzhISWjCniodtmhozGkfQGORNEgUiSIpLDAmQ XcLPWLXnAH9g6vZpxIJlBVqQRJ6DZFP7kqBkh6x9ZTcbx3gmDLHvmnGi95Kq/ajZWQ5l 6Nu9pYt4TiWV9DM09x3SjlSbG7fzNHX6uuW4ghXuDDhFkJJ1xJFtMid56w0AjQzGRw1v krfg== X-Gm-Message-State: AOAM531kNCYmSUzyqCad68nOVzeSLrN4W0e1940PGX8fZ6UNbbicYdb4 YrnEKbS33MUGqGeN2hPcWMpFCg== X-Google-Smtp-Source: ABdhPJzm0de/jGzfHBMBvV7eJXO4k4Msdp6jIUDaWhAN21Pxga+BrMA4W7QvoRXtC7recrv9I7fjyA== X-Received: by 2002:a63:3744:: with SMTP id g4mr1089520pgn.387.1617159929699; Tue, 30 Mar 2021 20:05:29 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:c8c2:b814:df0f:253f]) by smtp.gmail.com with ESMTPSA id c6sm389024pfj.99.2021.03.30.20.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 20:05:29 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v3 05/12] arm64: stacktrace: Use %pSb for backtrace printing Date: Tue, 30 Mar 2021 20:05:13 -0700 Message-Id: <20210331030520.3816265-6-swboyd@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210331030520.3816265-1-swboyd@chromium.org> References: <20210331030520.3816265-1-swboyd@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_040531_832570_53748D6E X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,