| Message ID | 20210402075355.9190-1-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option | expand |
On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote: > The operating mode is used for the AC97 interface only, > so lets drop the excess fsl,mode item from SSI node. Isn't it 'fsl,mode' meant for? I do not follow how it becomes excess. - fsl,mode: The operating mode for the AC97 interface only. "ac97-slave" - AC97 mode, SSI is clock slave "ac97-master" - AC97 mode, SSI is clock master Shawn > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > index a4217f564a53..67b2dd510981 100644 > --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > @@ -225,7 +225,6 @@ &pcie { > }; > > &ssi1 { > - fsl,mode = "i2s-slave"; > status = "okay"; > }; > > -- > 2.26.2 >
On Tue, 11 May 2021 10:37:50 +0800 Shawn Guo <shawnguo@kernel.org> wrote: These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97), so AC97 parameters are not used in such cases. > On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote: > > The operating mode is used for the AC97 interface only, > > so lets drop the excess fsl,mode item from SSI node. > > Isn't it 'fsl,mode' meant for? I do not follow how it becomes excess. > > - fsl,mode: The operating mode for the AC97 interface only. > "ac97-slave" - AC97 mode, SSI is clock slave > "ac97-master" - AC97 mode, SSI is clock master > > Shawn > > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- > > arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > > index a4217f564a53..67b2dd510981 100644 > > --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi > > @@ -225,7 +225,6 @@ &pcie { > > }; > > > > &ssi1 { > > - fsl,mode = "i2s-slave"; > > status = "okay"; > > }; > > > > -- > > 2.26.2 > >
Hi Alexander, On Thu, May 13, 2021 at 12:12 PM Alexander Shiyan <shc_work@mail.ru> wrote: > > On Tue, 11 May 2021 10:37:50 +0800 > Shawn Guo <shawnguo@kernel.org> wrote: > > These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97), > so AC97 parameters are not used in such cases. Looking at imx6qdl-icore-rqs.dtsi, I see it uses the sgtl5000 audio codec. To make the commit log clearer, you could also state that the board uses the sgtl5000 codec connected via I2S. Then it would become easier to understand why 'fsl,mode' could be removed. Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi index a4217f564a53..67b2dd510981 100644 --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi @@ -225,7 +225,6 @@ &pcie { }; &ssi1 { - fsl,mode = "i2s-slave"; status = "okay"; };
The operating mode is used for the AC97 interface only, so lets drop the excess fsl,mode item from SSI node. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 - 1 file changed, 1 deletion(-)