From patchwork Wed Apr 7 15:45:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12188715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BD7C433ED for ; Wed, 7 Apr 2021 15:47:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE2B861382 for ; Wed, 7 Apr 2021 15:47:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE2B861382 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xKEx0uJneAt8mTta5fMJjU9qw0uPVRkO7c7GbVTWGdk=; b=qR+qBQVJ0A/v3i ThKdSsDetzyc2g4BOlh6eHq+OaqvrjpLHWvxeQmNY+lWgKZRTxrN8VvWiEoGYiCtNs1JdwNsqXP6b 2ZDU/vn+FjPVE/U0fGURC2O//v3RpVqjO31igYXf1+bRzc76QX9XLKERrUm1Js/fMZa7i5DKmrZwv cPS5jSFUReQ3AxRS6r3D3TssiIR7i86uYawqE5yGfjsuDuGOTfXqGeVo0l/I43Ld9erIC8/fhmc4K GLMYNiuw/rbZsW8S8rpY6L9vU1cqMuSWufYrPVZFQ0I6oIBBefzSABW5L6c44xjPY6/xgYx6JVNXd 216M4F5McZPCxbb1UurQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUANG-005JMG-Mi; Wed, 07 Apr 2021 15:45:46 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUANC-005JLa-AN for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 15:45:44 +0000 Received: from mail-wm1-f69.google.com ([209.85.128.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lUAN9-0008QQ-AV for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 15:45:40 +0000 Received: by mail-wm1-f69.google.com with SMTP id c195-20020a1c9acc0000b029011b91a22942so2293621wme.0 for ; Wed, 07 Apr 2021 08:45:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=5rG51SJ9b2j59QDiuKuphq0VcbOFNOs71jH8++a6urQ=; b=rRqndkdWNgMCAEpa1XJmvRmzojtYr0g5r1rXx7eiF69ZVSVp0OKcG9KWvsxEOxTrTD CRrC2lFj6b7youMkFz6d32dAKijjm/x1Uy7VQDOYBazMau6GprEogLlaaaGRO5hEW+ED jFJWoDSJqUTvCMJfkQNud52x+v7+ROmTwqwN1nrfZ4l3YjRUnx7VM0/g8VarxS7eRGni g78oL3b+aMLbOQcHfB6yEc6q6zbNTtzOm0P0G8bj4Wp3+KTUl1Vixehnrdz7njRq4ZqG tYpBWwYQacpcIk0NX/d4wCJ7VCwggYjQcQgT3L+t68lRawkLhgyovj/dSMIISkZitIXx uSvA== X-Gm-Message-State: AOAM533t6E77QK3XjbcKlMlsUrVy/4WKnc9XEtlPzpTf5tkwAwwJgurM sYW0YuLMgYOp7UqBKfTlSoNI7vPfGtTRw9r7ei0Y+hiSLnF2R12deKhpEZQhTMF8wTtSrvy7PCt ZwXwpEj197xMpGRjS4DW3ewFlDKCgAAS9OkhEWG4itOtZnPkMBGxk X-Received: by 2002:a5d:47c4:: with SMTP id o4mr5102167wrc.138.1617810339102; Wed, 07 Apr 2021 08:45:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO3yDp/yMNG0dr/oMAaV1wjrumOV1gXxmp2b3gm7xGo7YMYB/+jov0VlU3GDVXbeWhmTWV8w== X-Received: by 2002:a5d:47c4:: with SMTP id o4mr5102154wrc.138.1617810338946; Wed, 07 Apr 2021 08:45:38 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id c2sm9215943wmr.22.2021.04.07.08.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 08:45:38 -0700 (PDT) From: Krzysztof Kozlowski To: Lukasz Luba , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure Date: Wed, 7 Apr 2021 17:45:35 +0200 Message-Id: <20210407154535.70756-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_164542_563389_AF5A654E X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org clk_set_parent() can fail and ignoring such case could lead to invalid clock setup for given frequency. Addresses-Coverity: Unchecked return value Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lukasz Luba --- drivers/memory/samsung/exynos5422-dmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 56f6e65d40cd..9c8318923ed0 100644 --- a/drivers/memory/samsung/exynos5422-dmc.c +++ b/drivers/memory/samsung/exynos5422-dmc.c @@ -1293,7 +1293,9 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc) dmc->curr_volt = target_volt; - clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll); + ret = clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll); + if (ret) + return ret; clk_prepare_enable(dmc->fout_bpll); clk_prepare_enable(dmc->mout_bpll);