From patchwork Fri Apr 9 09:51:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Bin X-Patchwork-Id: 12193583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B76C43460 for ; Fri, 9 Apr 2021 09:45:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 242C660FE4 for ; Fri, 9 Apr 2021 09:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 242C660FE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=APy8wa/ZwfJA+E2TNO2s86KvJWTl7WRfXKlZ80GvuTE=; b=SJD9iYJWeKC933yfED7XTTu0pD Imm71uYzItopvZlUashA1mXX58x+vGBwCk+vYCycQfit1rIb0JPwQ8ue95UnNJU9h8as9PJ6y7Gft Djug1ExilW8JAiYXZpb6vncqw1g/HSu+f92fo6ndOIjfnwwzR7LSNttuFtMezQGO0Qv3QvZtyk31k IgOuqSSNhP8atsJmh5bI8i3k9vFciHSfX1QE5jE+XV3cQuZo/gK5oz7eKYb2J05bNR6SOp4MYfRIf +qpLlMwjAb7F3DOnvydJPpcbJJ6stLCsQBUqNCHIJ050Xht9xo1syrhD0eVW+yJYjfgp18zDGIZyy 1A0qVC3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUnfr-000IRy-Kp; Fri, 09 Apr 2021 09:43:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnfn-000IR6-1H for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 09:43:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=6hUoKEUGmEh0xIAe34nMS2VgUOuN6rZqmrKbSPaQ6do=; b=zeLBTrjAm9DK++HoG67bQBgcMD c4KpbkJZpIIylUDbn6We/x0FIYceXU5DfrXV7NeAG+Me07qftNoM2xZdRnmfpIcm2iBrO8KOZd0no buWu0RdfIvOsOI2zPKVfBNWYGyHxx8xco5/04Xvrx+xlXe9ctVYV4Ak/J4vzcGYeUZtxMk/C3M/ru pQkNLcO9O1JjDu2gm5JbQGnqSdgCPXN8QTnqwzmRdhqB3068hqSeVcUOMZ7VLyEgaJUOEF3HPoyfX 2kRRMspHXQXv3uMzLZaJHRmxHGKDRdw7K0xIv5nnGBSjUcc9wCZZQqcoYeqm5j22dgJyCOE+vqMTI 6N+bTBOg==; Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnfk-00436U-BF for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 09:43:29 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FGtR46CzZzPpTF; Fri, 9 Apr 2021 17:40:32 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:43:10 +0800 From: Ye Bin To: , Arnd Bergmann , Greg Kroah-Hartman , Michal Simek CC: , , , Hulk Robot Subject: [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock Date: Fri, 9 Apr 2021 17:51:36 +0800 Message-ID: <20210409095136.2293754-1-yebin10@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_024328_570086_4C02D2DE X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 067396bedf22..4d586233dfa4 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -111,7 +111,7 @@ /* An array, which is set to true when the device is registered. */ static DEFINE_MUTEX(hwicap_mutex); static bool probed_devices[HWICAP_DEVICES]; -static struct mutex icap_sem; +static DEFINE_MUTEX(icap_sem); static struct class *icap_class; @@ -857,7 +857,6 @@ static int __init hwicap_module_init(void) int retval; icap_class = class_create(THIS_MODULE, "xilinx_config"); - mutex_init(&icap_sem); devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR); retval = register_chrdev_region(devt,