From patchwork Tue Apr 13 15:33:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 12200839 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12A7C433B4 for ; Tue, 13 Apr 2021 15:39:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C5B561221 for ; Tue, 13 Apr 2021 15:39:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C5B561221 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ki9Fp7az7CAa3c7XLIzANL2Bwm2/Xnd64jgRSg1uG0E=; b=elJ7ocWSxDZNcRfyj6MnMyDvQ BqbuI2sWzsjNoDejZt3zliVj7v8HJtcC5zFPVKLgkExApJs1j0Oy5PbyyZuTJgpnbWwcxYq1j1Uxo MXDOzL/wJ8/EJtIZi7++PltPzRfNNH+YoueXhr1Zy0bgfTsz/uv/lWkwmmddxs72D8UJqzlmtc2rS 0BdJNyqDe90wNjmbXgViEhfCTt2dyr2513ExIbu7mvzYtZqbhdC8qztnbq3ObEi5IIQGajuVPLvFI 1V5BGfjl4R63OFzJlJfHBRe+rIaYNROAXRC8xvQkIl8I4WaZ8ZDIk8zvWEnK1tcxMdx0hqQYfqJ+v deAVqfbjw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWL3r-009fWf-JL; Tue, 13 Apr 2021 15:34:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWL3E-009fSE-9I for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 15:34:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=aIH+b0GcZ8y25PBNAB55HaGHxbJE5IpyGf18xNdDBl0=; b=nVPPyrzbRmfZOpLHZg0Q9sUhxx yDQEB6Lon66YR+ccApKTPS4CukGwPLWtM1pd0/v2cx11k2YcNEbhAncHwHoRNLE0OywI7G8N5QHba 6PGyR1JuDRWHphtDjjPUURvPfwcRsJkLt2j3z5bcMVUSmtJ6mYVneBK2a2dHP0HClh/dW88iSsXaF B59vNNFo93J8bBGzcyOx7KMsQxE7vifPlkR19ZyI1xYKQ1Hz9Q4sJCcG98MIRotaDhCBMYU8RIW6i Pl+OnEDTLcJJcdG75XMHvJrLrUHDyO5ThiceeJQFxQm16ziDP7bkMvJDKwfc08/A33dOHZFnsMInj XKRbjxrg==; Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWL38-0079CG-MP for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 15:34:02 +0000 Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 82A732224E; Tue, 13 Apr 2021 17:33:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1618328035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aIH+b0GcZ8y25PBNAB55HaGHxbJE5IpyGf18xNdDBl0=; b=X8Bdc14pR2wQAIvEIJEEvIqRcgI1ssm70zhKrAfmsH97t+LJBG6F54hIAfexkvNjM03QpZ Mmvcbh6Mb2cY4JjgP6MJx43C//x3e1sVO18mIb6AebhzqVI407PYOkt2zSkqHjkRTnW1av bMhazEhQmgw6gmsAh0uwOlmsrG/SkqU= From: Michael Walle To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shawn Guo , Li Yang , Rob Herring , Michael Walle Subject: [PATCH 1/2] arm64: dts: freescale: sl28: fix RGMII clock and voltage Date: Tue, 13 Apr 2021 17:33:48 +0200 Message-Id: <20210413153349.29119-2-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210413153349.29119-1-michael@walle.cc> References: <20210413153349.29119-1-michael@walle.cc> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_083358_912858_87545C9B X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During hardware validation it was noticed that the clock isn't continuously enabled when there is no link. This is because the 125MHz clock is derived from the internal PLL which seems to go into some kind of power-down mode every once in a while. The LS1028A expects a contiuous clock. Thus enable the PLL all the time. Also, the RGMII pad voltage is wrong. It was configured to 2.5V (that is the VDDH regulator). The correct voltage is 1.8V, i.e. the VDDIO regulator. This fix is for the freescale/fsl-ls1028a-kontron-sl28-var4.dts. Fixes: 815364d0424e ("arm64: dts: freescale: add Kontron sl28 support") Signed-off-by: Michael Walle --- .../boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts index df212ed5bb94..e65d1c477e2c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts @@ -31,11 +31,10 @@ reg = <0x4>; eee-broken-1000t; eee-broken-100tx; - qca,clk-out-frequency = <125000000>; qca,clk-out-strength = ; - - vddio-supply = <&vddh>; + qca,keep-pll-enabled; + vddio-supply = <&vddio>; vddio: vddio-regulator { regulator-name = "VDDIO";