From patchwork Tue Apr 13 15:33:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 12200837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D83C433B4 for ; Tue, 13 Apr 2021 15:37:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAC4D61221 for ; Tue, 13 Apr 2021 15:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAC4D61221 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8BbTsG6FPKixRPGKBFC5lPmwe+HSs6KreG/Uw6qtULM=; b=aPc5uFfoEcd11r0Lv7qVliGzx 0JA37UAYuNKLGnv/wLgiHVMFzkj6Onq/35hsZ6EEf4fHjrFsDrvIy3mIXcEMTijvNmr8PX5TvgAQA n2kIXoUfZM5vZGSXq4w0f11YsVbDbCBeWbyMZoKonle+NESUcWoNLEYTJ7TOzTpC1D1Fc/uUdYFt7 hAnz6vZ0fc5MyYlM3pZseow/J1k+DxaWO3SKeK8cbLKHLhhiAPo4c306IGmXWXcAxL/YF4hHCCSI4 g0VFlsTqC436LGW32AVssGXaOAY97v2wn18lSCw7Ra52i41yeprqfuBt97BQH1aRY+1Hmsh8MF4Rd iioWEqJFg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWL3Y-009fUW-Jf; Tue, 13 Apr 2021 15:34:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWL3E-009fSD-9I for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 15:34:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=k+Vlef7jvOgvilVVGjBjjKMPscsAK3dgpBzI2L4C8Zg=; b=tHQ2V69XFvRdNngPW+Zir9k/2V NjA+qMY5eerHJZwnH5pxdrcD+m6PM4sC83qRkoHny3go9ReAlxevBuuwxC+KdUcXsdOAMRdKdNJgN 9Sqw/kHPp6ww6USseglgd91ZE5trmuvM2Tc90QaYH4vZ86Tt9+cqn41jL8Q/iEZgrIOSNh5q0+hnL yInLvOsRCT7JsnPRY42jPEBFPLZo3ieV2crW4vyo+ICbX5m13XgG8M3g6FoKnYeQpqn5+i/U/NZzf ydGGhCZS0r1hhDuy+eFpuRVD+H+98jUyZHQ4HtXjlPSbJLDGUH2YCoeITMyalG1pgymj7szBU4MdA SYK9iarQ==; Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWL38-0079CH-Lm for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 15:34:01 +0000 Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 56E3F22255; Tue, 13 Apr 2021 17:33:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1618328036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+Vlef7jvOgvilVVGjBjjKMPscsAK3dgpBzI2L4C8Zg=; b=TSk8y4kR6hjVdj0zQR6KgjryVKO3UJ4ITLsBRmMfIallERiAfi+LIz3poCkZaVsABHVRvn j9eNWnZlML1mHXnRgiuwpIblpcxynPE6f0f76j8EhTnLTyfreuUW2toXMH4bw4+lZbfXhc rQcibQso7EyUpZVGJntDpc8FEg78ihA= From: Michael Walle To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shawn Guo , Li Yang , Rob Herring , Michael Walle Subject: [PATCH 2/2] arm64: dts: freescale: sl28: fix RGMII clock and voltage Date: Tue, 13 Apr 2021 17:33:49 +0200 Message-Id: <20210413153349.29119-3-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210413153349.29119-1-michael@walle.cc> References: <20210413153349.29119-1-michael@walle.cc> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_083358_892549_E87BA800 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During hardware validation it was noticed that the clock isn't continuously enabled when there is no link. This is because the 125MHz clock is derived from the internal PLL which seems to go into some kind of power-down mode every once in a while. The LS1028A expects a contiuous clock. Thus enable the PLL all the time. Also, the RGMII pad voltage is wrong, it was configured to 2.5V (that is the VDDH regulator). The correct voltage is 1.8V, i.e. the VDDIO regulator. This fix is for the freescale/fsl-ls1028a-kontron-sl28-var1.dts. Fixes: 642856097c18 ("arm64: dts: freescale: sl28: add variant 1") Signed-off-by: Michael Walle --- .../arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts index 6c309b97587d..e8d31279b7a3 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts @@ -46,7 +46,8 @@ eee-broken-100tx; qca,clk-out-frequency = <125000000>; qca,clk-out-strength = ; - vddio-supply = <&vddh>; + qca,keep-pll-enabled; + vddio-supply = <&vddio>; vddio: vddio-regulator { regulator-name = "VDDIO";