From patchwork Sun Apr 18 20:57:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12210359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03728C433ED for ; Sun, 18 Apr 2021 20:59:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8761610C8 for ; Sun, 18 Apr 2021 20:59:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8761610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kleine-koenig.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=FOsvNvEv+Pezu00BPZjy424fKWaotqtL8R/MqG6lY20=; b=Ruw71wMSGDqmjX7v/giUou1Fua uy0LCMcq5y5qyMQKx6nw+lNgwm/7111JoPlCJnJU4aDdoVe4oZTLkA2B+RaUrR3ie1lvzuzoiOsaQ B9Be29ADmEBA+Iys+RnQA3FgaDn6KEJKGB3yLadah87myzMl36oD/+6A9OdZ+a2hfDV9jqPEI1wc0 lbvYDEzfkmiU3YbxvN8plkr6hiujVOOa34PcwiXVsv6pThnKePE4Ttg0nqxZSEd8opMHVKQnx9BzR 4Lp1XhOq7fu1FoAacRb5BDBoU0XeD7iOLGFZzb8wO0X6HNkbwo9SJHhkRnKnBHBPLzpchIw5yGCa+ 4lW1IzNg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYEUZ-008b4M-Fh; Sun, 18 Apr 2021 20:58:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYEUX-008b4D-2u for linux-arm-kernel@desiato.infradead.org; Sun, 18 Apr 2021 20:58:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=26vDCUNLoT5c1NhkihgIYFAFvwHIMpZX0ROqucdvfV8=; b=1fQ7X4OxG+2Wp3uuVVSfsCtZ2h 0N/ZX4Bs/LnNJwgsXKHAQhlTZiSjpzDG5reJ7JqiCK0BQLKtTcZSjYtaiVzV0LlJ4v+SUwfEwTmU4 AH30VNu1aSP/FpE4weJmLxYHgq/qYgVLKy9VRwM8QI2JtYG3fw+3zWSzW8LuVVWdwoJIQ165qv6nI mNRyCE9Rx1Ut47HC0XpAbd/ddtFneqWL+1OQQBzfHS5O0e7igIjyW2lWyEAYGMo0DVRFcswU4f4C9 bwgzNcIpYAUDOVYgLdKxfubnAbjDvGQbjpWbRX4oyBYeG51qnJeE4EnuT8TO+VB5+OD1YdNwdE/mV gpuI41Cg==; Received: from antares.kleine-koenig.org ([2a01:4f8:c0c:3a97::2]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYEUR-00AgEq-0R for linux-arm-kernel@lists.infradead.org; Sun, 18 Apr 2021 20:58:03 +0000 Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id 35B6EB6E149; Sun, 18 Apr 2021 22:57:51 +0200 (CEST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Claudiu Beznea , Thierry Reding , Lee Jones Subject: [PATCH] pwm: atmel: Fix duty cycle calculation in .get_state() Date: Sun, 18 Apr 2021 22:57:47 +0200 Message-Id: <20210418205747.1488248-1-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_135759_257361_82E3290B X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The CDTY register contains the number of inactive cycles. .apply() does this correctly, however .get_state got this wrong. Fixes: 651b510a74d4 ("pwm: atmel: Implement .get_state()") Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index d49da708337f..c30a0dac4b2d 100644 --- a/drivers/pwm/pwm-atmel.c +++ b/drivers/pwm/pwm-atmel.c @@ -319,7 +319,7 @@ static void atmel_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, cdty = atmel_pwm_ch_readl(atmel_pwm, pwm->hwpwm, atmel_pwm->data->regs.duty); - tmp = (u64)cdty * NSEC_PER_SEC; + tmp = (u64)(cdty - cprd) * NSEC_PER_SEC; tmp <<= pres; state->duty_cycle = DIV64_U64_ROUND_UP(tmp, rate);