From patchwork Mon Apr 19 12:15:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrice CHOTARD X-Patchwork-Id: 12211731 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26B3C43460 for ; Mon, 19 Apr 2021 12:18:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3643F6101E for ; Mon, 19 Apr 2021 12:18:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3643F6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RbSrf7rSOVAv/lWMmrmsavRmHRdajBfogyfUzjwYJIw=; b=fNEmSqZTUrG9u66bl/BU72ivz XIIXSlQpvUpsAKrVDecog/wN21c2YuVofqBFy9htvXNCkVlJAn7ocmc22KW7vyh+ndEMs2JW4PbgW fuQQqrDL3Sl/NEp1Dt2dax7Zx2GLw79Oiwm4zz8lDPdDiHUD6q69/KhhncTXm7d3oLpJN74TwhdeO N4PktXwdYO544PQficJ+xafgiLbALAS8mZA1RYIONn7iYocBHtBPihfXgZCbhFLbreAuJ6yyJpEwl Qjd8TJFFsYH3iwWxwXm24l8Znysl2w5xM0RKyWcDowianHfX0m9cFqTHOfbM11wH+x/lxm4UJ0tTT 2NvhdEpuQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYSp0-009pdH-RV; Mon, 19 Apr 2021 12:16:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYSon-009pbr-Pj for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 12:15:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZS2ZVOREo+uRHNWm9z7V2nITC4fpPcgEhu0hrX/2oic=; b=x/l75bu3uEQ7KnTG4+IBF0bknP 0Pph45qScadph3EtEhFKq8T80ug0HXUq7zPw1SL05QySSmFeaHKmWSEcYsrgGIeI7Eo6uU9sd0+3Z KEFzp4uYIIyIjeuvjBUldNyccLXTM6c/aAmfYNlAyofwyHPYS8fQvz3UdzTzl+gAavBEm1P+QJFkC LN7yqa3yWJxZeisxj1reBJa5GAHDw6c83vvOuzTdOOocmLa5Nh8+YeMSwQlQC7lk2Y2YYZAIrFxgm UO2QPOpBs7EIU88csqnGj1ANsGukDvksCM/8M4ixSSEkTSC9ckwEbqQCzWFWWGOTzJXFdamec0m0v k7p9g12A==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYSoi-00BLH6-JQ for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 12:15:56 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13JCBRtk028055; Mon, 19 Apr 2021 14:15:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=ZS2ZVOREo+uRHNWm9z7V2nITC4fpPcgEhu0hrX/2oic=; b=8S1VWDhFh5Z919plLq5uxnScZteSlf6ItEs0++OIeW4Hfed7z8fcJKJwcVIrVZBQZLQM YRgRSjV1WyFmfEH7s5PRXqiY1ad1+aUUusJ3gVA/qyaCXLBFgYDZpxNAJ718Hs+umyhs VW6zcgbH0lj8goUS8AA/Fmxj2Gj+UKjyq6PHp/aANk/OosXV5fnqrVmlQ0EHbKQIxpT3 OyXohKiLI6gD5Q77BGGghPNkKxOIiB/Ita+7Fon6sozI8Wp25Vb5KRv6Wt8UVeLGy0oJ jI0hxeGBAAkW/8LNeEz7CX+uZOUy6fc4zb8BfMTb4wYpDijJOeg4AuEnwGJfF9xKyYJ7 aA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 380wj63h0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Apr 2021 14:15:45 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 86A6A10002A; Mon, 19 Apr 2021 14:15:44 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7CC642139BC; Mon, 19 Apr 2021 14:15:44 +0200 (CEST) Received: from localhost (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Apr 2021 14:15:44 +0200 From: To: Mark Brown , Alexandre Torgue CC: , , , , , Subject: [PATCH 2/3] spi: stm32-qspi: Trigger DMA only if more than 4 bytes to transfer Date: Mon, 19 Apr 2021 14:15:40 +0200 Message-ID: <20210419121541.11617-3-patrice.chotard@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210419121541.11617-1-patrice.chotard@foss.st.com> References: <20210419121541.11617-1-patrice.chotard@foss.st.com> MIME-Version: 1.0 X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-19_07:2021-04-16, 2021-04-19 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_051553_030752_A4277924 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Patrice Chotard In order to optimize accesses to spi flashes, trigger a DMA only if more than 4 bytes has to be transferred. DMA transfer preparation's cost becomes negligible above 4 bytes to transfer. Below this threshold, indirect transfer give more throughput. mtd_speedtest shows that page write throughtput increases : - from 779 to 853 KiB/s (~9.5%) with s25fl512s SPI-NOR. - from 5283 to 5666 KiB/s (~7.25%) with Micron SPI-NAND. Signed-off-by: Christophe Kerello Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 2786470a5201..6e74d6bed54c 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -269,8 +269,9 @@ static int stm32_qspi_tx(struct stm32_qspi *qspi, const struct spi_mem_op *op) if (qspi->fmode == CCR_FMODE_MM) return stm32_qspi_tx_mm(qspi, op); - else if ((op->data.dir == SPI_MEM_DATA_IN && qspi->dma_chrx) || - (op->data.dir == SPI_MEM_DATA_OUT && qspi->dma_chtx)) + else if (((op->data.dir == SPI_MEM_DATA_IN && qspi->dma_chrx) || + (op->data.dir == SPI_MEM_DATA_OUT && qspi->dma_chtx)) && + op->data.nbytes > 4) if (!stm32_qspi_tx_dma(qspi, op)) return 0;