From patchwork Fri Apr 23 10:18:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12220063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF02C433ED for ; Fri, 23 Apr 2021 10:20:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87FD0611AE for ; Fri, 23 Apr 2021 10:20:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87FD0611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dW9LEQEdeUVRmfZmwVNS6mzSYF8+U+qBDFxkgpWq72M=; b=Obc7h3/S/DgG3F +gff3Es1qdJR5NZxuCFF6nR6nxBV721/vCSIjs9BjhNareDUrcJXsyB8t9F4Fv6v/FycoXdv3GYqC YPFvKyvT6fba3X7p/065e65/bfbGYgUi9Vne0WJH+rXIVdWYEaH/87Tii8XweZ6rbsFrplwZA84KU QFJ1H5JkjYD2MUqwT3G/DhmrXwfnnGNkfFOH5XnzITC+bRNtnIzWy0Jc3Y4iPokF23IOp5lkBoDao HLVQFNwn+Og8Ny//vT5Thdm0KwYR56XsCPDnu8eav5wNHRJT4Tdq/tEt/i/Lye5vJIKMNAZFdvPP+ /AnMT5vUT9STxIedn1RA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZstT-001IJG-6J; Fri, 23 Apr 2021 10:18:39 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZstD-001IHu-Tr for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 10:18:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=aYP7r7LEZu6SffM7BQ/kCnDNHMdX1uJGOUnQwrtupd4=; b=VZp2Cmn4gsppdp4vXb7jhT4FdL DzSysLyQiVaeQEh0BrdMN7q4/QOj9SDrc7KbM0XhQ66CK+bWxoi+JYyO6Jbmi9RXNODmhYVs3DhEa G2FM/23/798UyeJKFs/voy7fibRfc9uZuXnSUduq6I0BeFhM9w9BxogFgRJxuZ9us81l8DHTWeWgY c/AsFsHO4FwfgXQCWsmhD67XkWjNh4oMrvJzMna4j45bnPLgg2i8ZmHXb1UWFI6tJGFszhx82fkR0 EGk7uR64FDhd7BX0Lb8iAzHtIhqQGdHsCw7Tbfkhfkk34uM5Cymdo7OCxYdALPqDLbGZdV+q8dDa/ MItIzlzw==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZstB-00EK13-32 for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 10:18:22 +0000 Received: from mail-wm1-f69.google.com ([209.85.128.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lZst8-0001aU-BN for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 10:18:18 +0000 Received: by mail-wm1-f69.google.com with SMTP id o18-20020a05600c3792b0290128219cbc7bso6870946wmr.4 for ; Fri, 23 Apr 2021 03:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aYP7r7LEZu6SffM7BQ/kCnDNHMdX1uJGOUnQwrtupd4=; b=fC5XNfLMYvfaD8lFQ8MviDuScGi7QILz3A5iTb4pIcCnhSRnpzPKXkvAfT+pzq1ayI TZ4g7Pv340dOwh10yI6HCsJLq3YRu9mm6/vWdKT6UvnOo62V3s9h9YX9SOLFdLsfdFf6 aqNZjs9UjJYIMxMa3+ck8K7IVoAAkBabTy235pW9P1bXj3HjpbOEqEjfR9dy3IYr4zyU H3A0RVJpHOdnfhPaizMKXfTCVyJdlP47aJWfJXpVEr/bcLLKV6tBQZHiAWJcqrIjBO9a upWNHTB2GF3fmNbxSreiQuDLoHy5e3FvyLDXriW3lrbzH2SYntIKG2sFLLBcmQIMDr1g xtRw== X-Gm-Message-State: AOAM531jllR805223Ed1E1ZmMrZEsaTU/kwdLoXysV/Y+ioDL6A5Si4u 0Byq5sYq0nWnLeiD6cX/gEF0iDwMHSmtuMeZcdk7QX5gQO7pt6M7ESlLnSfPIkvp2/gj6l04k76 QmUeKIfBWXEiPxzljJ55Z8U4u/Z3j8s4Y3y2WpYF0vFS9yhF8+eEe X-Received: by 2002:a5d:6d0c:: with SMTP id e12mr3621879wrq.321.1619173098076; Fri, 23 Apr 2021 03:18:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYKHJDOkDZqAUM3Wgbi5Urcq0uh3Bk7tH9x1MWtycNV6cQpV4aktMYKexZVqRVW2OoCmZ6Xw== X-Received: by 2002:a5d:6d0c:: with SMTP id e12mr3621863wrq.321.1619173097904; Fri, 23 Apr 2021 03:18:17 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id k22sm9011546wrh.5.2021.04.23.03.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 03:18:17 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Miquel Raynal , Boris Brezillon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 1/2] memory: stm32-fmc2-ebi: add missing of_node_put for loop iteration Date: Fri, 23 Apr 2021 12:18:14 +0200 Message-Id: <20210423101815.119341-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_031821_288101_AC4F8F28 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Early exits from for_each_available_child_of_node() should decrement the node reference counter. Reported by Coccinelle: drivers/memory/stm32-fmc2-ebi.c:1046:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1051. Fixes: 66b8173a197f ("memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Christophe Kerello --- drivers/memory/stm32-fmc2-ebi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/memory/stm32-fmc2-ebi.c b/drivers/memory/stm32-fmc2-ebi.c index 4d5758c419c5..ffec26a99313 100644 --- a/drivers/memory/stm32-fmc2-ebi.c +++ b/drivers/memory/stm32-fmc2-ebi.c @@ -1048,16 +1048,19 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi) if (ret) { dev_err(dev, "could not retrieve reg property: %d\n", ret); + of_node_put(child); return ret; } if (bank >= FMC2_MAX_BANKS) { dev_err(dev, "invalid reg value: %d\n", bank); + of_node_put(child); return -EINVAL; } if (ebi->bank_assigned & BIT(bank)) { dev_err(dev, "bank already assigned: %d\n", bank); + of_node_put(child); return -EINVAL; } @@ -1066,6 +1069,7 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi) if (ret) { dev_err(dev, "setup chip select %d failed: %d\n", bank, ret); + of_node_put(child); return ret; } }