From patchwork Fri Apr 23 10:35:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: He Zhe X-Patchwork-Id: 12220085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FA5C433B4 for ; Fri, 23 Apr 2021 10:38:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D33D3613D7 for ; Fri, 23 Apr 2021 10:38:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D33D3613D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VN0GZOlr8pW6loHwvMDMWWt9Of+9HM1ZwPBIkrWNUGY=; b=iZz1p3ViBwniAs36w8UJvuKmK RznujlOvlkjLPYki2lBtAN6YBiCwjrDcdj8TxazCoHblMdWvqgfIlxZhglAKRBJqmmwTB5N3UDhxA b+lNQqwr5EUfwfGIWPdaXwWnd0ss9shrDh+44yKBpu/lrqHmfDVjIsxx5lNy48bMyEWCoZlLBdciR 95snhd+5XE3BfLy5kSuU4BOJviwwBcLLvB8lW4+gHJeRO+S1lKJBUCMmmScBA5Zay3L2AwGvtBet0 sNEZ5LFxeFnBemFpEVYRpGBNchktSCjmejXWYPCi0e9ZbdJ/367IV0uywn6ixX+zXs60uU0VUu60z 5XfmXo/gQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZtAj-001K1e-RD; Fri, 23 Apr 2021 10:36:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZtAN-001Jwv-4d for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 10:36:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oVXb/jfniKHAVt8fXpI4qKsIk++ZFmOxGm4V/kx+xmc=; b=jB+hg95JfS5wnb1bKTRIPvufRO 2ddGjj4Bv22LChAgBsjbBqNiaUN+4aPVmd3TTLzzeNeHoQeci0Ob75nf1ayYnbsUH+cwZ0vU80YXu Zpa6SftpZJxsbJO6P4vxChl4SpgBtFypms98IvH6jGJaAu4P/7GC7bMYfzwEL9Vud+nyPC1xXSZZL /ITfke/z9+ko/rZh960dKKjVjDSVtqfPm9+BarmZQLJftPsOGzqsAUaEbBcsDjHAYD9a/f9xnstTk ea4CvDnNRR3D5OfW7UPXIld1GHqh1TUnr/HBThDMOSg8wM0cBNBEs0kRHjZDFmeComj2Df8wZMRRD sF8FGC9Q==; Received: from mail-bn8nam12on2079.outbound.protection.outlook.com ([40.107.237.79] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZtAK-00EKeI-Lx for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 10:36:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUZf7vXy5Z0gML+2uT7PUpQpmKRtg9xGT3RPiKs+7xsJQ5lnMZEdqsiqM97On+PaX2yI+5eIZ9ezX20wsr6hpeychf8S++TZHWG4HCBEEQJ/oSRgvkqAS0eUKvBQbnPO8gcnNqxfr9tw5lNu2HiSRABPLmfleKri7HyZfbrkInsezgIy86TA8ktvn1E/MBRgy5gaMnDRJ52ZAyYn8luEy/javpmzS0hAjgzxY40QC5d69TtKVCo03rVKP6ygFcoGGN2gPmsRZYnClG98zT31V3ny4HIPX/qHBtcQhlVNHo4UFAB31jQ2DtnVN6TNvstHtiVMv52LcUu2g0tvAhJjLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVXb/jfniKHAVt8fXpI4qKsIk++ZFmOxGm4V/kx+xmc=; b=i3DykTmsCFAvRMz5s/4t0VxsOgNsMxSPlDwlozx4VxAQweSQGjBfwmjGaH4NsQ5G/XxW7/E5iGVQbYcQdQbh/JiX6Q/gp821r8uQoqwnRAUA8+hpP1IUjvQYYogt3lsRX4ef4KKoHMqyBb+L1M5Pc9EnY0yMnF1EdooyjnjXbPuIaXNsrmna9BMWJq3LuVFyqkevSQwMGv4PtXv9GaFPAllFas7CWnxqK8bI9a8kIazSWjn29tHbIHwrACR2QB1W5m7RG+bMqe4uwWcVCG750vFUxuYb4vwrL5j7KatqZuGMEwEFQXfKUB2YxELFCjBRTOAP387H7cEeFs40Rr/lOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVXb/jfniKHAVt8fXpI4qKsIk++ZFmOxGm4V/kx+xmc=; b=UB2Yn/jiUA56ZrdOblsN8P5F3R+Im9aM0JxyRfVCIr6TJRRkVkcFPPsDXYYPKbc/cSa89oT7IRgX+dhFPYeWE0QYRtRXgfoTEdlTO/Dd3SH9J+AuhYXI/nHY1eUr6QHKozboB+9UWvOigY+HFLPkqBp1vD1LftsATDs0G87Ju00= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=windriver.com; Received: from MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) by MWHPR1101MB2192.namprd11.prod.outlook.com (2603:10b6:301:59::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Fri, 23 Apr 2021 10:36:01 +0000 Received: from MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::c156:455d:860e:ba87]) by MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::c156:455d:860e:ba87%4]) with mapi id 15.20.4065.024; Fri, 23 Apr 2021 10:36:01 +0000 From: He Zhe To: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org, zhe.he@windriver.com Subject: [PATCH v2 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit Date: Fri, 23 Apr 2021 18:35:33 +0800 Message-Id: <20210423103533.30121-3-zhe.he@windriver.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210423103533.30121-1-zhe.he@windriver.com> References: <20210423103533.30121-1-zhe.he@windriver.com> X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: CY4PR19CA0041.namprd19.prod.outlook.com (2603:10b6:903:103::27) To MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pek-lpg-core2.corp.ad.wrs.com (60.247.85.82) by CY4PR19CA0041.namprd19.prod.outlook.com (2603:10b6:903:103::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Fri, 23 Apr 2021 10:35:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 921bf59d-fabe-4092-ba5c-08d9064396bf X-MS-TrafficTypeDiagnostic: MWHPR1101MB2192: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Is8jUvCqnbR3C9XWtNccKw6oF0RlgPFOn28/74fbuAaEtvBE4e+igvMMebr4MF5wb+GxTf/Nkz/nLvieNImGPye+hzfFz0oyKZhmCYJsWzx1lKqHukMfeZLtm2BSva0pL5F1zfrUD0kqah4iH6VLd2a334L40NT39++6hJtPbNn0Up7xrSKHkkKHHrbDuFW7ZiPnWfjiO+kOehvn1MhnMsQXnLoc5/v5UoyycqKMjb7+C4s36BHmeERvgqL6dOXXzJ62/Gh1uV7Ax61JqKz+l1Oi1tfjAKLqNvQlcsO+3wvBW3NTJq9JbC4SxLjYBPZN5f8tjgUwrwkbO1XwzMw0+idYriXPTr+BkeFtn6JsPEHNYNNNLjfjgPehWRIHaZONH3hJkXoyxe+Dmqbhy3TtSJrSbYwzueq+lrQ8TZRtgIH1GlsqcglxbHWpUW1EZk7J/j7EGUjit/f4xyunW2BkNuBsbVEbz+BlsbC9x7jfGED0STk2VqtSYZ/Ccetn3i8RPyBQeQHlt/kVTMJNmMi85/PrO5X+gAECJf34Ax2gPcWmRVAwl/dlIiiuY1EGOvNY213rdXDIghCyvETtquoISzVBu9M+OjWoTXuD0UpG9TpLOgnvEVVA6lLAmg2LubQZQghosT8yeQmTsJ9jMKOVWg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1101MB2351.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(52116002)(38100700002)(86362001)(38350700002)(8676002)(6486002)(8936002)(6512007)(26005)(186003)(16526019)(316002)(6666004)(1076003)(6506007)(478600001)(2906002)(5660300002)(66946007)(2616005)(83380400001)(956004)(66476007)(66556008)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 07XBfvUSdKahtoPPECYmjAYmn9mBZ3ptoxBx0YSoMXAygONKBKjxutZyjH1QeQKOgfGz49vQ6aLW1fJGPPS5e41WlCpXYBezFj8wYEQbb4bDdNHjVJj4VKnUIweIM+i9ucdmZ41wFe88ec/o3CieI5oY2exZ2zwmx/nqmZO5e8fg7CUAUW9bQK0gOxTS7no0GHE06qq/mr113+V87t4ngu2ddwXWEkZKrO0c7k+zJJyCWWRKJXVRfYjq62u2bYDypaCFpI2zRFbsnENSp+XQp1RjzXSM0ZpM5d/BxdEZPtcTJPAMTUwgOdr/QnOcF8Y9TlBAr3STU2rqwG9fHl5MD1aI1Ew5Lc0nK/dper7/mtCzkwRqZTgKc+ijxiFU/WSfoOdZkrsRaghJYdXZSTmWIq08v3n0mMHDR4Gw6Dl6p0HvTQTK4aoAN3xTlyr+pLR9+7vQn8vWd6HUUuXDN0RI33NeXl6FHOj0jlaQqKoUmXkiXbJ2/ZZ8bH/P/A0nwT/4Ik38PAQFdlVncmanu1ZGbkBlemiDqoeD7r8e7hloeJHb1jHw22Y5BfN0TIMCCAna2qpIsmH3svc1rrOhPUuz3O2PY5lyuyxs7VnSv/I9A+Mv6Qra2XwrUN30YRmmLj3uGk9w9+mRjoYOlwPi/0j3wsPdAdf/VOaUvNsCv9nxSy6qIirvHO4yYmCJsgoMzuwSJkYVBql27B8K0lmOqv6jIxj1J3Up5z5w2PJRSQ2ocG117SOHEJG5fZGefW3h06JC9+zDSpzIK9LlSlJF3qHmdg+ZCTUeIA4UiGtSmlQCaMKO5YdN5W1wxYeFwzXbOT2iaSzfLLE2uZU3qzyyUZk7feDSjbN89GCR94lz9eI1pXfpTWlSF+2m6mtNYG0UQkeSgBTxuRLAkrpjxPb2SqlnB8DFAqJIAkIUwtjl7wlTOgM7f2pXSomDxg7oANJg6Pc06NrxBRrcEOYlSqSxG6ULd04mQstdHJmyRp4ELxg/i4HzVkUd2Y+c7aF2a+O2t6BX60qhU6D+cLkuC2b5S/LGR/GlL7BYS9E+JxSFn3gq+s8hfVy28bdILcwEqBQ7b6znlNl1Ws/EhHApuSMBqs+3JAkIqnOrqQ0EmGUAqACObJFOplzIHhGRB40dZ5wyur9z1pE4u7g3mQ6j9+PHZjqJfimrwLqDO4Y9e6cbvKsXSeaNBmE+yOpZqDmf3rxepb3s9swbTg9z/E49i04OafxsP5T7yA1Sirfqa8RUVerwhED28wnjf3OErUVzF4CV71p9qQ1jEyem0HaWD81TaCA07gYq1TrkcCSTwy7+NUmU+cyltcJNlH+Z7xNcgmPOezWk X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 921bf59d-fabe-4092-ba5c-08d9064396bf X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2351.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2021 10:36:01.5486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xqazgfDpZ+/85GbbQb2VFIU6kn2bvhD+EcvwMIHT/8uEB4eh9ADupV8uGBMmNSpzZFoDmb06pFOZI6AeHMYgtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2192 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_033604_738921_A524C103 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org regs_return_value for some architectures like arm64 simply retrieve register value from pt_regs without sign extension in 32-bit compatible case and cause audit to have false syscall return code. For example, 32-bit -13 would be treated as 4294967283 below. type=SYSCALL msg=audit(1611110715.887:582): arch=40000028 syscall=322 success=yes exit=4294967283 We just added proper sign extension in syscall_get_return_value which should be used instead. Signed-off-by: He Zhe --- v1 to v2: No change include/linux/audit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/audit.h b/include/linux/audit.h index 82b7c1116a85..135adbe22c19 100644 --- a/include/linux/audit.h +++ b/include/linux/audit.h @@ -334,7 +334,7 @@ static inline void audit_syscall_exit(void *pt_regs) { if (unlikely(audit_context())) { int success = is_syscall_success(pt_regs); - long return_code = regs_return_value(pt_regs); + long return_code = syscall_get_return_value(current, pt_regs); __audit_syscall_exit(success, return_code); }