From patchwork Tue Apr 27 02:33:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lv Yunlong X-Patchwork-Id: 12225247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6E6C433B4 for ; Tue, 27 Apr 2021 02:35:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFA99610A5 for ; Tue, 27 Apr 2021 02:35:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFA99610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=mail.ustc.edu.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=a9PyWjLCAcBV9unVsSKprbNoNLZiyqneoLo+3W/MxUM=; b=Auo38YJrmejmOUQkqNuq6iLN3Y lWnfBJqL4mdjGS3KcqpkJf+fycSyeS3OnPyfPVkYiRW/uMFANWfEXnvGIcJaawLdoKBc7OUS2Y7XR JCucZpGl92bgKaJ/PeRleLknhdbA7+Vic03XiZmMV9FmzMggU+TZRlJ79ocRRwWg+MZAErP380Ye2 l7hWQYK2BJ/64y3W6f0w2p5KOt3av6kkBZjYmy5VHMZk6L8aDSn5VtodhDtEufl2DK/QRTJpxSC3Y MkXC1qEqpaAIruIsU1UdpBfHKbApzg+0jR5I4aQw9bxCkho9hBz6yVNtSq735cMMbsNHTzOH5c5EO jQZ81qSg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbDXj-000TnO-Ui; Tue, 27 Apr 2021 02:33:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbDXg-000Tmf-BA for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 02:33:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=Igzk5PmTAUDER6EmI3hYvYH4ERMb9GrQy7aidDxiQFs=; b=Xg9uplfG5DjXtg0nRlijGlPoDG jh7A3WQ6/aPv6KRXMADXJf5SoYclSOBrFBBu9B4nTlE2UwrYdi04ttJ5j4Fwe/BFwADjnkDhsDwNJ Ga24PQJmwaB8Y8wEVDH42pC1Etv1jBxNXHyyeSdC4jeTD/5TuMTx6qBuyeLzDfWDLzKYM1yPVIm4J qNrtkFEheyKI6WmpODGRwfA/14U6vHYCroRDmIQMmWeu2Y9l7uCNnSVMUUZ2yY4iFwoXSvNqnGhsB z9Ukw6I2tLZAziYV5rh3V6CxBTCKTAulfFlA6DCWnOzkTOw2v7zZdIu2dmslu0Z7Olck+BARtexeS SnLV2baQ==; Received: from email6.ustc.edu.cn ([2001:da8:d800::8] helo=ustc.edu.cn) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbDXY-00GO88-TO for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 02:33:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ustc.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date: Message-Id:MIME-Version:Content-Transfer-Encoding; bh=Igzk5PmTAU DER6EmI3hYvYH4ERMb9GrQy7aidDxiQFs=; b=FA6GD9/9E2kcl9yj0RPl1R/6sn sSinb3yQKUVmUL6H+C0tj5+MFgP5oTPuYqqmVc8PmJE9iWXmaQZXLjLCJg1HIzma eavNyJB6NjvCJkgV6hkyCHjtfIZY4dZQ/8Dl0ZL26B37BaH3I4zaTD/cX7NcTvtb unEPr/axciZ49WqfA= Received: from ubuntu.localdomain (unknown [202.38.69.14]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygAnL6_ud4dgFftOAA--.758S4; Tue, 27 Apr 2021 10:33:18 +0800 (CST) From: Lv Yunlong To: s.nawrocki@samsung.com, mchehab@kernel.org, krzk@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Yunlong Subject: [PATCH] media:exynos4-is: Fix a use after free in isp_video_release Date: Mon, 26 Apr 2021 19:33:15 -0700 Message-Id: <20210427023315.4537-1-lyl2019@mail.ustc.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: LkAmygAnL6_ud4dgFftOAA--.758S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Gw1UXFWfZF4rtF13tr4ktFb_yoWkCFc_u3 48KFnrWrZ5tw4jy3WqyFn5ZrWFyrZ8Xa93CanagFW2y34UAF4xtF4qkrWI93ZrGa17GFZ8 Jrs8XF1UCr93CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbVkFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1lnxkEFVAIw20F6cxK64vIFxWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I 648v4I1lc2xSY4AK67AK6r4UMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAI cVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2Kf nxnUUI43ZEXa7VUbBMKJUUUUU== X-CM-SenderInfo: ho1ojiyrz6zt1loo32lwfovvfxof0/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_193333_661070_30AEBE64 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In isp_video_release, file->private_data is freed via _vb2_fop_release()->v4l2_fh_release(). But the freed file->private_data is still used in v4l2_fh_is_singular_file() ->v4l2_fh_is_singular(filp->private_data), which is a use after free bug. My patch set file->private_data to NULL after _vb2_fop_release() to avoid the use after free. Fixes: 34947b8aebe3f ("[media] exynos4-is: Add the FIMC-IS ISP capture DMA driver") Signed-off-by: Lv Yunlong Reported-by: kernel test robot --- drivers/media/platform/exynos4-is/fimc-isp-video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c index 612b9872afc8..f414493258ad 100644 --- a/drivers/media/platform/exynos4-is/fimc-isp-video.c +++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c @@ -315,6 +315,7 @@ static int isp_video_release(struct file *file) } _vb2_fop_release(file, NULL); + filp->private_data = NULL; if (v4l2_fh_is_singular_file(file)) { fimc_pipeline_call(&ivc->ve, close);