From patchwork Wed Apr 28 12:58:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mian Yousaf Kaukab X-Patchwork-Id: 12228717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4812C433ED for ; Wed, 28 Apr 2021 13:00:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 478DA610A5 for ; Wed, 28 Apr 2021 13:00:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 478DA610A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=JVtqki0fEo+5gcjNAIcyObxwSUYBnHQNjZf1o76Rrl4=; b=J44/Mgu9jFJKzVcM6PM3rkEJHL n2rW7XBQW7B22YE3UQasPoraUQfuTmGlvqa8yn1QetSmxYmfv9Xb+U3C0+sXDdB/AAurju2BamBd5 8RJPg9GlojdZRtkoRX1e9db2zcrgrDMh2L7sYtGePfWxS1uuNATxjAnyvcn+wJVBwUuDvkyY4vXjb CANX4RF6yN0R8X2YGkE2NrVWqK3RWy3qWWaXnp6BvDWrWOvd9W5PcQFrrpaSsQKlRL9rfq2xnVr8p wVpUt1yFOkVSfFrDG3RaFIL0srTxIhFsfbHAOHPr8U93OeN274M+MLkE7KuWMjwzunO/k4RZQy1Gx hCHqBjsA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbjlw-003V3D-7l; Wed, 28 Apr 2021 12:58:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbjls-003V37-5Z for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 12:58:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=b4xgRmLW99jDlCam5VPyZHjGfYVbPai1DajMzeLo1TQ=; b=Vx06+mavYUEf7o65obJPfy27uU Obs2mB3pZbgYOm2CqZvO5fvR9+msiwJ5G9OmXVsPGyyZ7/k2Eq6cWjlv7BQrc7DyQHPA2SG52jAc7 4EEPeOimxinEcjiBchTHZfbVut46cuyyyiGIoZP/soV8ouuDsmsEsRNmZDBCpttGnsywSrCPiZIGx eECePFFGadGFjchArm3gGAm02NFvj9IexTqEo3kfiXjNQB0w20LYxmL3aUY0qGbWqDtuGJVxgy878 /VsSCJKbGJrTedNfkcx/rT5vyaDY62kzZrk1ZTkjqcrQbcHSHSQQynpbS85wBtYVDYz1iys18h+tS y0s5tB9A==; Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbjlp-00HRE9-EM for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 12:58:26 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D6429B170; Wed, 28 Apr 2021 12:58:19 +0000 (UTC) From: Mian Yousaf Kaukab To: shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mian Yousaf Kaukab Subject: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node Date: Wed, 28 Apr 2021 14:58:07 +0200 Message-Id: <20210428125807.29553-1-ykaukab@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_055825_654141_D8D925F2 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module then its probe fails with the following warning: [ 10.471363] couldn't get idr [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0 ... [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16 Reason for the failure is that bus-num property is set for dspi node. However, bus-num property is not set for the qspi node. If probe for spi-fsl-qspi happens first then id 0 is dynamically allocated to it. Call to spi_register_controller() from spi-fsl-dspi driver then fails. Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property optional") bus-num property is optional. Remove bus-num property from dspi node to fix the issue. Signed-off-by: Mian Yousaf Kaukab --- arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index 135ac8210871..801ba9612d36 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -929,7 +929,6 @@ dspi: spi@2100000 { QORIQ_CLK_PLL_DIV(4)>; clock-names = "dspi"; spi-num-chipselects = <5>; - bus-num = <0>; }; esdhc: esdhc@2140000 {