From patchwork Thu Apr 29 11:00:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12231041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05033C433ED for ; Thu, 29 Apr 2021 11:02:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8794061445 for ; Thu, 29 Apr 2021 11:02:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8794061445 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=H4gpKCpMhqfEYFoYiVzJSJWfwelfW0S4oAViMcqoA0A=; b=N/FK4qiu8NBlub23q0OSEVX1WN RZ3x1XnlwZlJi1qhuBUkG3pOB5abu5dqAlne7+RG9Wfknj6x3oXA9iwemu6wB4YcNLDqIVm735juk dhDpvphFoI/fJtIn0rXRtueoN6pPYtAHuPref6sxKEc0ZDKsHfTU4dfcPbkySQhZ0x3hNtrOFuBSu MN8FlB8mSr8+9gna1CeBavgYFy9VWwxFSOMZtbRbYDvVdHhWrFs+O+PnTHsT3t0i5cEhwzZgYqbu/ nozK1hPxg08ef6jUDDTjn89IOi6qHNoF6BSbzJ7h/QwIGnGS0BfBv38U4QPypbxVzoAj6pP5W/uHo dP0csBgg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc4Pf-005WeC-HH; Thu, 29 Apr 2021 11:00:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc4Pb-005WdE-Mi; Thu, 29 Apr 2021 11:00:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=+Xil6gAEp1O1wwTat6Pzs8mEGBivA32lf3ycXFIcDPo=; b=Kbq81aRwAKjmHwPTV1mu3UxmVp CRM9UJXQAEhkdIRYriiN0UqVATRMfRa+HdxJvVPzhCKrfG6Cclh3DRD93kcZLKG9om60oXls32hnk FKsNFSKHcNDfCL/TEpQqHeKNlPVkxjFgV92FgFxq5S7YPRSFVk51hNn8wII+VL69CHOq8ikNwTHtg zf5Pf70c62VBa2XCzu0nXseNeUZxT+J9HhMmDDQOxEITY4BgLYUIF/jfgaALbGnvR2p5VJ0hWtqMw GqssjcxyTL3dcgtHKc/TkQKE8vWB8lWoS6Sxgzilf3XbPTa2rmEzapweF9QM03AyuqR1FaQAvCjpe 0MWbAEkg==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc4PY-000Zsj-TF; Thu, 29 Apr 2021 11:00:50 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lc4PQ-0000ev-DZ; Thu, 29 Apr 2021 11:00:40 +0000 From: Colin King To: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] PCI: mediatek-gen3: Add missing null pointer check Date: Thu, 29 Apr 2021 12:00:40 +0100 Message-Id: <20210429110040.63119-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_040049_098002_43B998AA X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Colin Ian King The call to platform_get_resource_byname can potentially return null, so add a null pointer check to avoid a null pointer dereference issue. Addresses-Coverity: ("Dereference null return") Fixes: 441903d9e8f0 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192") Signed-off-by: Colin Ian King --- drivers/pci/controller/pcie-mediatek-gen3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index 20165e4a75b2..3c5b97716d40 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -721,6 +721,8 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port) int ret; regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac"); + if (!regs) + return -EINVAL; port->base = devm_ioremap_resource(dev, regs); if (IS_ERR(port->base)) { dev_err(dev, "failed to map register base\n");