From patchwork Thu May 6 15:31:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 12242585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2704C433B4 for ; Thu, 6 May 2021 15:39:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56449610A1 for ; Thu, 6 May 2021 15:39:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56449610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3oaK5jkexc0u/OTxYd/2yyR+eISvbWGzzDD3kl/WkIY=; b=NFmalN2yytTYnabR2gOVzfJRe m6Sev/mAGkAKzGRMSSFJp8dOWw7QuGoJDNfdQweFmNYNFP3snmyiOhgd1ct6bV88SwPqTkQQGMZD4 TMJsZMzl+b4Kze1eueZE+93TIJ8/kuqqVKoxd3s55yC6tF5C6uZsovZOImfarFiUi6uGo2q2rA4HI EAsJ/rngHOGt9U4np/bZL9nLfDzEDxE2yFWAKzO63HksoBraiZtjceuGWq3PEVdp7/BIzH+eNDlXW sQtlZkogpfrb9T5XuL1j/TQYovQMarYVeemD3b54g01jeWCYRLUFokpFGDBOxTmYVVE3LKKf+8tHH /FAz/3Wag==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leg4X-004bm1-Ea; Thu, 06 May 2021 15:37:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzl-004a58-RC for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 15:32:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=/OJRZ1Bl7p7tGJShkPLHTGnIWIyLBhcE19DqCn8zrpw=; b=zfyg7EzRNWCw85Xf9Qku/BcQln NXk2SQF2+9tYl2l1QjT5lXAa+J1TEmLMOLyR0d3f+dXIIBtX3fMK5O2YaafMkR/ho6NRIR+3u/B3s rr+KmABTpAhUb77UVtEDd0StLJM39uI+yObL5/jFXnmr+fnINg5PXS7VURA1+IDlH+6vS1TP5XALZ A1oZLg21lVd3QheA6E5++o8eMVuc+uz0OiSc2W941lQjclBLxNyq9/+1iqLdMGKlMnUxum2F+IzgI Ejanl+kL8bK87d97bJoiJKqaGyb5oqWLsowGxbfslYGcSlme7SKcGDH4WIBQkIE9dfdrzLKgTITj7 CAdpzv2Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzf-0069iC-QZ for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 15:32:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4FA4613EE; Thu, 6 May 2021 15:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315168; bh=zoiVY2XI6nExpUKOXT9A0hPboS1rFrKCjUz6eR0Qm/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iWR1wIeo72aTtyzz5OLdJt76iqVyuXbceGj5Q/uy61i57HtsZ+9M/68WFGLZVmVdL lP6mcXCe/m7gYGy7wPMO/0uGwUM3eWPvwFi8Bvvqo5kOYIN8n/2OFZr/yrF8ykeLf6 rFcq87GBCQzC7jqHlwRwGhQ9ejlGRq8hzt6BI9R9s2XCVZy+jBl78cTAgE2uiBsICa 9OPd4hsI5zUrA/P7U4JWDEpfku/xLArJrGEnRUIyysATpQ8hbiAkHJC/wWEGVqFqHQ 9X2W8YwGV4iKY0ApEIqMLY0vyw3jVWpXBwFGhgIg9MDP7m7JmkDOj/JOQxXg8O2Ys2 WDlvbGFWcNYlw== Received: by pali.im (Postfix) id 7BDF98A1; Thu, 6 May 2021 17:32:48 +0200 (CEST) From: =?utf-8?q?Pali_Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?utf-8?q?Marek_Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/42] PCI: aardvark: Change name of INTx irq_chip to advk-INT Date: Thu, 6 May 2021 17:31:26 +0200 Message-Id: <20210506153153.30454-16-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_083251_963751_CAB06C1D X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This name is visible in /proc/interrupts file and for better reading it should have at most 8 characters. Also there is no need to allocate this name dynamically, since there is only one PCIe controller on Armada 37xx. This aligns with how the MSI irq_chip in this driver names it's interrupt ("advk-MSI"). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 08f1157e1c5e..c50421af9d06 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1022,14 +1022,7 @@ static int advk_pcie_init_irq_domain(struct advk_pcie *pcie) } irq_chip = &pcie->irq_chip; - - irq_chip->name = devm_kasprintf(dev, GFP_KERNEL, "%s-irq", - dev_name(dev)); - if (!irq_chip->name) { - ret = -ENOMEM; - goto out_put_node; - } - + irq_chip->name = "advk-INT"; irq_chip->irq_mask = advk_pcie_irq_mask; irq_chip->irq_unmask = advk_pcie_irq_unmask;