From patchwork Thu May 6 15:31:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 12242681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE49C43600 for ; Thu, 6 May 2021 16:03:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C8E5610FC for ; Thu, 6 May 2021 16:03:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C8E5610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7+Uy95AfoN1Ayl/sGeeOSk0EJFHRv5bA6FsYlHUorJU=; b=nju9QGpfZ0t+TXmWIfd92NSMj tT1w4m4zFbK87ZddHh1fwc5s8Bs+K2Nk/ElCIg2Dg3gSyK91YK+e4XPWD74dEyGQRpRtfoLfF3pyu Nn4Z7iuje3ld31V6q70CEzIasMiGoIzzq/tbmXeZ7qZQ2y5+DyOyBdintagZsNb0PFWEENLCszT3I w6q52LqxJMlR1pq8WSOAlTw/G4kX6yKh9rcAGoFSVKIEN3STzM1ObSH6ZWNOiHkkFJnkv+QHw/jjK pOK3zTrNGWHsuqBbOLdA6KCYBhlrjRcp1mYu0w1I15AHUGa7lFF8N/UDR7veF5pUjqIKzmuOP+Xn3 Cqs7SfIdg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1legCr-004ea0-53; Thu, 06 May 2021 15:46:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzq-004a7r-O9 for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 15:33:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=5QnKiVvlMGggt+u+Rbfh/wgi8B39h3AKsBB/TYS2YXE=; b=m208AWT8XqCP7mQ16Tl1xKS76L PgA8dry56HbPuvmSMBLYrQye61Zg2Jk2ti0VTe2UzrQkbQVC0k5tkJjybW98Seq1CJ9c/xJdXuqdR OP0sN33s8nZbXVQgHPMTUuA2Egc88SxgUJsDNjvatIJXkVDUDPYc0XuAQNeuR8M9X9BiqilXEMYEP j85IYNA+4ScYvu7PzWwPS+uxHpLhFk+nv0wz0wSJ2tBHHfekg35ahIcYJDPiR2+dyUfmNzoe+MHdL AmtmQ2G6Fz6dmbYZAHb9rQ/SWLJifme86xfCWbj3JVu75qjhk34RCjJrsxxa74oVNkA57j6meWXuS u4UQRThA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzl-0069o6-GR for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 15:33:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0526E61469; Thu, 6 May 2021 15:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315174; bh=zi+PML1cWSulO/GYWf9yak7a3W+RSD4MegJIQ/xyX/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EqDJhLO1Hbf8GkvCKJD0Nzd3ZOEPegQ4Ex2n1YeJtatlQl6Tr4bvmFR9YYqpgSfqb BX4/PEJZLywUrkQrde7yaSPg/j5lrsNr8UlJ44x1jVDO5GS4GPG+/eJo+sGYb+OKro GQHHh13UH+UCZ2TOlXFdq696tTnU9DaAsE3hhTnwH33W047YxWZ2ZixmzjtoF4AoqO N7q6gFcsJOkOEEnUjLywFP7y/SJT+kIm4jDnurpRFmXqfb9+XYfe2YcR6Z/vsTru6I lz+ngyp3uxxpZmbe5h7lWGZT1u1XE1WJLPaklxoistVSrSAkZsUXFwxF7xmFgyJC2U GtL62ZeX3tDUA== Received: by pali.im (Postfix) id B509A8A1; Thu, 6 May 2021 17:32:53 +0200 (CEST) From: =?utf-8?q?Pali_Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?utf-8?q?Marek_Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 32/42] PCI: pci-bridge-emul: Add description for class_revision field Date: Thu, 6 May 2021 17:31:43 +0200 Message-Id: <20210506153153.30454-33-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_083257_596485_3934D2ED X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Make it clear why there is bitshift by 16 and rewrite the code to align with the new description. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci-bridge-emul.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c index fdaf86a888b7..2b6ea84f25af 100644 --- a/drivers/pci/pci-bridge-emul.c +++ b/drivers/pci/pci-bridge-emul.c @@ -265,7 +265,11 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge, { BUILD_BUG_ON(sizeof(bridge->conf) != PCI_BRIDGE_CONF_END); - bridge->conf.class_revision |= cpu_to_le32(PCI_CLASS_BRIDGE_PCI << 16); + /* + * class_revision: Class is high 24bits and revision is low 8bit + * Class for PCI Bridge Normal Decode has 24bit value (PCI_CLASS_BRIDGE_PCI << 8) + */ + bridge->conf.class_revision |= cpu_to_le32((PCI_CLASS_BRIDGE_PCI << 8) << 8); bridge->conf.header_type = PCI_HEADER_TYPE_BRIDGE; bridge->conf.cache_line_size = 0x10; bridge->conf.status = cpu_to_le16(PCI_STATUS_CAP_LIST);