From patchwork Tue May 11 11:49:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 12250893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DD5C43462 for ; Tue, 11 May 2021 13:14:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 914A361921 for ; Tue, 11 May 2021 13:14:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 914A361921 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=sc1X9ZzBWa2QX22ATBwrNgcUReFr1frk9e0TqrSFrag=; b=h+lIs568MMYXPORYmhuNgL0Oiv AHbAfZ+aXI8rlN7RAVS5Id5duLoOdlOQCwrycRPn/JFTjm8kpNx+DxwUoaiRZD2hEPiaANFdVNQRv hVlpJSLkJRZtPDbYSE0y2AjzOcXZeum53BLwvyxo5TeYwIbCNujbOax/uDrc69S1VL8pLzizJD64n yXUP+Z2U3g2R93wQ0D8tLh9B7eVLp6iSq3vj9ibst415qAcjF7igHCjHCucaNrrxQR2dZbnfm+1gO Xf3GSsFDqJAvSAsrmT9mYTV7/xCflPTNu75Ak7SkY1B8ZBo9ij/i9EaG5DIFqEkwd/fqpOspHjfov pxyeMqWQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSCE-0000mQ-AD; Tue, 11 May 2021 13:13:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQtY-00HDJ5-W8; Tue, 11 May 2021 11:49:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=mSXnRVfWAumsjPlX5BuAJ/pWhNr1bWGiItzejwnljBA=; b=WbNOZbrg6IEn6ot07LEA3EjXci jLwm7dqE0+yNULcQF5iYFdbZ9Z6cQWGDDuqepS9feCuMo+A1fbqxX3RHyJhG0pQJXJDFdooQ8WVNv J5TnZRWKimEA5ClddC8J4ldeMdCiW1SWfp0F9KSfzfVGbmUQiZCNPus97mK17A1kxzYCPvvJR1JEU 27DI4g/CuU9SFFBvQu42XlVfxlOYbmdT8HVy5LY5vsayL5+YYqaVxeBgA7EePBgXjXmxlG5dD4QDt PWkNov3pVfe9YNDxiPZUdGpih1BYOWJzwH/63YR9JOgCSZB74+1cHE2YPZsOPjBnpl+ACjJlvC+tP cpbMhxbA==; Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQtV-009XGZ-Q8; Tue, 11 May 2021 11:49:47 +0000 Received: from dggeml763-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FfbkG40Jhz61T1; Tue, 11 May 2021 19:47:02 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeml763-chm.china.huawei.com (10.1.199.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 19:49:41 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 11 May 2021 19:49:41 +0800 From: Zhen Lei To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , linux-mediatek , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] drm/mediatek: mtk_dpi: Remove redundant error printing in mtk_dpi_probe() Date: Tue, 11 May 2021 19:49:36 +0800 Message-ID: <20210511114936.5666-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_044946_032628_BEA754EC X-CRM114-Status: GOOD ( 10.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/mediatek/mtk_dpi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index bea91c81626e154..891a109ffe441d8 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -743,7 +743,6 @@ static int mtk_dpi_probe(struct platform_device *pdev) dpi->regs = devm_ioremap_resource(dev, mem); if (IS_ERR(dpi->regs)) { ret = PTR_ERR(dpi->regs); - dev_err(dev, "Failed to ioremap mem resource: %d\n", ret); return ret; }