From patchwork Fri May 14 18:55:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 12258645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33785C433B4 for ; Fri, 14 May 2021 18:58:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E67C4613E9 for ; Fri, 14 May 2021 18:58:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E67C4613E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ki9Fp7az7CAa3c7XLIzANL2Bwm2/Xnd64jgRSg1uG0E=; b=IBPU/yzflqBHSpeWHuaPTcuab jAFSR/LNaaxJyHY9t1ofGQ1yEIgWlzF9vxOFCX8H8u6tVoedX8fMsrlOenk88ldChd/Ab6DvkXiL4 32o6LsG34DQzgUcIdDKEcdDZAAOeb++onxy5MnlAc1Of3SvmS171Bt4tOKDG9mT4oDSInJ3B++ay3 igmk/pnqwBgIqY6O7dI5BlQhSI32tiNN/6P3XuqnjIcax1zgW787VU/eOI0fmEx3gYv5RaJWge7cf eeK/EY18h4dyEc99L7+BqoBV5+QzDF6WFd5W2cGJ9KBj5S7o3W4SE3GuU+3oFtqfnrtRgud8WQzVE 0E3mS8eKA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhcyy-008kLR-Dm; Fri, 14 May 2021 18:56:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhcyi-008kHL-Bd for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 18:56:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=aIH+b0GcZ8y25PBNAB55HaGHxbJE5IpyGf18xNdDBl0=; b=Kef36xcWFtqspw9cDt2vaw4USY Dfc9K/t3dGZa0xQhfP6cVxMeumf7MWNaPvsT5ctU0OXSgdVuc7IZKIdQ9dxsaDEXEM2nav/DSnQjU Ko7K9Tg2gzIw+/GXUXr7g5nzhE6pyi8OIwngAEuDTebvKp3+RqUY4OOK4V8JP8hoee3b6o+d0pzVt 7skqdS0nMJqX3Ud4lC5vPDm+/Awha8qhl7miQyMajrCDNKBapqlh7OtD6TBMlVWM4P5HpvQ7ZAokd P0f8vtbp20nkiVXl7l3og6lvjixRoMmoOIy5qltDLyj3xeAbovjs2uz+cGxJQKvfvuMCt1v3QR+vY 51ihNI1g==; Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhcyf-00CBsf-Ll for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 18:56:03 +0000 Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 088D922253; Fri, 14 May 2021 20:55:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1621018559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aIH+b0GcZ8y25PBNAB55HaGHxbJE5IpyGf18xNdDBl0=; b=OFH22zjEuWilKr8OSzP0oNbyyGRH3ZKvAIfVlwEjRYTfeEt3KbXqNEagRxMdL/1Dcub6zp TKctZnFq9e+UhJ/fnmFVEtVx/P5sezfJfKhj+eXfwBeitw6WY0+WQWtmG+KN+7YfmyeNOZ z6vNXuLO1EUhiXvtE49DezxIGVwRXsQ= From: Michael Walle To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shawn Guo , Li Yang , Rob Herring , Michael Walle Subject: [PATCH v2 1/2] arm64: dts: freescale: sl28: var4: fix RGMII clock and voltage Date: Fri, 14 May 2021 20:55:52 +0200 Message-Id: <20210514185553.10095-2-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210514185553.10095-1-michael@walle.cc> References: <20210514185553.10095-1-michael@walle.cc> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_115601_896144_FA92EE62 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During hardware validation it was noticed that the clock isn't continuously enabled when there is no link. This is because the 125MHz clock is derived from the internal PLL which seems to go into some kind of power-down mode every once in a while. The LS1028A expects a contiuous clock. Thus enable the PLL all the time. Also, the RGMII pad voltage is wrong. It was configured to 2.5V (that is the VDDH regulator). The correct voltage is 1.8V, i.e. the VDDIO regulator. This fix is for the freescale/fsl-ls1028a-kontron-sl28-var4.dts. Fixes: 815364d0424e ("arm64: dts: freescale: add Kontron sl28 support") Signed-off-by: Michael Walle --- .../boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts index df212ed5bb94..e65d1c477e2c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts @@ -31,11 +31,10 @@ reg = <0x4>; eee-broken-1000t; eee-broken-100tx; - qca,clk-out-frequency = <125000000>; qca,clk-out-strength = ; - - vddio-supply = <&vddh>; + qca,keep-pll-enabled; + vddio-supply = <&vddio>; vddio: vddio-regulator { regulator-name = "VDDIO";