From patchwork Tue May 18 09:17:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 12264347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C235AC433ED for ; Tue, 18 May 2021 09:36:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43E956109F for ; Tue, 18 May 2021 09:36:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E956109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Subject:Cc:To:From:Date: Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=MifF82oWpDE1zuoERFjmQxm+PTvhmBaC7ahFQOpStGw=; b=lxSG23nkIrYNHvWnJjOqLJgcp yAaBYN5ayChhDAw5s7tMD+JeNndA4uMTGVyspIPNkzO+uIptduoxV6w5oZRPdwyINUNzpsmBhCXeP 3PEpVWNN1+GLZCQXDuTLrSurFqkQAEA8VgBuKjfhBdDU4GF8kRsn1AwBD+H8FOP9S0T/nRkaoNTJa 3/pnQ/k7j8ysu+TV4ZDHoxsSWUrHXZgWGpJXj86dC8a5SXStjq8M0YwZEXimFnODYYHKiMDcdjZXT ZhrUakQkGpXyw+ZEFwMUPOrzTZMS0LIRjjIN21tIMs0ZXyhS6JWk5IzR+z2MU8pGLgLwE//JHq4EC kG7ScWE0g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liw7Z-0009XL-Qe; Tue, 18 May 2021 09:34:38 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liw6L-0009CQ-OD for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 09:33:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-transfer-encoding: Content-Type:MIME-Version:References:Subject:Cc:To:From:Date:Message-Id: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To; bh=llqiZZOpujTFGvfM7I86v3/lISoIngOGifb8EaNbJmk=; b=E1H0eIRwFIBEqLprEsWD0P3grt a4/dJ+Jbcs5tzVogrqQ+RuuJdMD/mw/AuB8PFXRdODdVMZtHRuFDTatva7a8XPSVoK9zY6V9cs3sE UQK9MMrt6FkmNuRkTRS6ZKXKztJQwmVasBhivbKlUpOfDSFOQYNeWm99/odz0gbEy6V2lf0p34XkZ QxluOTCNHv2ng4lKIKduH5cbK+VdO3GRmj5Vj60yKexapSkf0IO+IKXRZ8pLd3I3sApZ22+atbpWt THbF5ASBp0gTqx9KV5MfSViMXJdP6Ih6gbBsgyyB+iJtlPDaq1/fLqlnk3hkMJaWx0wzAQqA7k+KI tvkoNxMw==; Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liw6I-00EVnq-Uy for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 09:33:20 +0000 Message-Id: <20210518093118.603636289@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621330397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=llqiZZOpujTFGvfM7I86v3/lISoIngOGifb8EaNbJmk=; b=g4WPw7BFA2Un46jknT1BruVtJka+olrBbvzPETf4eW8E6VKHOPmlUg/NiVpImVk/xKpNcJ S3eYYkCJOZ1G6DCw891G3BXApTZ6HnUyzgzSJWQ2wOcXYNbsUqXauU4vW2rpUI8uW2bBiu YZSShOJtESAfokYWne7nWk93ue8YpQ7MvcmdZcEp+hX2WjVHnTLHgsT/4ykiBH6TA26nFN PTwMDh3cWc6eIKo+8Ficiw5eQkOK6LrqPP/KuCxS2RwNu31xF1X9WkAk6cYby0Q5IHlzfg TB2BpiA2c6DjcxI6nljybqaIiqotbX8j28vqNvnJG9wTvEobOl2P2VH6uzakuA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621330397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=llqiZZOpujTFGvfM7I86v3/lISoIngOGifb8EaNbJmk=; b=VIe+CsBTI0rLK2aPQMKFDPakGpP+dpkiWj/B0hUfnrWDhpAUeIr08pJ2oAItFhDg1G0bk6 tVCsrMnP62K2GaCg== Date: Tue, 18 May 2021 11:17:31 +0200 From: Thomas Gleixner To: LKML Cc: Peter Zijlstra , Robin Murphy , Nitesh Lal , Jesse Brandeburg , Marc Zyngier , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Frank Li , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Shaokun Zhang Subject: [patch 6/8] perf/arm-smmuv3: Use irq_set_affinity() References: <20210518091725.046774792@linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_023319_163746_593AA3CA X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses irq_set_affinity_hint() to set the affinity for the PMU interrupts, which relies on the undocumented side effect that this function actually sets the affinity under the hood. Setting an hint is clearly not a guarantee and for these PMU interrupts an affinity hint, which is supposed to guide userspace for setting affinity, is beyond pointless, because the affinity of these interrupts cannot be modified from user space. Aside of that the error checks are bogus because the only error which is returned from irq_set_affinity_hint() is when there is no irq descriptor for the interrupt number, but not when the affinity set fails. That's on purpose because the hint can point to an offline CPU. Replace the mindless abuse with irq_set_affinity(). Signed-off-by: Thomas Gleixner Cc: Will Deacon Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org --- drivers/perf/arm_smmuv3_pmu.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) --- a/drivers/perf/arm_smmuv3_pmu.c +++ b/drivers/perf/arm_smmuv3_pmu.c @@ -628,7 +628,7 @@ static int smmu_pmu_offline_cpu(unsigned perf_pmu_migrate_context(&smmu_pmu->pmu, cpu, target); smmu_pmu->on_cpu = target; - WARN_ON(irq_set_affinity_hint(smmu_pmu->irq, cpumask_of(target))); + WARN_ON(irq_set_affinity(smmu_pmu->irq, cpumask_of(target))); return 0; } @@ -839,15 +839,14 @@ static int smmu_pmu_probe(struct platfor /* Pick one CPU to be the preferred one to use */ smmu_pmu->on_cpu = raw_smp_processor_id(); - WARN_ON(irq_set_affinity_hint(smmu_pmu->irq, - cpumask_of(smmu_pmu->on_cpu))); + WARN_ON(irq_set_affinity(smmu_pmu->irq, cpumask_of(smmu_pmu->on_cpu))); err = cpuhp_state_add_instance_nocalls(cpuhp_state_num, &smmu_pmu->node); if (err) { dev_err(dev, "Error %d registering hotplug, PMU @%pa\n", err, &res_0->start); - goto out_clear_affinity; + return err; } err = perf_pmu_register(&smmu_pmu->pmu, name, -1); @@ -866,8 +865,6 @@ static int smmu_pmu_probe(struct platfor out_unregister: cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node); -out_clear_affinity: - irq_set_affinity_hint(smmu_pmu->irq, NULL); return err; } @@ -877,7 +874,6 @@ static int smmu_pmu_remove(struct platfo perf_pmu_unregister(&smmu_pmu->pmu); cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node); - irq_set_affinity_hint(smmu_pmu->irq, NULL); return 0; }