| Message ID | 20210518101405.1048860-4-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: mm: a few small cleanups | expand |
On Tue, May 18, 2021 at 06:14:04PM +0800, Dong Aisheng wrote: > x5 is not used in the following map_memory. Instead, > __pa(__idmap_text_start) is stored in x3 which is used later. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> It might be worth noting that this hasn't been used since commit: 0370b31e48454d8c ("arm64: Extend early page table code to allow for larger kernels") Either way: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > arch/arm64/kernel/head.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index b70db34458ec..d266b4c6287d 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -354,7 +354,6 @@ SYM_FUNC_START_LOCAL(__create_page_tables) > #endif > 1: > ldr_l x4, idmap_ptrs_per_pgd > - mov x5, x3 // __pa(__idmap_text_start) > adr_l x6, __idmap_text_end // __pa(__idmap_text_end) > > map_memory x0, x1, x3, x6, x7, x3, x4, x10, x11, x12, x13, x14 > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
+ Will On Tue, May 18, 2021 at 06:14:04PM +0800, Dong Aisheng wrote: > x5 is not used in the following map_memory. Instead, > __pa(__idmap_text_start) is stored in x3 which is used later. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S index b70db34458ec..d266b4c6287d 100644 --- a/arch/arm64/kernel/head.S +++ b/arch/arm64/kernel/head.S @@ -354,7 +354,6 @@ SYM_FUNC_START_LOCAL(__create_page_tables) #endif 1: ldr_l x4, idmap_ptrs_per_pgd - mov x5, x3 // __pa(__idmap_text_start) adr_l x6, __idmap_text_end // __pa(__idmap_text_end) map_memory x0, x1, x3, x6, x7, x3, x4, x10, x11, x12, x13, x14
x5 is not used in the following map_memory. Instead, __pa(__idmap_text_start) is stored in x3 which is used later. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- arch/arm64/kernel/head.S | 1 - 1 file changed, 1 deletion(-)