From patchwork Wed May 19 18:38:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= X-Patchwork-Id: 12268295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3891CC433B4 for ; Wed, 19 May 2021 19:16:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC9B76108D for ; Wed, 19 May 2021 19:16:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC9B76108D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Kkv+n+BrvMkgjJrBZkwk5o08zl2Rzf2y2LdhoiRjCm0=; b=UqeOgM3toN4k5dC+YhOwwztGVG LXuLbr7cbgM9P4YDg2KThq5bDQypd/qW89wZ/jz2CZWbqcN6/HWIBV4iVJngtdz2oPv0HOgecwKGJ f8SUeAVioWq7/KFUnoTBvHDlk9LdoFsffFTOfvZ+Hfm5qIUmcbawE/Sywr1mjGd/j3vNylw0QaOjB NYUIOaT/OcFb2uDMQSj2k0ndkEBuGRHJAUsw8lvuIM9VW90LWJHoN76QwcBykggPjDxJ93hv18VlP /OBTF1A794/XuVWlC4zCII7ER3RZkdN6OLxPCeAcR2xdwm0BejCKnJXSwkaOtkyhokxkIULpV928Z Y5A7tGkg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljRe8-004qcf-Hx; Wed, 19 May 2021 19:14:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljR5X-004mvS-Nk for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 18:38:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=L8t4NT32QukReqRKb3NsCwROkTdHScpGYLxCsr2Y3rQ=; b=VBz6lDOjTwUQiHycxr4NWzLcZf 8UPn/4Wj7xEo42LVzye9t4BCyWnZQk9p3Bmui+JeuwuZVi76d0oQbn1mZDaLPx9wi19jMrG/OxEPo WLILbRMRf7L+2nmo3kYhp836Sfw3E8GXfmMk6mGMizg57ZM0hFvD/+n93BKHupDsYkdIeVw6VqDGX TRHdW2J7ug1bxB9ED4owc0PYJy6kJIh/99Xk+GHunH+CmhcBHn9LIALBD8c1r8BP7EmBFG//+qkWh riPAoNbqNdh1ap7HJfiCE+0/zYidmpcXRr9ES8Z0hOpX91J04VShTyYHS9ahnPGITTruTaD4W8zVE yls6gWXA==; Received: from mail-wr1-f46.google.com ([209.85.221.46]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljR5U-00Fhcq-HV for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 18:38:34 +0000 Received: by mail-wr1-f46.google.com with SMTP id r12so15074916wrp.1 for ; Wed, 19 May 2021 11:38:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L8t4NT32QukReqRKb3NsCwROkTdHScpGYLxCsr2Y3rQ=; b=JkoXCJQ7mG1CHe93azbldq69kVR/9fPEcEtZQVR2CVaNcochq6grTiWbMPjJSdSyPk JGEatqI5cf21vcipma1dCC92sfqZC5ToaSP+orxzpmnHyXlQhi0TSq4SKiW8UajrqoQ8 a06ukz1RtYAhmgSiiz0eY4GImc00Og0pJPZXkTI9FlAfEj2jvRtj2YvgR1NSOrtjSVEv qR9dWRTVp8VB1ToEvyHJLAvh0wHfpv+kwT2AIaSF036/W5R06lficFwRnpAhnyGG5ZMc 7P/5cMZ3wdAeCNr+kLzxEDnArClEaGVuHjNSadUieYLGyhknTZQW/uavMYjQ2lJL3ZQw X5zQ== X-Gm-Message-State: AOAM5300CtyPfdW5vnPpgcGptU5HHV7E3G3FGOla1YrEhEygnrhKQYed bAEgamudjmiuWEyZBnw4/ek= X-Google-Smtp-Source: ABdhPJwEIt9r+mxQPzuJWnsQwidF6so1M8PzWXWewsx4a1G+n+xzx6I9b4pWr8SEpnQbZHZDgloGoA== X-Received: by 2002:a5d:63c1:: with SMTP id c1mr310922wrw.71.1621449510610; Wed, 19 May 2021 11:38:30 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id q1sm6583457wmq.48.2021.05.19.11.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 11:38:30 -0700 (PDT) From: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= To: Ray Jui Cc: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] PCI: iproc: Fix a non-compliant kernel-doc Date: Wed, 19 May 2021 18:38:29 +0000 Message-Id: <20210519183829.165982-1-kw@linux.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_113832_608588_E310CF31 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct a non-compliant kernel-doc used to describe struct and enum types and functions in the pcie-iproc.c and pcie-iproc-msi.c files, and resolve the following build time warning related to kernel-doc: drivers/pci/controller/pcie-iproc.c:92: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc.c:139: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc.c:153: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc.c:441: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc.c:623: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc.c:901: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc-msi.c:52: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/pci/controller/pcie-iproc-msi.c:68: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst No change to functionality intended. Signed-off-by: Krzysztof Wilczyński Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- drivers/pci/controller/pcie-iproc-msi.c | 16 ++++++++-------- drivers/pci/controller/pcie-iproc.c | 14 ++++++++------ 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c index eede4e8f3f75..65ea83d2abfa 100644 --- a/drivers/pci/controller/pcie-iproc-msi.c +++ b/drivers/pci/controller/pcie-iproc-msi.c @@ -49,14 +49,14 @@ enum iproc_msi_reg { struct iproc_msi; /** - * iProc MSI group - * - * One MSI group is allocated per GIC interrupt, serviced by one iProc MSI - * event queue. + * struct iproc_msi_grp - iProc MSI group * * @msi: pointer to iProc MSI data * @gic_irq: GIC interrupt * @eq: Event queue number + * + * One MSI group is allocated per GIC interrupt, serviced by one iProc MSI + * event queue. */ struct iproc_msi_grp { struct iproc_msi *msi; @@ -65,10 +65,7 @@ struct iproc_msi_grp { }; /** - * iProc event queue based MSI - * - * Only meant to be used on platforms without MSI support integrated into the - * GIC. + * struct iproc_msi - iProc event queue based MSI * * @pcie: pointer to iProc PCIe data * @reg_offsets: MSI register offsets @@ -89,6 +86,9 @@ struct iproc_msi_grp { * @eq_cpu: pointer to allocated memory region for MSI event queues * @eq_dma: DMA address of MSI event queues * @msi_addr: MSI address + * + * Only meant to be used on platforms without MSI support integrated into the + * GIC. */ struct iproc_msi { struct iproc_pcie *pcie; diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c index 02e52f698eeb..8e45288c9abc 100644 --- a/drivers/pci/controller/pcie-iproc.c +++ b/drivers/pci/controller/pcie-iproc.c @@ -89,7 +89,8 @@ #define IPROC_PCIE_REG_INVALID 0xffff /** - * iProc PCIe outbound mapping controller specific parameters + * struct iproc_pcie_ob_map - iProc PCIe outbound mapping controller specific + * parameters. * * @window_sizes: list of supported outbound mapping window sizes in MB * @nr_sizes: number of supported outbound mapping window sizes @@ -136,7 +137,7 @@ static const struct iproc_pcie_ob_map paxb_v2_ob_map[] = { }; /** - * iProc PCIe inbound mapping type + * enum iproc_pcie_ib_map_type - iProc PCIe inbound mapping type. */ enum iproc_pcie_ib_map_type { /* for DDR memory */ @@ -150,7 +151,8 @@ enum iproc_pcie_ib_map_type { }; /** - * iProc PCIe inbound mapping controller specific parameters + * struct iproc_pcie_ib_map - iProc PCIe inbound mapping controller specific + * parameters. * * @type: inbound mapping region type * @size_unit: inbound mapping region size unit, could be SZ_1K, SZ_1M, or @@ -437,7 +439,7 @@ static inline void iproc_pcie_write_reg(struct iproc_pcie *pcie, writel(val, pcie->base + offset); } -/** +/* * APB error forwarding can be disabled during access of configuration * registers of the endpoint device, to prevent unsupported requests * (typically seen during enumeration with multi-function devices) from @@ -619,7 +621,7 @@ static int iproc_pcie_config_read(struct pci_bus *bus, unsigned int devfn, return PCIBIOS_SUCCESSFUL; } -/** +/* * Note access to the configuration registers are protected at the higher layer * by 'pci_lock' in drivers/pci/access.c */ @@ -897,7 +899,7 @@ static inline int iproc_pcie_ob_write(struct iproc_pcie *pcie, int window_idx, return 0; } -/** +/* * Some iProc SoCs require the SW to configure the outbound address mapping * * Outbound address translation: