From patchwork Sat May 22 01:26:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 12274265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5D5C04FF3 for ; Sat, 22 May 2021 01:28:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A52C2613EC for ; Sat, 22 May 2021 01:28:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A52C2613EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:From:Subject:References:Mime-Version: Message-Id:In-Reply-To:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bBQ5FQHwnhS4MPVR/K1CRIEOQczgRRRDpX1EzAdNcy0=; b=UjPjF7PIDlArZt S8bcEQVqZISFBIdWKoxEENyc5ssn1CIBHOamCnY1HKn9Crfhi+G+RZTXosWzOAR+Fy6mz2yODvnsg tHnUagK3jKLMNPpMFOpud18mtZ6UpnrbXvqHOdkE6u8snzilDzD4nJo+WMlfpIF3XpF3L4vFk0aQ8 AUHes8jk0YaxQXqJS72qYu3fsc8MnaL23t3O0xqYrXuxZqKv9rD52y+piteVI5KYYk0ptmSOpJIMK wPXZuB6fM0SLu3JbzA/VApbJ64iUkdcYtNG69F5TEPUdpEbhhG0EgguPmOhOwRo1JI1YxV+qHCnTy ktcHNAEeimf7/QbGaFtA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkGPX-001Z2h-Ry; Sat, 22 May 2021 01:26:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkGPT-001Z1P-T8 for linux-arm-kernel@desiato.infradead.org; Sat, 22 May 2021 01:26:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gS3/FjH30criEdlZq0ZHdAnAGJSA0ILT1HmCoVmE9Yc=; b=Jk+Q+bnrecgWq4odtBr2UwWkgC OD24WbwYOgjgo+ra+eRJnF6A47+boke/Xo09pSx9kMSEryw+OgVnwAa/l2cnMZRzzObj/suuywk70 k4nuWIO+mweL0UnqjqEdfH8KJBihzGXdxR+bYuXU13hQ2lCNVET2GCePHt6JcFQnopyKh6GO8DxWk uAGiVLs6+0IDn9uqfKJ0Uwf8oe3eqfnRpf7QQ+k9zk+Qswr5d3yaIq5xjUm2/XUhhMAxR2Pk3HGZR AeH3SQwtanj6PTWql2V08GHeBLxNCtqI8q2knxV6hYimn7bZHoawu3aEEeW7RZNfephjjd91KACrr qOJy9iYw==; Received: from mail-qv1-xf4a.google.com ([2607:f8b0:4864:20::f4a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkGPQ-00HWgK-NT for linux-arm-kernel@lists.infradead.org; Sat, 22 May 2021 01:26:34 +0000 Received: by mail-qv1-xf4a.google.com with SMTP id a29-20020a0ca99d0000b02901ec0ad2c871so19076423qvb.0 for ; Fri, 21 May 2021 18:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=gS3/FjH30criEdlZq0ZHdAnAGJSA0ILT1HmCoVmE9Yc=; b=aV10v99JMPHFg1NGBvCWnUWFb+H8K8fj4R2z1KjHTliOlyuuNv7N+E++NFeU+qFtZp 3+FqCv1he5VC08dsXqqBEoOp6dlq+Jim+eqm8bBhg3Wa39Dqo7D3c93BffdlaEcWXif9 gKyWuMLV4UfrKS62gts+QsiUfFhgZSM0wvBZ1vwWmHDaOkAIzh5gikMRUosZD8liZYjE BLZ4d9v3A4E2C1pTRMRgb2VRbAyQMKVD/JqJSvxrxPWl8UN18mHMBEgV8ftxpiAmIuWT dmxDu6tCcGafJAMnYk82Zo6sopbp3ZB6XTbx9MrZ3STv27IcXF//ymaHhlTkLron6P5f L8Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=gS3/FjH30criEdlZq0ZHdAnAGJSA0ILT1HmCoVmE9Yc=; b=W0gg8Lsi8Jgsnrymfj30heV/Et17y+82hAn8MrEm5sQDBnWmhBrIs1V69p+qy4or3p oHHMQ6sfaYxCt5vD/rbQMjp/yncpIQljx+WU7KHCU1ta34YIJidCtp150ujtRKWlY6GU ZTewdRidqlQiS4hJn78QgfKkLkWH+B4IJP6QN6bn3v2ZH4F30IyiS9awdpitT+G65tXb sI4hjGG3qwOG0LCvLm9C3u2ABiUBidXBemG4l0s7Gpkq1dBD3z99kKYPQmxfLKXDXKBA 5TPGKTQr6qbvj5e1xbiY3nhOSIsN2rtWNSYkf8tQc3ahzWyhgiYJ/xF3HT2ViV0+qP61 h53A== X-Gm-Message-State: AOAM533hq1wkGVnxO0ocArRDmiHqAp19BCxtyyFuNPee7tNCd1ifD2V8 UPps0+an541burkJ0TbO762201NjUEK07TEgMRI= X-Google-Smtp-Source: ABdhPJyCEvd+l3Rqhyp51TSzPr9jAnAvnyIGE5YRxodQwxa5AYSuBGV7+leKsEDF2cfme0a7brTTz1HcQqAGnDK+DBI= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:e55d:7de8:da36:30e8]) (user=ndesaulniers job=sendgmr) by 2002:a0c:f64e:: with SMTP id s14mr16600523qvm.56.1621646790253; Fri, 21 May 2021 18:26:30 -0700 (PDT) Date: Fri, 21 May 2021 18:26:24 -0700 In-Reply-To: Message-Id: <20210522012626.2811297-1-ndesaulniers@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog Subject: [PATCH v2] Makefile: fix GDB warning with CONFIG_RELR From: Nick Desaulniers To: Will Deacon Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, Lee Jones , Masahiro Yamada , clang-built-linux , Fangrui Song , Elliot Berman , Sami Tolvanen , Peter Collingbourne , Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_182632_806703_CE377B34 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GDB produces the following warning when debugging kernels built with CONFIG_RELR: BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn' when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations. Peter sugguests: [That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script. Link: https://github.com/ClangBuiltLinux/linux/issues/1057 Suggested-by: Peter Collingbourne Reviewed-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes V1 -> V2: * rebase * pick up Nathan's reviewed by tag. Makefile | 2 +- scripts/tools-support-relr.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) base-commit: 45af60e7ced07ae3def41368c3d260dbf496fbce diff --git a/Makefile b/Makefile index 0ed7e061c8e9..2dbb56f831d4 100644 --- a/Makefile +++ b/Makefile @@ -1031,7 +1031,7 @@ LDFLAGS_vmlinux += $(call ld-option, -X,) endif ifeq ($(CONFIG_RELR),y) -LDFLAGS_vmlinux += --pack-dyn-relocs=relr +LDFLAGS_vmlinux += --pack-dyn-relocs=relr --use-android-relr-tags endif # We never want expected sections to be placed heuristically by the diff --git a/scripts/tools-support-relr.sh b/scripts/tools-support-relr.sh index 45e8aa360b45..cb55878bd5b8 100755 --- a/scripts/tools-support-relr.sh +++ b/scripts/tools-support-relr.sh @@ -7,7 +7,8 @@ trap "rm -f $tmp_file.o $tmp_file $tmp_file.bin" EXIT cat << "END" | $CC -c -x c - -o $tmp_file.o >/dev/null 2>&1 void *p = &p; END -$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr -o $tmp_file +$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr \ + --use-android-relr-tags -o $tmp_file # Despite printing an error message, GNU nm still exits with exit code 0 if it # sees a relr section. So we need to check that nothing is printed to stderr.