From patchwork Tue May 25 06:25:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaxson Han X-Patchwork-Id: 12277985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B6CC4707F for ; Tue, 25 May 2021 06:28:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CF59610FC for ; Tue, 25 May 2021 06:28:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CF59610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYKmyjx9cyC1dJf+bnLuDw9ieA24XhKqeXInRcpB1xU=; b=ch5HB8tks6YAmE lFIS9uoUab98YQlJb28id/xij+risvaIqm/BAtWowqIJkT57lIHY4qydxfanWzAOlGOh04OVSe3w+ 89rGqc6vt7U3D17ejMqMfpy3UaUY9NbitUs6i7tfLRD8VuS7jFTinZQFydyzBXoQeO1Q6M9LSNP3R 3wnC0myiM04Mx6jmsz7GTaupLIu9gkYgt5CzUeuoBqXmIsGpAjo0q6LeUvKPxpViOVsUWV87wL3No b041xXl7VVu16lvwiqJHeQ3ENApg1sBR2Ww0uIr0CHebLp6hOn2zseGCyfA+DgEcUvSHFMaZH/wKG hfzE6TL9scFVbbdv7nuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llQVz-003bxu-S6; Tue, 25 May 2021 06:26:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llQVV-003brM-8o for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 06:25:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8162211D4; Mon, 24 May 2021 23:25:36 -0700 (PDT) Received: from optiplex-7070.shanghai.arm.com (optiplex-7070.shanghai.arm.com [10.169.188.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A2C553F73D; Mon, 24 May 2021 23:25:34 -0700 (PDT) From: Jaxson Han To: mark.rutland@arm.com, andre.przywara@arm.com Cc: linux-arm-kernel@lists.infradead.org, wei.chen@arm.com, jaxson.han@arm.com Subject: [boot-wrapper PATCH v3 3/8] aarch64: Remove the redundant setup_stack Date: Tue, 25 May 2021 14:25:04 +0800 Message-Id: <20210525062509.201464-4-jaxson.han@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210525062509.201464-1-jaxson.han@arm.com> References: <20210525062509.201464-1-jaxson.han@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_232537_408159_9E3D69CF X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since we already have set up a stack above, there is no need to do it again. Also, in fact it's a bug: setup_stack expects the logical CPU ID in w0, and here we always call it with w0 being 1. Signed-off-by: Jaxson Han Reviewed-by: Andre Przywara --- arch/aarch64/boot.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S index 1a5da35..1cdeb1b 100644 --- a/arch/aarch64/boot.S +++ b/arch/aarch64/boot.S @@ -39,7 +39,6 @@ _start: ldr x1, =flag_keep_el str w0, [x1] - bl setup_stack b start_keep_el /*