From patchwork Fri May 28 07:21:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yue Haibing X-Patchwork-Id: 12286321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C9BC4708C for ; Fri, 28 May 2021 07:23:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CA20611C9 for ; Fri, 28 May 2021 07:23:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CA20611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=y6AeGe4LQTGEyzSUfaKF1lRauyRJ3A4H/HAcrvEhPk4=; b=dkhmoTkOhbCt6K uzcgm5RkpulwvxIfpty0Oti0F4lFtT1FGGhWhEUpxXJgAMuawhZyatPwCJnC7FUuU1D3j7yMIh9N6 Glj08L49mKNw7VIzTvCxoNu8Qlt0NcF4boTw/X5EufSgZb2mXV2u+07xxrAMAFuA9lWuaF0f2oP5n 2Keqqiq4B7GNYqpa6/zbqyNDXPL4EqIV0FackIVXyNYjFblTCutcUc3eLRP5RtlVcVCTIrN1pr/AO sxxhCkwlpsR4atXw4NIX0tJ6cEjb781FwuHPupLcuuGVfbt4MygWPvYprySiOEpPCUuJ4p8qJHTOI E/fcilEYVYSEVoGPeGCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmWp1-00CwwF-EM; Fri, 28 May 2021 07:22:19 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmWox-00CwsU-Ph for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 07:22:17 +0000 Received: from dggeml766-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FrwzR576Zz66WK; Fri, 28 May 2021 15:19:15 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggeml766-chm.china.huawei.com (10.1.199.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 15:22:09 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 15:22:08 +0800 From: YueHaibing To: , , , , , , , CC: , , , Subject: [PATCH -next] drm/exynos-vidi: use DEVICE_ATTR_RW macro Date: Fri, 28 May 2021 15:21:20 +0800 Message-ID: <20210528072120.21332-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210528_002216_064408_73523E47 X-CRM114-Status: UNSURE ( 9.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index e5662bdcbbde..a3a95a2c0bae 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -165,8 +165,8 @@ static void vidi_fake_vblank_timer(struct timer_list *t) jiffies + msecs_to_jiffies(VIDI_REFRESH_TIME) - 1); } -static ssize_t vidi_show_connection(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t connection_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct vidi_context *ctx = dev_get_drvdata(dev); int rc; @@ -180,7 +180,7 @@ static ssize_t vidi_show_connection(struct device *dev, return rc; } -static ssize_t vidi_store_connection(struct device *dev, +static ssize_t connection_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -211,8 +211,7 @@ static ssize_t vidi_store_connection(struct device *dev, return len; } -static DEVICE_ATTR(connection, 0644, vidi_show_connection, - vidi_store_connection); +static DEVICE_ATTR_RW(connection); static struct attribute *vidi_attrs[] = { &dev_attr_connection.attr,