From patchwork Fri May 28 11:50:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12286875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9B9C4708C for ; Fri, 28 May 2021 12:10:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 984DD611BD for ; Fri, 28 May 2021 12:10:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 984DD611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BBqpMNs9+QrOISysf6dWmJaQacLADnEw/aKDYbG+BtI=; b=tJ9YG9R82Y/1TE 2w42M+VWgdYSWoviYdLoVC16O/7QLotVN+mrztLt5QuVkDPdGX0bA3vvM6pf7gbLKCnGMmEWDmvIn fFSbe2DSK6gofXRQhIMJPdOjUNB57qq+3/5q8ZzY2/kNcC+yE6b93ObkyXaNeQ8uqPg5UZAEIkjOl qUXixppj5oT9m3fPxq0nB/D1ll6wdo/zqxS8QO1MSPTVgcKB99G5sp5QIQvphNzJ8IZ/cJoqW7akI 54kR0BvCdTSZK/fqCdogn/HIGCn7OaGRVUM9MJwjmfUqTiouY8KbFZw/9eGOVhasgkm39jdlb41P1 B5DiIiDZIisgNX4dv5fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmbH0-00FDBZ-92; Fri, 28 May 2021 12:07:31 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmb1R-00F5VF-Vx for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 11:51:27 +0000 Received: from mail-ua1-f70.google.com ([209.85.222.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmb1Q-000410-5r for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 11:51:24 +0000 Received: by mail-ua1-f70.google.com with SMTP id d22-20020ab031960000b0290223019877e7so1786153uan.11 for ; Fri, 28 May 2021 04:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+A7NmETeNVsWXQhhgLVcq4I2U3ly5GO/4a+00+Ltec0=; b=KcMa9paCfDVIuKhPbJxAe7LyI7F9FnQR0SzGki3oAdKnRRaiihdhTSVK8MUnkIdZbH TozWQzPeBDmYN2R2Hd7mVFpen8NaW3+UyFXEpF9gNHdy0s5G5rcAPCwavPsCLZoWXHSW l2mgVAD6A07WVny1G6N9dic27LB93CcixCGFmreciz+3qqF5AkucXxTfsa1ZziTXRE5M RWymJWwl7jUWWCht49KG3wjDKVbljA9Rv7Oj24n0tEmLW9LpAuRfT8dzq5zxYA3uQYTp CEjfFoDP1A6Aic92sj09nG207BfmqqbwAdwRNqa8YyBlX4VBZeENaqkSCH/9GP+3uRwn uLLA== X-Gm-Message-State: AOAM532p9H5nsh/ADT0ZD1vXVj1zTvIJS5vnn6HjcU6RsDIL3l3/HtZT ECkFcMotlr/WXzJTvPJlfJUNnlNu/INM6JShsMqumMVmR/OFPiVlNJf9OwWB3kUD9Po0UTIXqfz SptHQDs0FDPlXHZANo0putgQivOOkRWY9b79GtSMnSF8hrSdFKqli X-Received: by 2002:a67:6a02:: with SMTP id f2mr6264728vsc.49.1622202680526; Fri, 28 May 2021 04:51:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8wp965ZXdOS/URJI0BlvrioKqZR1rbzc1/KfnNkSONQtzH+C+OVVa8fj46i7Np0GVLTF3wQ== X-Received: by 2002:a67:6a02:: with SMTP id f2mr6264723vsc.49.1622202680342; Fri, 28 May 2021 04:51:20 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.5]) by smtp.gmail.com with ESMTPSA id 189sm669831vkz.51.2021.05.28.04.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 04:51:19 -0700 (PDT) From: Krzysztof Kozlowski To: Zhang Rui , Daniel Lezcano , Amit Kucheria , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 2/2] thermal: sprd: add missing of_node_put for loop iteration Date: Fri, 28 May 2021 07:50:36 -0400 Message-Id: <20210528115036.18222-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528115036.18222-1-krzysztof.kozlowski@canonical.com> References: <20210528115036.18222-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210528_045126_154056_565E61DE X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Early exits from for_each_available_child_of_node() should decrement the node reference counter. Reported by Coccinelle: drivers/thermal/sprd_thermal.c:387:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 391. Signed-off-by: Krzysztof Kozlowski Acked-by: Chunyan Zhang --- drivers/thermal/sprd_thermal.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c index 3682edb2f466..2778971aaf03 100644 --- a/drivers/thermal/sprd_thermal.c +++ b/drivers/thermal/sprd_thermal.c @@ -388,6 +388,7 @@ static int sprd_thm_probe(struct platform_device *pdev) sen = devm_kzalloc(&pdev->dev, sizeof(*sen), GFP_KERNEL); if (!sen) { ret = -ENOMEM; + of_node_put(sen_child); goto disable_clk; } @@ -397,12 +398,14 @@ static int sprd_thm_probe(struct platform_device *pdev) ret = of_property_read_u32(sen_child, "reg", &sen->id); if (ret) { dev_err(&pdev->dev, "get sensor reg failed"); + of_node_put(sen_child); goto disable_clk; } ret = sprd_thm_sensor_calibration(sen_child, thm, sen); if (ret) { dev_err(&pdev->dev, "efuse cal analysis failed"); + of_node_put(sen_child); goto disable_clk; } @@ -416,6 +419,7 @@ static int sprd_thm_probe(struct platform_device *pdev) dev_err(&pdev->dev, "register thermal zone failed %d\n", sen->id); ret = PTR_ERR(sen->tzd); + of_node_put(sen_child); goto disable_clk; }