| Message ID | 20210529105504.180544-4-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Sat, May 29, 2021 at 06:54:52PM +0800, Kefeng Wang wrote: > Use setup_initial_init_mm() helper to simplify code. > > Cc: Russell King <linux@armlinux.org.uk> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Obviously, without having visibility of the contents of setup_initial_init_mm(), it's impossible to say whether this change is correct or not, so I won't be providing any acks/reviewed-bys for it.
On 2021/5/29 20:18, Russell King (Oracle) wrote: > On Sat, May 29, 2021 at 06:54:52PM +0800, Kefeng Wang wrote: >> Use setup_initial_init_mm() helper to simplify code. >> >> Cc: Russell King <linux@armlinux.org.uk> >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > Obviously, without having visibility of the contents of > setup_initial_init_mm(), it's impossible to say whether this change is > correct or not, so I won't be providing any acks/reviewed-bys for it. I realized that patch with introducing the setup_initial_init_mm helper should be send to each architectures, will pay attention next times. Here is the helper https://lkml.org/lkml/2021/5/29/84
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 1a5edf562e85..81de1bf07ba6 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -1114,10 +1114,7 @@ void __init setup_arch(char **cmdline_p) if (mdesc->reboot_mode != REBOOT_HARD) reboot_mode = mdesc->reboot_mode; - init_mm.start_code = (unsigned long) _text; - init_mm.end_code = (unsigned long) _etext; - init_mm.end_data = (unsigned long) _edata; - init_mm.brk = (unsigned long) _end; + setup_initial_init_mm(_text, _etext, _edata, _end); /* populate cmd_line too for later use, preserving boot_command_line */ strlcpy(cmd_line, boot_command_line, COMMAND_LINE_SIZE);
Use setup_initial_init_mm() helper to simplify code. Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- arch/arm/kernel/setup.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)