| Message ID | 20210531100108.162056-1-joerg.krause@embedded.rocks (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] ARM: dts: imx6ul: add spdif node | expand |
Hi Jörg, On Mon, May 31, 2021 at 7:01 AM Jörg Krause <joerg.krause@embedded.rocks> wrote: > > The i.MX6UL has a SPDIF located at start address 0x02004000 in the > AIPS-1 memory region [1]. > > SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine. > > [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2, > 03/2017, Table-2-2 AIPS-1 memory map, p. 158 > [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1, > 11/2017, Table-2-2 AIPS-1 memory map, p. 178 > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> The patch looks good. Did you have a chance to test this on your hardware? Thanks
Hi Fabio, yes, I am running it on a custom i.MX6ULL board: ``` imx-spdif sound-spdif: snd-soc-dummy-dai <-> 2004000.spdif mapping ok ``` Best regards Jörg Krause On Mon, 2021-05-31 at 18:32 -0300, Fabio Estevam wrote: > Hi Jörg, > > On Mon, May 31, 2021 at 7:01 AM Jörg Krause <joerg.krause@embedded.rocks> wrote: > > > > The i.MX6UL has a SPDIF located at start address 0x02004000 in the > > AIPS-1 memory region [1]. > > > > SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine. > > > > [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2, > > 03/2017, Table-2-2 AIPS-1 memory map, p. 158 > > [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1, > > 11/2017, Table-2-2 AIPS-1 memory map, p. 178 > > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > The patch looks good. > > Did you have a chance to test this on your hardware? > > Thanks
On Mon, May 31, 2021 at 10:01:08AM +0000, Jörg Krause wrote: > The i.MX6UL has a SPDIF located at start address 0x02004000 in the > AIPS-1 memory region [1]. > > SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine. > > [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2, > 03/2017, Table-2-2 AIPS-1 memory map, p. 158 > [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1, > 11/2017, Table-2-2 AIPS-1 memory map, p. 178 > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > --- > arch/arm/boot/dts/imx6ul.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > index afeec01f6522..f9c867e97b9a 100644 > --- a/arch/arm/boot/dts/imx6ul.dtsi > +++ b/arch/arm/boot/dts/imx6ul.dtsi > @@ -210,6 +210,30 @@ spba-bus@2000000 { > reg = <0x02000000 0x40000>; > ranges; > > + spdif: spdif@2004000 { > + compatible = "fsl,imx6ul-spdif", "fsl,imx35-spdif"; New compatible needs to be documented. Shawn > + reg = <0x02004000 0x4000>; > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; > + dmas = <&sdma 41 18 0>, <&sdma 42 18 0>; > + dma-names = "rx", "tx"; > + clocks = <&clks IMX6UL_CLK_SPDIF_GCLK>, > + <&clks IMX6UL_CLK_OSC>, > + <&clks IMX6UL_CLK_SPDIF>, > + <&clks IMX6UL_CLK_DUMMY>, > + <&clks IMX6UL_CLK_DUMMY>, > + <&clks IMX6UL_CLK_DUMMY>, > + <&clks IMX6UL_CLK_IPG>, > + <&clks IMX6UL_CLK_DUMMY>, > + <&clks IMX6UL_CLK_DUMMY>, > + <&clks IMX6UL_CLK_SPBA>; > + clock-names = "core", "rxtx0", > + "rxtx1", "rxtx2", > + "rxtx3", "rxtx4", > + "rxtx5", "rxtx6", > + "rxtx7", "spba"; > + status = "disabled"; > + }; > + > ecspi1: spi@2008000 { > #address-cells = <1>; > #size-cells = <0>; > -- > 2.31.1 >
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index afeec01f6522..f9c867e97b9a 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -210,6 +210,30 @@ spba-bus@2000000 { reg = <0x02000000 0x40000>; ranges; + spdif: spdif@2004000 { + compatible = "fsl,imx6ul-spdif", "fsl,imx35-spdif"; + reg = <0x02004000 0x4000>; + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&sdma 41 18 0>, <&sdma 42 18 0>; + dma-names = "rx", "tx"; + clocks = <&clks IMX6UL_CLK_SPDIF_GCLK>, + <&clks IMX6UL_CLK_OSC>, + <&clks IMX6UL_CLK_SPDIF>, + <&clks IMX6UL_CLK_DUMMY>, + <&clks IMX6UL_CLK_DUMMY>, + <&clks IMX6UL_CLK_DUMMY>, + <&clks IMX6UL_CLK_IPG>, + <&clks IMX6UL_CLK_DUMMY>, + <&clks IMX6UL_CLK_DUMMY>, + <&clks IMX6UL_CLK_SPBA>; + clock-names = "core", "rxtx0", + "rxtx1", "rxtx2", + "rxtx3", "rxtx4", + "rxtx5", "rxtx6", + "rxtx7", "spba"; + status = "disabled"; + }; + ecspi1: spi@2008000 { #address-cells = <1>; #size-cells = <0>;
The i.MX6UL has a SPDIF located at start address 0x02004000 in the AIPS-1 memory region [1]. SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine. [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2, 03/2017, Table-2-2 AIPS-1 memory map, p. 158 [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1, 11/2017, Table-2-2 AIPS-1 memory map, p. 178 Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- arch/arm/boot/dts/imx6ul.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)