From patchwork Mon Jun 7 21:33:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 12304753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508CCC47082 for ; Mon, 7 Jun 2021 21:35:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11F166120F for ; Mon, 7 Jun 2021 21:35:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11F166120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vAxlJDm4h0JZsIi7WU+fTks4W9Q91SvwY1HlcjjZqO8=; b=tqATJDOrZFz9CU swNs02mtBJXYnwpZdUlZaChFjEDoJ1tU15kw80UmpNoHepCD+uSsiGb+6lD0+35JGQmSZwcHa5ooA wIXAms48PgB5Y/1eG3Y2mFWx+Pj+sd1SxSr4in4SrGmq4B/v5zW2lH+zOesYS2K3Wn6ZFgXc3xFaD jZa2l0CC0TjrcVwcs7ZUoV87thkGyknOUWVcXBBymnJEy800d44NSxj0MHck1TdtmzU6DYBC5btjO o9BqgLanAwN9oAtN1cs59Fdey1Us/5kGEbUoRQTW5ysZyNPqKtLnAg8NwDmngeRgVuReg0xQ7YPrr R/rCKed5hrYMIBDv+7DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqMsg-005UM5-13; Mon, 07 Jun 2021 21:33:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqMsb-005ULJ-KG for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 21:33:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623101629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ne0sdd3NZl98G4gVbRdymPLZj6j1uGmDFhwuH8srjsM=; b=XeFnR7kRBaRpYOWTQcwcjb6vx4scgegOky//ub0aZrxG4ahEQDAi/Tx2H3SeyLFvzbOPiY A4Uv5VXiCKcKqWOaZHs0tScXeoGA5wgSc/m3AEFcf1CEuRUwGTsFoNvfBoeZUjTNtN087P tdmCs0sS4sw6rpA+fBHQOoLufXXS9k0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-j2xoIT9gOF6of1-m9RxyXg-1; Mon, 07 Jun 2021 17:33:48 -0400 X-MC-Unique: j2xoIT9gOF6of1-m9RxyXg-1 Received: by mail-wm1-f71.google.com with SMTP id 18-20020a05600c0252b029019a0ce35d36so378930wmj.4 for ; Mon, 07 Jun 2021 14:33:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ne0sdd3NZl98G4gVbRdymPLZj6j1uGmDFhwuH8srjsM=; b=k3d+ThrpbIKhHOey0tc0BGOukGZE0va85CpOoneNDDQpRpEX0w5oFwUiePU/ypelPZ fNDSIklQQXaqkDb5zk3+KF2MGuIKKJW14BiVRGO18k6fnApgZTu5ZWrJKll3ZYRqdnre t0oAba+EGBRQKLsq8gCKcbZuV3apOnb09tK7chM9PsXoyUxzFdV1uaY/nRbzJgcnO1EY PsJcR0aMVUodjSAz98S6Vo8Z9jGyw7VvNvxA0QoY4HnLONyVEZcjzmtsb/QyTyOBXd8D 0btve520U7GqTFCeFRmqnLhImDnM4WbaknGpqCrZLGTU1F+dRm+SJaYbe64HeuVxIatp 7SYA== X-Gm-Message-State: AOAM532ZBCg8HB8TNw/OGBR8s6FVzaQ10gwH0pL+v+m5ePM5CHamrwdc pOCxXRf007gUONt1Mg4QA7+ElarHqWevfhqcf5cb6R9uHTMMErCABvubFMLo/fAD71QUZBhTdCl seIdPw9AtiQSneo568kAsV4Bcj93J853P3Wo= X-Received: by 2002:a7b:c24e:: with SMTP id b14mr19012442wmj.6.1623101627126; Mon, 07 Jun 2021 14:33:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4ll9t3EwcCKy3igwdQwoTdXU//20aYaO8amkuTKLrzZN/i3Xio/esdoJJJge80qbLcxBnjQ== X-Received: by 2002:a7b:c24e:: with SMTP id b14mr19012434wmj.6.1623101626926; Mon, 07 Jun 2021 14:33:46 -0700 (PDT) Received: from minerva.home ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id q5sm17659319wrm.15.2021.06.07.14.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 14:33:46 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Peter Robinson , Bjorn Helgaas , Heiko Stuebner , Lorenzo Pieralisi , Rob Herring , Shawn Lin , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH] PCI: rockchip: Avoid accessing PCIe registers with clocks gated Date: Mon, 7 Jun 2021 23:33:28 +0200 Message-Id: <20210607213328.1711570-1-javierm@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_143353_751578_B77C255D X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org IRQ handlers that are registered for shared interrupts can be called at any time after have been registered using the request_irq() function. It's up to drivers to ensure that's always safe for these to be called. Both the "pcie-sys" and "pcie-client" interrupts are shared, but since their handlers are registered very early in the probe function, an error later can lead to these handlers being executed before all the required have been properly setup. For example, the rockchip_pcie_read() function used by these IRQ handlers expects that some PCIe clocks will already be enabled, otherwise trying to access the PCIe registers causes the read to hang and never return. The CONFIG_DEBUG_SHIRQ option tests if drivers are able to cope with their shared interrupt handlers being called, by generating a spurious interrupt just before a shared interrupt handler is unregistered. But this means that if the option is enabled, any error in the probe path of this driver could lead to one of the IRQ handlers to be executed. In a rockpro64 board, the following sequence of events happens: 1) "pcie-sys" IRQ is requested and its handler registered. 2) "pcie-client" IRQ is requested and its handler registered. 3) probe later fails due readl_poll_timeout() returning a timeout. 4) the "pcie-sys" IRQ is unregistered. 5) CONFIG_DEBUG_SHIRQ triggers a spurious interrupt. 6) "pcie-client" IRQ handler is called for this spurious interrupt. 7) IRQ handler tries to read PCIE_CLIENT_INT_STATUS with clocks gated. 8) the machine hangs because rockchip_pcie_read() call never returns. To avoid cases like this, the handlers don't have to be registered until very late in the probe function, once all the resources have been setup. So let's just move all the IRQ init before the pci_host_probe() call, that will prevent issues like this and seems to be the correct thing to do too. Reported-by: Peter Robinson Signed-off-by: Javier Martinez Canillas Acked-by: Shawn Lin --- drivers/pci/controller/pcie-rockchip-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c index f1d08a1b159..78d04ac29cd 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -592,10 +592,6 @@ static int rockchip_pcie_parse_host_dt(struct rockchip_pcie *rockchip) if (err) return err; - err = rockchip_pcie_setup_irq(rockchip); - if (err) - return err; - rockchip->vpcie12v = devm_regulator_get_optional(dev, "vpcie12v"); if (IS_ERR(rockchip->vpcie12v)) { if (PTR_ERR(rockchip->vpcie12v) != -ENODEV) @@ -973,8 +969,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev) if (err) goto err_vpcie; - rockchip_pcie_enable_interrupts(rockchip); - err = rockchip_pcie_init_irq_domain(rockchip); if (err < 0) goto err_deinit_port; @@ -992,6 +986,12 @@ static int rockchip_pcie_probe(struct platform_device *pdev) bridge->sysdata = rockchip; bridge->ops = &rockchip_pcie_ops; + err = rockchip_pcie_setup_irq(rockchip); + if (err) + goto err_remove_irq_domain; + + rockchip_pcie_enable_interrupts(rockchip); + err = pci_host_probe(bridge); if (err < 0) goto err_remove_irq_domain;