| Message ID | 20210609083843.463750-1-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID | expand |
On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote: > Although the schematics of Pine A64-LTS and SoPine Baseboard shows both > the RX and TX internal delay are enabled, they're using the same broken > RTL8211E chip batch with Pine A64+, so they should use TXID instead, not > ID. > > In addition, by checking the real components soldered on both a SoPine > Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and > GR70 NC) despite the schematics says it's enabled. It's a common > situation for Pine64 boards that the NC information on schematics is not > the same with the board. > > So the RGMII delay mode should be TXID on these boards. > > Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id") > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Applied, thanks Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts index e22b94c83647..5e66ce1a334f 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts @@ -79,7 +79,7 @@ &ehci1 { &emac { pinctrl-names = "default"; pinctrl-0 = <&rgmii_pins>; - phy-mode = "rgmii-id"; + phy-mode = "rgmii-txid"; phy-handle = <&ext_rgmii_phy>; phy-supply = <®_dc1sw>; status = "okay";
Although the schematics of Pine A64-LTS and SoPine Baseboard shows both the RX and TX internal delay are enabled, they're using the same broken RTL8211E chip batch with Pine A64+, so they should use TXID instead, not ID. In addition, by checking the real components soldered on both a SoPine Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and GR70 NC) despite the schematics says it's enabled. It's a common situation for Pine64 boards that the NC information on schematics is not the same with the board. So the RGMII delay mode should be TXID on these boards. Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id") Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)