diff mbox series

remoteproc: imx-rproc: Fix IMX_REMOTEPROC configuration

Message ID 20210610031530.26326-1-peng.fan@oss.nxp.com (mailing list archive)
State New, archived
Headers show
Series remoteproc: imx-rproc: Fix IMX_REMOTEPROC configuration | expand

Commit Message

Peng Fan (OSS) June 10, 2021, 3:15 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

When CONFIG_IMX_REMOTEPROC is y and CONFIG_HAVE_ARM_SMCCC
is not set, compiling errors are encountered as follows:

drivers/remoteproc/imx_rproc.o: in function `imx_rproc_stop':
imx_rproc.c:(.text+0x140): undefined reference to `__arm_smccc_smc'
drivers/remoteproc/imx_rproc.o: in function `imx_rproc_detect_mode':
imx_rproc.c:(.text+0x272): undefined reference to `__arm_smccc_smc'
drivers/remoteproc/imx_rproc.o: in function `imx_rproc_start':
imx_rproc.c:(.text+0x5e0): undefined reference to `__arm_smccc_smc'

__arm_smccc_smc is defined when HAVE_ARM_SMCCC is y, so
add dependency on HAVE_ARM_SMCCC in IMX_REMOTEPROC configuration.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/remoteproc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Mathieu Poirier June 10, 2021, 4:09 p.m. UTC | #1
On Thu, Jun 10, 2021 at 11:15:30AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> When CONFIG_IMX_REMOTEPROC is y and CONFIG_HAVE_ARM_SMCCC
> is not set, compiling errors are encountered as follows:
> 
> drivers/remoteproc/imx_rproc.o: in function `imx_rproc_stop':
> imx_rproc.c:(.text+0x140): undefined reference to `__arm_smccc_smc'
> drivers/remoteproc/imx_rproc.o: in function `imx_rproc_detect_mode':
> imx_rproc.c:(.text+0x272): undefined reference to `__arm_smccc_smc'
> drivers/remoteproc/imx_rproc.o: in function `imx_rproc_start':
> imx_rproc.c:(.text+0x5e0): undefined reference to `__arm_smccc_smc'
> 
> __arm_smccc_smc is defined when HAVE_ARM_SMCCC is y, so
> add dependency on HAVE_ARM_SMCCC in IMX_REMOTEPROC configuration.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/remoteproc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Next time please add:

Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P")

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index e68fcedc999c..9a6eedc3994a 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -26,6 +26,7 @@ config REMOTEPROC_CDEV
>  config IMX_REMOTEPROC
>  	tristate "i.MX remoteproc support"
>  	depends on ARCH_MXC
> +	depends on HAVE_ARM_SMCCC
>  	select MAILBOX
>  	help
>  	  Say y here to support iMX's remote processors via the remote
> -- 
> 2.30.0
>
diff mbox series

Patch

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index e68fcedc999c..9a6eedc3994a 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -26,6 +26,7 @@  config REMOTEPROC_CDEV
 config IMX_REMOTEPROC
 	tristate "i.MX remoteproc support"
 	depends on ARCH_MXC
+	depends on HAVE_ARM_SMCCC
 	select MAILBOX
 	help
 	  Say y here to support iMX's remote processors via the remote