diff mbox series

[net-next,v9,04/15] of: mdio: Refactor of_phy_find_device()

Message ID 20210611105401.270673-5-ciorneiioana@gmail.com (mailing list archive)
State New, archived
Headers show
Series ACPI support for dpaa2 driver | expand

Commit Message

Ioana Ciornei June 11, 2021, 10:53 a.m. UTC 
From: Calvin Johnson <calvin.johnson@oss.nxp.com>

Refactor of_phy_find_device() to use fwnode_phy_find_device().

Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Acked-by: Grant Likely <grant.likely@arm.com>
---

Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/net/mdio/of_mdio.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

Comments

Andy Shevchenko June 11, 2021, 11:28 a.m. UTC | #1 
On Fri, Jun 11, 2021 at 1:54 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote:
>
> From: Calvin Johnson <calvin.johnson@oss.nxp.com>
>
> Refactor of_phy_find_device() to use fwnode_phy_find_device().

I see that there are many users of this, but I think eventually we
should kill of_phy_find_device() completely.
Andy Shevchenko June 11, 2021, 11:30 a.m. UTC | #2 
On Fri, Jun 11, 2021 at 2:28 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Jun 11, 2021 at 1:54 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote:
> >
> > From: Calvin Johnson <calvin.johnson@oss.nxp.com>
> >
> > Refactor of_phy_find_device() to use fwnode_phy_find_device().
>
> I see that there are many users of this, but I think eventually we
> should kill of_phy_find_device() completely.

Looking into other examples of such I think this series may not touch
them right now, but clearly state that it's the plan in the future to
kill this kind of OF APIs that call fwnode underneath.
Russell King (Oracle) June 11, 2021, 11:35 a.m. UTC | #3 
On Fri, Jun 11, 2021 at 02:30:19PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 11, 2021 at 2:28 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jun 11, 2021 at 1:54 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote:
> > >
> > > From: Calvin Johnson <calvin.johnson@oss.nxp.com>
> > >
> > > Refactor of_phy_find_device() to use fwnode_phy_find_device().
> >
> > I see that there are many users of this, but I think eventually we
> > should kill of_phy_find_device() completely.
> 
> Looking into other examples of such I think this series may not touch
> them right now, but clearly state that it's the plan in the future to
> kill this kind of OF APIs that call fwnode underneath.

That's something I most definitely support - once we have the fwnode
APIs in place, the OF specific APIs become an additional maintenance
burden that we don't need. So, I would also like to see the old APIs
killed.
diff mbox series

Patch

diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index 6ef8b6e40189..0ba1158796d9 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -360,18 +360,7 @@  EXPORT_SYMBOL(of_mdio_find_device);
  */
 struct phy_device *of_phy_find_device(struct device_node *phy_np)
 {
-	struct mdio_device *mdiodev;
-
-	mdiodev = of_mdio_find_device(phy_np);
-	if (!mdiodev)
-		return NULL;
-
-	if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY)
-		return to_phy_device(&mdiodev->dev);
-
-	put_device(&mdiodev->dev);
-
-	return NULL;
+	return fwnode_phy_find_device(of_fwnode_handle(phy_np));
 }
 EXPORT_SYMBOL(of_phy_find_device);