From patchwork Fri Jun 11 11:13:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Brugger X-Patchwork-Id: 12315443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29651C48BD1 for ; Fri, 11 Jun 2021 11:15:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E51AA608FE for ; Fri, 11 Jun 2021 11:15:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E51AA608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=q12dUT080KpiIedxB5Z4bXYrUOTyqvMHDpJQQNMsP6c=; b=CJrLIky9OxDemP jW0UaRL4rfIjINx0EBWiFVFqFXVMcakeGZ2uJEgQuMxYFXeiDlYa2weDMa5/Q98wdbrsCgWs9T0b+ 34+IHYk/Q2J+TUhIEAtJqPdrJTpHi07UceaUyQJl92h+CbuAnoBHU6Q6ykHNc6C83k/NgaJEuksJI 1yoFmu2BjX3oNIwXx5EK3Pi/rVmhDbonwbpoHdXrB5sGwqLphApNDxuOjM1hrYYiRW1CgSY4CIlks Et0AcNmqb06F8oOub1LRneDvLW17rmlLnyRGtZkIzRIZtd7fHCzRoBs3WpgR0pQGcgXPi2cIFUlHN RlMJsJDBj6OnNmJ3ZKPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrf70-004xBG-Gs; Fri, 11 Jun 2021 11:14:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrf6B-004wlN-8p; Fri, 11 Jun 2021 11:13:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 193696109E; Fri, 11 Jun 2021 11:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623409994; bh=/k+3lM8FCcwSaHqv2P5+2MbpRxWaZc7shGXGvJaDrsA=; h=From:To:Cc:Subject:Date:From; b=HFhsn+A7kFQbIfcP3v6qfhd3ZDPQnEi7Fazrn4TL9YmzmvSxpt9e3PumbXrCumIQG QtAFfkxG7OScdQjUYrrrFH7GeYANTcPv16FKeK0DjCvF2nHEC36xWZnTuYitiuloH1 8P523IVy2oPas+6E7PlrYvVbC49YWvMdCGvnRpNBzd1LBeRcjMkoJ1dQWhkCp1pMdX Vmindf69LDAFEMllkklpaB4dptWCq+Gs0M5l/295UGCCdBSJGyReGbiqKBYvw/SB/+ DcQBdZPEfwapuxw/APCBNaapadjVEO2Cf8hSYb/UoLWnngecztBQL0xn0GLEhD6n3A MhM720W7m3q9Q== From: matthias.bgg@kernel.org To: james.lo@mediatek.com Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger Subject: [PATCH] soc: mediatek: pwarp: delete confusing comments Date: Fri, 11 Jun 2021 13:13:07 +0200 Message-Id: <20210611111307.29038-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_041315_380083_4C734303 X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Matthias Brugger Comments sugguest that MT8195 arb_en_all and int_en_all values need to be confirmed. But actually these values are correct. Suggested-by: James Lo Signed-off-by: Matthias Brugger --- drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 952bc554f443..118eb4acdeb6 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { static struct pmic_wrapper_type pwrap_mt8195 = { .regs = mt8195_regs, .type = PWRAP_MT8195, - .arb_en_all = 0x777f, /* NEED CONFIRM */ - .int_en_all = 0x180000, /* NEED CONFIRM */ + .arb_en_all = 0x777f, + .int_en_all = 0x180000, .int1_en_all = 0, .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_ALL,