| Message ID | 20210614154359.805555-2-benjamin.gaignard@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add USB2 support for rk3568 | expand |
On Mon, 14 Jun 2021 17:43:56 +0200, Benjamin Gaignard wrote: > '#phy-cells' property is needed in host-port and otg-port nodes but > not in parent nodes. Remove it from the JSON schema. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 2 -- > 1 file changed, 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.example.dt.yaml: usb2-phy@e450: '#phy-cells' is a required property From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/phy/phy-provider.yaml \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1491757 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Jun 14, 2021 at 05:43:56PM +0200, Benjamin Gaignard wrote: > '#phy-cells' property is needed in host-port and otg-port nodes but > not in parent nodes. Remove it from the JSON schema. Pretty sure there's already a fix for this. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index fb29ad807b68f..b14387a48f6a3 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -119,7 +119,6 @@ required: > - reg > - clock-output-names > - "#clock-cells" > - - "#phy-cells" > - host-port > - otg-port > > @@ -137,7 +136,6 @@ examples: > clock-names = "phyclk"; > clock-output-names = "clk_usbphy0_480m"; > #clock-cells = <0>; > - #phy-cells = <0>; > > u2phy0_host: host-port { > #phy-cells = <0>; > -- > 2.25.1
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml index fb29ad807b68f..b14387a48f6a3 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml @@ -119,7 +119,6 @@ required: - reg - clock-output-names - "#clock-cells" - - "#phy-cells" - host-port - otg-port @@ -137,7 +136,6 @@ examples: clock-names = "phyclk"; clock-output-names = "clk_usbphy0_480m"; #clock-cells = <0>; - #phy-cells = <0>; u2phy0_host: host-port { #phy-cells = <0>;
'#phy-cells' property is needed in host-port and otg-port nodes but not in parent nodes. Remove it from the JSON schema. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 2 -- 1 file changed, 2 deletions(-)