From patchwork Wed Jun 16 13:46:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 12325265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFE6C48BE5 for ; Wed, 16 Jun 2021 13:53:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D163611EE for ; Wed, 16 Jun 2021 13:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D163611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AbYWSDxApsh0C5lNCclBvCcSIndCEcR7LVyP+sx+D9E=; b=pFKrxSllSkp8zG QaVvP3e/DjgADA8zIbAW4UCc/Efd7PP0EwWBfniydp3f9B4cQwZLHveoah1MD2/zHn2olRbVA5xQR b60Ii2KwH1O5YSt6IYsoOZuLpNYZzAlshBb8ifKWTBEWgCrnjOeCUfTmV8exSpu4+z6671lEztUf6 A4Y4E9lahQj4GzGiUvoV86pEAww7kcTX2OqxfjsA7LKVY+rDmO1sfWql1znhzMZZTN6zXDOJ3PFfn JBZVAbsChOwxVKjGPy/SpktLJgMFRl1Yknwzx+6iMzJRMk2kn1srV5ILQe2eIM2KoxrVC1YWAb4d7 o7RHK5oWTTemdcxPRtFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltVxl-006YNs-D8; Wed, 16 Jun 2021 13:52:13 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltVtJ-006WUS-UA for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Jun 2021 13:47:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=hz+UUrM8ElLAj/iJo+DmppsdBvwZ+F/R3vYoPMFC1v0=; b=HIXR7KJRvzBTx1oAaTOhFmEuQe 7CrxkQC18XDjnkjby7ybaNzflCoG6u6dQhmFAZo0KG7x2b39Uuv+A32AODZB2lArcUjcu+qbWHefe n81gkVEX4j8vD6cP+WCo3Y76nSvHTwJlVPORP90hsMlal4lckKPFG1aJpU5uw1LKUWLsEEaKymzxW 5SF3TSiQnWUILvnEhwlbu7/aKNZ7ukSi+paqcn2zBgJ03rW+AbDWf+Y09zkefOPw9sIP5kIlJycer GeLGcS0yRcv5hzlgsxqhLHTk4eroIDW0ZMQneIeIyZF5e3pNUT20Cy+7/oP+m/xsKs2KR3goQdRow br23u7wQ==; Received: from [2001:4bb8:19b:fdce:84d:447:81f0:ca60] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltVt4-0085ue-Gh; Wed, 16 Jun 2021 13:47:26 +0000 From: Christoph Hellwig To: "David S. Miller" , Jens Axboe , Geert Uytterhoeven Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Michael Ellerman , Linus Torvalds , linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org Subject: [PATCH 1/6] pata_cypress: add a module option to disable BM-DMA Date: Wed, 16 Jun 2021 15:46:53 +0200 Message-Id: <20210616134658.1471835-2-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210616134658.1471835-1-hch@lst.de> References: <20210616134658.1471835-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Multiple users report that they need to disable DMA on this driver, so provide an option to do so without affecting all of libata. Signed-off-by: Christoph Hellwig Reviewed-by: Russell King (Oracle) --- drivers/ata/pata_cypress.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_cypress.c b/drivers/ata/pata_cypress.c index e1486fe298ae..5b3a7a8ebef6 100644 --- a/drivers/ata/pata_cypress.c +++ b/drivers/ata/pata_cypress.c @@ -41,6 +41,10 @@ enum { CY82_INDEX_TIMEOUT = 0x32 }; +static bool enable_dma = true; +module_param(enable_dma, bool, 0); +MODULE_PARM_DESC(enable_dma, "Enable bus master DMA operations"); + /** * cy82c693_set_piomode - set initial PIO mode data * @ap: ATA interface @@ -124,14 +128,16 @@ static struct ata_port_operations cy82c693_port_ops = { static int cy82c693_init_one(struct pci_dev *pdev, const struct pci_device_id *id) { - static const struct ata_port_info info = { + static struct ata_port_info info = { .flags = ATA_FLAG_SLAVE_POSS, .pio_mask = ATA_PIO4, - .mwdma_mask = ATA_MWDMA2, .port_ops = &cy82c693_port_ops }; const struct ata_port_info *ppi[] = { &info, &ata_dummy_port_info }; + if (enable_dma) + info.mwdma_mask = ATA_MWDMA2; + /* Devfn 1 is the ATA primary. The secondary is magic and on devfn2. For the moment we don't handle the secondary. FIXME */