| Message ID | 20210623024429.1346349-2-art@khadas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | watchdog: meson_gxbb_wdt: improve | expand |
On 6/22/21 7:44 PM, Artem Lapkin wrote: > Remove watchdog_stop_on_reboot (still can be activated by > watchdog.stop_on_reboot=1) i think this driver configuration more useful > becouse we can get reboot waranty for abnormal situations on shutdown stage > This is personal opinion. Driver authors would have to agree. Guenter > Signed-off-by: Artem Lapkin <art@khadas.com> > --- > drivers/watchdog/meson_gxbb_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 5a9ca10fbcfa..3f86530c33b0 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -186,7 +186,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > > - watchdog_stop_on_reboot(&data->wdt_dev); > return devm_watchdog_register_device(dev, &data->wdt_dev); > } > >
diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 5a9ca10fbcfa..3f86530c33b0 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -186,7 +186,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); - watchdog_stop_on_reboot(&data->wdt_dev); return devm_watchdog_register_device(dev, &data->wdt_dev); }
Remove watchdog_stop_on_reboot (still can be activated by watchdog.stop_on_reboot=1) i think this driver configuration more useful becouse we can get reboot waranty for abnormal situations on shutdown stage Signed-off-by: Artem Lapkin <art@khadas.com> --- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)