diff mbox series

ARM: pxa: ssp: remove unnecessary print function dev_err()

Message ID 20210624024139.23879-1-13145886936@163.com (mailing list archive)
State New, archived
Headers show
Series ARM: pxa: ssp: remove unnecessary print function dev_err() | expand

Commit Message

gushengxian June 24, 2021, 2:41 a.m. UTC 
From: gushengxian <gushengxian@yulong.com>

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: gushengxian <gushengxian@yulong.com>
---
 arch/arm/plat-pxa/ssp.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Russell King (Oracle) June 24, 2021, 9:24 a.m. UTC | #1 
On Wed, Jun 23, 2021 at 07:41:39PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
> 
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
> 
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
>  arch/arm/plat-pxa/ssp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 563440315acd..96b8765e4f57 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
>  
>  	ssp->irq = platform_get_irq(pdev, 0);
>  	if (ssp->irq < 0) {
> -		dev_err(dev, "no IRQ resource defined\n");
>  		return -ENODEV;
>  	}

Please also remove the now unnecessary braces around the return block.
Thanks.
diff mbox series

Patch

diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..96b8765e4f57 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -147,7 +147,6 @@  static int pxa_ssp_probe(struct platform_device *pdev)
 
 	ssp->irq = platform_get_irq(pdev, 0);
 	if (ssp->irq < 0) {
-		dev_err(dev, "no IRQ resource defined\n");
 		return -ENODEV;
 	}