| Message ID | 20210624235122.24772-1-wangborong@cdjrlc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] pinctrl: bcm2835: Replace BUG with WARN_ON | expand |
On 6/24/2021 4:51 PM, Jason Wang wrote: > The if condition followed by BUG can be replaced to WARN_ON which is > more compact and formal in linux source. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Hi, Am 25.06.21 um 01:51 schrieb Jason Wang: > The if condition followed by BUG can be replaced to WARN_ON which is > more compact and formal in linux source. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > > Changes in v2: > Accept Florian's advice to replace the BUG_ON() with a WARN_ON(). > > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 2c87af1180c4..8440c722f6f8 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -416,8 +416,7 @@ static void bcm2835_gpio_irq_handler(struct irq_desc *desc) > } > } > /* This should not happen, every IRQ has a bank */ > - if (i == BCM2835_NUM_IRQS) > - BUG(); > + WARN_ON(i == BCM2835_NUM_IRQS); whenever this should happen, the source of this interrupt cannot be determined and acked. So it's very likely that we end up in some kind of interrupt storm. So i suggest to use at least WARN_ON_ONCE(). Even worse the value of variable "group" is uninitialized in this case, so maybe we better return immediately after that. Regards > > chained_irq_enter(host_chip, desc); >
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 2c87af1180c4..8440c722f6f8 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -416,8 +416,7 @@ static void bcm2835_gpio_irq_handler(struct irq_desc *desc) } } /* This should not happen, every IRQ has a bank */ - if (i == BCM2835_NUM_IRQS) - BUG(); + WARN_ON(i == BCM2835_NUM_IRQS); chained_irq_enter(host_chip, desc);
The if condition followed by BUG can be replaced to WARN_ON which is more compact and formal in linux source. Signed-off-by: Jason Wang <wangborong@cdjrlc.com> --- Changes in v2: Accept Florian's advice to replace the BUG_ON() with a WARN_ON(). drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)