diff mbox series

power: supply: cw2015: use dev_err_probe to allow deferred probe

Message ID 20210701220516.2738398-1-pbrobinson@gmail.com (mailing list archive)
State New, archived
Headers show
Series power: supply: cw2015: use dev_err_probe to allow deferred probe | expand

Commit Message

Peter Robinson July 1, 2021, 10:05 p.m. UTC
Deal with deferred probe using dev_err_probe so the error is handled
and avoid logging lots probe defer information like the following:

[    9.125121] cw2015 4-0062: Failed to register power supply
[    9.211131] cw2015 4-0062: Failed to register power supply

Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/power/supply/cw2015_battery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Javier Martinez Canillas July 1, 2021, 10:14 p.m. UTC | #1
On Fri, Jul 2, 2021 at 12:07 AM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Deal with deferred probe using dev_err_probe so the error is handled
> and avoid logging lots probe defer information like the following:
>
> [    9.125121] cw2015 4-0062: Failed to register power supply
> [    9.211131] cw2015 4-0062: Failed to register power supply
>
> Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---

Right, I also found this error message annoying and agree that's too noisy.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
Javier
Sebastian Reichel July 16, 2021, 2:01 p.m. UTC | #2
Hi,

On Fri, Jul 02, 2021 at 12:14:40AM +0200, Javier Martinez Canillas wrote:
> On Fri, Jul 2, 2021 at 12:07 AM Peter Robinson <pbrobinson@gmail.com> wrote:
> >
> > Deal with deferred probe using dev_err_probe so the error is handled
> > and avoid logging lots probe defer information like the following:
> >
> > [    9.125121] cw2015 4-0062: Failed to register power supply
> > [    9.211131] cw2015 4-0062: Failed to register power supply
> >
> > Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> 
> Right, I also found this error message annoying and agree that's too noisy.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks, queued (but would have been nicer to just return
dev_err_probe() instead of doing another round of PTR_ERR
conversion).

-- Sebastian
diff mbox series

Patch

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index d110597746b0..091868e9e9e8 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -679,7 +679,9 @@  static int cw_bat_probe(struct i2c_client *client)
 						    &cw2015_bat_desc,
 						    &psy_cfg);
 	if (IS_ERR(cw_bat->rk_bat)) {
-		dev_err(cw_bat->dev, "Failed to register power supply\n");
+		/* try again if this happens */
+		dev_err_probe(&client->dev, PTR_ERR(cw_bat->rk_bat),
+			"Failed to register power supply\n");
 		return PTR_ERR(cw_bat->rk_bat);
 	}