diff mbox series

arm64: dts: ls1028: sl28: fix networking for variant 2

Message ID 20210702194914.10921-1-michael@walle.cc (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ls1028: sl28: fix networking for variant 2 | expand

Commit Message

Michael Walle July 2, 2021, 7:49 p.m. UTC
The PHY configuration for the variant 2 is still missing the flag for
in-band signalling between PHY and MAC. Both sides - MAC and PHY - have
to match the setting. For now, Linux only supports setting the MAC side
and thus it has to match the setting the bootloader is configuring.
Enable in-band signalling to make ethernet work.

Fixes: ab43f0307449 ("arm64: dts: ls1028a: sl28: add support for variant 2")
Signed-off-by: Michael Walle <michael@walle.cc>
---
What make things worse and why this might slipped through is that the
setting in the PHY is persistent even after a soft reset of the PHY.

 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shawn Guo July 23, 2021, 2:40 a.m. UTC | #1
On Fri, Jul 02, 2021 at 09:49:14PM +0200, Michael Walle wrote:
> The PHY configuration for the variant 2 is still missing the flag for
> in-band signalling between PHY and MAC. Both sides - MAC and PHY - have
> to match the setting. For now, Linux only supports setting the MAC side
> and thus it has to match the setting the bootloader is configuring.
> Enable in-band signalling to make ethernet work.
> 
> Fixes: ab43f0307449 ("arm64: dts: ls1028a: sl28: add support for variant 2")
> Signed-off-by: Michael Walle <michael@walle.cc>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
index dd764b720fb0..f6a79c8080d1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
@@ -54,6 +54,7 @@ 
 
 &mscc_felix_port0 {
 	label = "swp0";
+	managed = "in-band-status";
 	phy-handle = <&phy0>;
 	phy-mode = "sgmii";
 	status = "okay";
@@ -61,6 +62,7 @@ 
 
 &mscc_felix_port1 {
 	label = "swp1";
+	managed = "in-band-status";
 	phy-handle = <&phy1>;
 	phy-mode = "sgmii";
 	status = "okay";