From patchwork Tue Jul 13 02:38:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salah Triki X-Patchwork-Id: 12372723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AB4C07E9A for ; Tue, 13 Jul 2021 02:40:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E898361152 for ; Tue, 13 Jul 2021 02:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E898361152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VdA5ptA41pIvo5lU/t64I1LtrBgER8DnUERGNmZ5Pio=; b=ke5pjSjkk7R4YC bDZvXKJbAW+kOYJRm1jR1SAxcsryurIbIcwjsAtqJFZZDrOEn09D3opq/DMw3Qa/0stCEWFGJfxrX bXeObnsFk2mVEoooM02e8gStPcYBvRmzoUOEkz5n3vYgtEEFzuIGZwINorPptfhPiwkrf/NVm/0SO lhT4CH2YhcL0bTb+FU2DcxpUJqm1ascsiNPSDSbfMY+37MazGrR8a/7nMKUjKBe2FUWobQF/8O6gA zp52vESc2RRa4LcOWVZyYHzTEx412NfwZu8rWofky/dRbImaUqOnM/OoVQwP6IkY8sMPGT+zVyrrs d9p0QzFtdQXOyitmt7VQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m38Ji-008yGx-8i; Tue, 13 Jul 2021 02:38:38 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m38Je-008yGY-Od for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 02:38:36 +0000 Received: by mail-ed1-x532.google.com with SMTP id w14so19287286edc.8 for ; Mon, 12 Jul 2021 19:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=BM24k6H9LcY/dUUeA4LE+RhfS6GQmXK+4XERxfAvlv0=; b=oR2mglMxlqz8UVA4bDS/Vy20tMYeUdc0P45H4Di/KhCpwZEd0TIR4lhe1TtNTEnHYr Tm0C56cv0awj95FPRIVu7se2mMU/rSAEHmqocxvlyh5syHrXTEfLeWjeZgkb81XTlM85 f9rK5ozXdDb/YJ6gh6HfN7xzzeAA+YYi6unlpvTknjVk034tFMpmtX4ZWbpLf8QcoJw3 pt8YKgfC9IKMqQ3P545piuKy4BMbP3JrBaUmx1Ux4xkhqoDm9A6LnhKRNXyAMhfti6Wd 2krhkIlXRR7oF9S6NvNlWrnxLRDJ/ncZLkLv+te0RSFmKSjEa4iwTLGdi/FAIKaayeRb 9HHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=BM24k6H9LcY/dUUeA4LE+RhfS6GQmXK+4XERxfAvlv0=; b=ObXnr6HIMo0BxB6D4ZvjkuyooVl/qBDvVTSLdJnksRIjP8c193K974HrGg+IktUgTP 2KEsrosbI79zEqLa7B19MQZao7f98c9IC59NFtf3nF/6kVXYwaoJQUqVHGnn4jeyI3Yl MJ2SQBSOfV5CbThalZS8s8K9Dr0YxKNXDjXJDiS1Fxdcjki2cTttwN0+lde1kvMGl9Nw rybfuHgiC6xuw5wp7uLmxsGfzfACWTgJ4OH6K4WGUP7eQM7SPTVJ3z+YpzjOc8Him7pX 2j4XGuD/BtFzZN905ODpkVSWDF7vvZ+zHYh8l8V1knTwMhuVrMktBMpEdDlld8XUECH+ dViQ== X-Gm-Message-State: AOAM531e03Bcm6D7eONPyC8o3xTk102rfFbaD2Y8XxWr5oGYVgL3+8dw 8eZSDXKhTp7DnHUpFjd9Qag= X-Google-Smtp-Source: ABdhPJyCdykS1tWU3nj+DHJ5VwHSHwsHr4XmdUj4TDsu6OHxOsPDqU8UBeD7gj48Jq6TkH36zDLUzw== X-Received: by 2002:a05:6402:90a:: with SMTP id g10mr2427996edz.365.1626143913168; Mon, 12 Jul 2021 19:38:33 -0700 (PDT) Received: from pc ([196.235.212.194]) by smtp.gmail.com with ESMTPSA id n13sm7300744ejk.97.2021.07.12.19.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 19:38:32 -0700 (PDT) Date: Tue, 13 Jul 2021 03:38:28 +0100 From: Salah Triki To: herbert@gondor.apana.org.au, davem@davemloft.net, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] use swap() Message-ID: <20210713023828.GA1841817@pc> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_193834_847386_25D729A2 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use swap() instead of implementing it in order to make code more clean. Signed-off-by: Salah Triki --- drivers/crypto/atmel-aes.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index b1d286004295..60041022c4f5 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) * the order of the ciphered tweak bytes need to be reversed before * writing them into the ODATARx registers. */ - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; - - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; - tweak_bytes[i] = tmp; - } + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); /* Process the data. */ atmel_aes_write_ctrl(dd, use_dma, NULL);