From patchwork Sat Jul 17 04:56:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Palmer X-Patchwork-Id: 12383171 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4D2C636CA for ; Sat, 17 Jul 2021 04:59:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B839A613D9 for ; Sat, 17 Jul 2021 04:59:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B839A613D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TQrM3SoVpz58GjfHWo/JH6d6Z1s1rF3MCbSPddAOVTI=; b=JzQ1g05u3bHNcE IByj5Btddy/Q5kYNl/lgeCWmVL+LPDlW5UVbCn7QYI5Ua4762ef3UFYSKy2F1Ynm0XQBFZx8Wwmfx DxvLDOI2zQSayPk8kXuPazlSmI+hJvy8eAKBo6grns5tqkeYXKuuxpNvC8zu7koF0HBFl4eus1M9z 2caA+KjTRHsyWz537VAEYUuaX5phNsm1nl/CVs2GCmE9rU0Pv99LM3tYKpFDCr7yIoWM8K4hrvXs+ q/cY/CM+dt84MwEuMjsRbE2kw569mf3R3j5TR4fkxlQ95nJH1+qHN2R42J/vD7tPduyjrllmFYGkl H2FnLOt13PdvDLh3XHrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4cO7-005wWF-Uo; Sat, 17 Jul 2021 04:57:20 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4cNd-005wQU-Ma for linux-arm-kernel@lists.infradead.org; Sat, 17 Jul 2021 04:56:50 +0000 Received: by mail-pj1-x1029.google.com with SMTP id g24so7582508pji.4 for ; Fri, 16 Jul 2021 21:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fLDUaTCh3VK5lI9Kvmqz2LtxGRfdlTFuw6ZvgFybPpU=; b=qXnMdlmNRiHXn4gEatb5R2QPYD7u68zHYAV2t0+R9+sqFlxeNlUJKIIJOZCbzfUqS1 Uao6y0bjdBAJyQ17u19nr2Q/ZQUh6yGMYCFkZiE4l1PyrOHNOHPRNSxnjK7ikv1ocsoV jTjHfcpf1JBJbYeJFtQxH1ezS37Xz8XvfsRww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fLDUaTCh3VK5lI9Kvmqz2LtxGRfdlTFuw6ZvgFybPpU=; b=P2OWYDMSeh4704HhA7pQHU/gbwZSwWDBPJXEOv1tvgloB7DYLdNNMzU9ZkNszEKIHa Y1wRYpcoJt3izpoTX4QwB2vGPO9fWusqhSYIZOZ82S5p52JXZV/o7PabPC6f0jaXFkaN bF0FE7fpEkGkyPqHGXLnaotkyA/HHV9j89eHgvP7NeS9YvtUeNPU4YyExhNheeFwXrtN DcZxJUfaNqZhwG4bbbLVYvp10GZcEVkmHKgyOMzIBc6d7uX1H7n1jIx1z0ONSWplDkx2 swmik3ZghRiEgw1KW8KiJ64d5Nrl1oREX+moKrg5x5hR6Ql+/8HPQ4iqQz7dWC4p4Wwy 51Gw== X-Gm-Message-State: AOAM531OpRfc9u/94qCXj++QRtRi9sSnwGLzccbRyjIk+lzk4nf8T0Qw rvSMgFgn6M9zLb6RUseZPr7xig== X-Google-Smtp-Source: ABdhPJxKYUOqP3DW/70zYd5fRMGwvv2i7eB31THLOGZFrdnFDAouv5BkHoNr7Q58CcKQKpTRtkZ0Pw== X-Received: by 2002:a17:90b:2382:: with SMTP id mr2mr18779595pjb.169.1626497809011; Fri, 16 Jul 2021 21:56:49 -0700 (PDT) Received: from shiro.work (p866038-ipngn200510sizuokaden.shizuoka.ocn.ne.jp. [180.9.60.38]) by smtp.googlemail.com with ESMTPSA id w2sm12522885pjf.2.2021.07.16.21.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 21:56:48 -0700 (PDT) From: Daniel Palmer To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, robh@kernel.org, romain.perier@gmail.com, Daniel Palmer Subject: [PATCH 03/10] gpio: msc313: Code clean ups Date: Sat, 17 Jul 2021 13:56:20 +0900 Message-Id: <20210717045627.1739959-4-daniel@0x0f.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210717045627.1739959-1-daniel@0x0f.com> References: <20210717045627.1739959-1-daniel@0x0f.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_215649_777787_ADCE50BF X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org - Remove the unneeded assignment of ret before returning it. - Remove an unneeded blank line Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij --- drivers/gpio/gpio-msc313.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index da31a5ff7a2b..a894bafbd4c3 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev) struct irq_domain *parent_domain; struct device_node *parent_node; struct device *dev = &pdev->dev; - int ret; match_data = of_device_get_match_data(dev); if (!match_data) @@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpioirqchip->handler = handle_bad_irq; gpioirqchip->default_type = IRQ_TYPE_NONE; - ret = devm_gpiochip_add_data(dev, gpiochip, gpio); - return ret; + return devm_gpiochip_add_data(dev, gpiochip, gpio); } static int msc313_gpio_remove(struct platform_device *pdev) @@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = { .probe = msc313_gpio_probe, .remove = msc313_gpio_remove, }; - builtin_platform_driver(msc313_gpio_driver);