From patchwork Thu Jul 22 17:08:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salah Triki X-Patchwork-Id: 12394401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C987C63793 for ; Thu, 22 Jul 2021 17:10:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 634F3610CC for ; Thu, 22 Jul 2021 17:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 634F3610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VdA5ptA41pIvo5lU/t64I1LtrBgER8DnUERGNmZ5Pio=; b=OSHBNzVwSsFsiU cWhytR3pCSwHJB4jm7wrrVrx3GoFhHA8ljlp8RXRLqp+TsT4JlgwrIG0gWaAIa0DAwrcpRNBUzDXa vRyxM6mUMqij2IQiSohVv5dlXwcY9Wgr5Tofe7ySYiEBxNPeVPphcYVbiJm9BsfAHjoEPjhbgPUKy T75iw8bYmuDkRVJEj8NZXx44XXn3OSAAltSQWQIpR23QyQhIOhAeJaRZ/8LStg6INzywGGPjObzVC uYnGN6KM68veLVorKz3FRNZDu9zq1NGGjGTfr/t6eFpA07iOmKUCdiQV//nT+rFBL8xAqdJ2S0HA9 bJlbNuNqM/z/39ZhZ2Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6cBX-002H6w-Vz; Thu, 22 Jul 2021 17:08:36 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6cBU-002H58-3Y for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 17:08:33 +0000 Received: by mail-wm1-x329.google.com with SMTP id 9-20020a05600c26c9b02901e44e9caa2aso23771wmv.4 for ; Thu, 22 Jul 2021 10:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=BM24k6H9LcY/dUUeA4LE+RhfS6GQmXK+4XERxfAvlv0=; b=EGJzKVW/kRPjNGPb3PpWvJp0lL9sDmOkyFaIWjQOFlnDL3jl44Mx6wQfAyNRu1guxz wV1u73JJHMVl7EYbQOUcVLRVUPztU9PnIN3GXofRe7W6hfiBQMxPlW6d16YH80OBJ3rg pmmt5MsFbbbujjtLZPN6UDNOfOnWbg8+gttPgueZw7XILapxG4uCF/EV71qBnLXvQZBO Yqd1XHBsi1IjWqQbrGSDFuWtunt6ZUfRafXcAd55XGVZZcxId9f/bSjwwBd54cTec8rf cj0wCX2BjGPE6t26cKZmHhsg/ZQhY1CAEgd2h7J+/p2NTOO+YBzt9Ng68SwsfrwaqvcT gN2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=BM24k6H9LcY/dUUeA4LE+RhfS6GQmXK+4XERxfAvlv0=; b=VGjITsoFHTPuQSAwSlf1dqypFVDW39rUcEAvDYKpQ2ZoeGSED0zm9yOGvjrjEqZZQz dZl/L1kkSxqO6v9mVJsX5xZ0oe1EoNCQB8oV6rlcRvX4RXUcPVmNv8mAW60VSzr/9Y55 aTL5iWtG5a5By0owbm/uQPjqUecV5dVe/Jn7MiG81pPAM7h5eiSnCw2iDjx2p9TexB81 wpaYsJeLoIsviXZKR+LfYcd8V2o/6gC9VmrR35rNTVBm8nFtmHpzkPKZmePU2wqNqidG dtuLRSulyW1F6MU240kmeRFt0YKutPxQ4yyj9sztr9fTUCv7tnDzPlhLS6e6WsmOxCZT yg8w== X-Gm-Message-State: AOAM5317irYSZOriXM9I3lK6TpGtAVtFsbALiMknDNZL2WitRFi566Fe ++Gnc7lzbVoM2Sb9NI1NSSU= X-Google-Smtp-Source: ABdhPJzDPSdBP2ulFJJaYkQ7EQ6LuTTGOgv1xIdTUYvQSiWPfuJf+HKhIuywvRz36Xfjg8BIhdAn7g== X-Received: by 2002:a7b:cd15:: with SMTP id f21mr601085wmj.148.1626973710339; Thu, 22 Jul 2021 10:08:30 -0700 (PDT) Received: from pc ([196.235.233.206]) by smtp.gmail.com with ESMTPSA id w18sm8513884wrs.44.2021.07.22.10.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 10:08:29 -0700 (PDT) Date: Thu, 22 Jul 2021 18:08:27 +0100 From: Salah Triki To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , gregkh@linuxfoundation.org Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND] crypto: atmel-aes: use swap() Message-ID: <20210722170827.GA4362@pc> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_100832_177606_38EF7148 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use swap() instead of implementing it in order to make code more clean. Signed-off-by: Salah Triki Reviewed-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index b1d286004295..60041022c4f5 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) * the order of the ciphered tweak bytes need to be reversed before * writing them into the ODATARx registers. */ - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; - - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; - tweak_bytes[i] = tmp; - } + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); /* Process the data. */ atmel_aes_write_ctrl(dd, use_dma, NULL);