From patchwork Mon Jul 26 11:19:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 12399273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15E2C4338F for ; Mon, 26 Jul 2021 11:21:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90AB860C41 for ; Mon, 26 Jul 2021 11:21:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90AB860C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mewWpvRcaZHEuuz3z6vbGG95L1u2hwlAb8F/Md+HoJM=; b=WYDNYDTscnFFw9 0b0HzqmgUG2pC0axno8redOS5X0Pfw7LW1n6b4qG318eEppGwqEKJVUBzpbuAl5REA7tGJMUUJSww LAg20LuqypvV2GFLl6tPpu6tPM0bZWCBaj148nyEP8u/+rLxrRR9jvdCnsrocn3z/5Nvr0J/+iuNG sK4eOhcqzxqYBgy8xRPKsD5JceK48iFlPG8DRIb/2fIssazyf8igd2MJKmXJJpkIov+gB2f6N7lXf od2uTagO6MwdVbTttgWyXOF5OaGV5MAVs7tWwyf9aGnMT3Eg5o3+Yjt6lidFYHxvWNYn6Lgo2G83E SS6HVUPczuuTNRF5ekRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7yeF-00Aydh-Ve; Mon, 26 Jul 2021 11:19:52 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7yeB-00AycD-Pw for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 11:19:49 +0000 Received: by mail-pj1-x1030.google.com with SMTP id pf12-20020a17090b1d8cb0290175c085e7a5so19258391pjb.0 for ; Mon, 26 Jul 2021 04:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vcy/qtkkiK7UjSfWP1fK7FSTP1jeUYmZqbE4rjgeDZo=; b=nxXu/cb7lqQ0xcne5Q9FiIRI/FlMMkHZgMvc7pXPxsxGrUsf4h387Mip2jlFjfFIvW xNZn9vlDYcjAPdyAXdftKFBKzCrc6PZl8Bomt9x6uCBFDCKDKxwk3TzYsX3cvh/qtXNk IZ5HOy3NAbaGyGLoCs8C4IvMc3N0o//ne6k9s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vcy/qtkkiK7UjSfWP1fK7FSTP1jeUYmZqbE4rjgeDZo=; b=jX3RpjONIqv6hsZopjsQp8mwaI4rUGoMcyNMUHPmyybSuYRNkbhIleV0YtWvFPUcYF pBCSysm+tRU5T8/KdTKudjaNXrpvuRaGpe4qTZb6f6PvV97fMUDwmo/w808WE+hTmKt1 TH/vkR2ZwHrnFQaw6xzB8kvO39L8FQmB3KAE0yBKANjmNLcmO0Rjn6Ur5H3zQ1G/m8eb qAHR2dKWQ3gWZ7Qi9Fv+QgrGgMW/puLZ27A8oKjVSe9NAoFgdZxwUj9u1OYjPCQKIJta ebv4eIZVkmzYWIcmiQeyMLJdZLxkD/d0FesUUzkE/bjB+ZWCy5wYigA6duJwYNZGVms9 g53Q== X-Gm-Message-State: AOAM531rjxuF9WPemjCOcrnsiZy038GScblC9v4YkRMjC0+VP1Du7Dpx TS2PMJ46BPlvoOd2LSSkxkfoag== X-Google-Smtp-Source: ABdhPJx8aNBhyrJBVcN6CEdp0jeeHRROLel4R3XbbG0babm5xfUipZKyTH6KacoIEaVqh5+UOe67ug== X-Received: by 2002:a63:e841:: with SMTP id a1mr17876872pgk.197.1627298386871; Mon, 26 Jul 2021 04:19:46 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:1b02:54ad:f521:5496]) by smtp.gmail.com with ESMTPSA id b10sm42070578pfi.122.2021.07.26.04.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 04:19:46 -0700 (PDT) From: Chen-Yu Tsai To: Linus Walleij , Rob Herring , Matthias Brugger , Sean Wang , Zhiyong Tao Cc: Chen-Yu Tsai , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: pinctrl: mt8195: Use real world values for drive-strength arguments Date: Mon, 26 Jul 2021 19:19:41 +0800 Message-Id: <20210726111941.1447057-1-wenst@chromium.org> X-Mailer: git-send-email 2.32.0.432.gabb21c7263-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_041947_922198_5F986B05 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The original binding submission for MT8195 pinctrl described the possible drive strength values in micro-amps in its description, but then proceeded to list register values in its device tree binding constraints. However, the macros used with the Mediatek pinctrl bindings directly specify the drive strength in micro-amps, instead of hardware register values. The current driver implementation in Linux does convert the value from micro-amps to hardware register values. This implementation is also used with MT7622 and MT8183, which use real world values in their device trees. Given the above, it was likely an oversight to use the raw register values in the binding. Correct the values in the binding. Also drop the description since the binding combined with its parent, pinctrl/pincfg.yaml, the binding is now self-describing. Fixes: 7f7663899d94 ("dt-bindings: pinctrl: mt8195: add pinctrl file and binding document") Signed-off-by: Chen-Yu Tsai Acked-by: Rob Herring --- .../devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml index 2f12ec59eee5..e17a399e0904 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml @@ -80,10 +80,7 @@ patternProperties: as macros in dt-bindings/pinctrl/-pinfunc.h directly. drive-strength: - description: | - It can support some arguments which is from 0 to 7. It can only support - 2/4/6/8/10/12/14/16mA in mt8195. - enum: [0, 1, 2, 3, 4, 5, 6, 7] + enum: [2, 4, 6, 8, 10, 12, 14, 16] bias-pull-down: true