Message ID | 20210805075535.116097-1-islituo@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=zXmn=M4=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2498DC4338F for <linux-arm-kernel@archiver.kernel.org>; Thu, 5 Aug 2021 07:58:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2A4F6044F for <linux-arm-kernel@archiver.kernel.org>; Thu, 5 Aug 2021 07:58:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2A4F6044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Zi+OLSZVE1Jt/LmWjAKNrefJkoDW/hWQdU/WxjB2lVs=; b=mC2WKtmRTnoRhz cO1+Mn6/OySQuLxa9COwTaeMCX9qBylqNzU8wqlSXQE8CXF3lyzwKKcj7WjWJnIpVTPxR1uaUo7Tn iFxUq1UWbbQSCjJzPZkK01+wBPFAFGctZ/YuQAD4QRU61CDtGQGlJ6/6zcS1GO0wiIpxTgUH53BH7 We4XpOt5qVtIWmTM96aBeNZuw/UhMmYyIjjgQ+ijs7ZNC6BPjLmPOoLmIzI4xouHS3JLK6P+Qlur5 arGAEuu1rpJxPC6o6K6JveYtQPcKbD9C9DOSBEjy3TebcdB1qoota7GwANEFdcw+njAhNnHphWxmN vuCtFVfSkiNKCo3LRZ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBYF9-008VpT-Aa; Thu, 05 Aug 2021 07:56:43 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBYF3-008VmI-Vs for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 07:56:39 +0000 Received: by mail-pj1-x1031.google.com with SMTP id pj14-20020a17090b4f4eb029017786cf98f9so7431223pjb.2 for <linux-arm-kernel@lists.infradead.org>; Thu, 05 Aug 2021 00:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KzRsy5xjBsFP1lotVUKgcaA0YPpQUsU83EGq9W53Tvk=; b=UMgOnE/1pl9TWQilf0ZfyeW3FaKKTp9Japy2/9SQAATB6IS1y8pRZ92oUAXcvL/Hjd 2pfy3tDPrOR4Schcd5JSU9q7nIRMZuRoDad5IFBRCUnirEMVxf9XkHxQxDH6tTWRio3M fNwnMTZplpaqfPKVIk9wQGcB7RCMn9ZVSncr/EHX6GFuidcnqPeu5OP5ZU/IbGLFeAtd 4yJkcDURsTT1LVqyhH3+mq3NKt09HRrEBXbsqbmcIZ4Xa62mAAE+4o/QgoKywHp7RBCn mvVRZZwl+zVBMOAS36kwFLtp21kG38YnUBXtRwbijyp8XKwm5JPZhFMT0pRnrE7zfsWU qvnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KzRsy5xjBsFP1lotVUKgcaA0YPpQUsU83EGq9W53Tvk=; b=fTjERxfvyGSXNVdbTLFd3SzDaYpy8l42pV6zQNiLhbtIGMqQAbb8thF+xkjn0LWyjn bzWQDcLrp6FjjvLJgYrc0uMbf4q+BvDtpRcV83nF8VUwoG5oHW1Iv+rfhSkxd2PlsxHm GfMdDJx+YpabLclrD07Rp40wYkObxhNQwyKYGuNga4kCKIL5aGTbX8AvxnV2Gq09ozyI B/HZuET8OXpHUDFNXtTDr60rfMeYIs5Th70m9Q2JFAXnBNisncmnziq9pv+1TJH5iOtk l08BWuyfxTv3cmwRhvrqwxQ8wOG4iom/+UXYQka1SVwMRHENKZDOwUrbBXsm9X0dwR/d pDMQ== X-Gm-Message-State: AOAM531jusI0v4pyrqOJwu6LxPDkwZx6NA/+nwsed1LFaYMrNMkBYwzo 02Q6hSCSTnAHcV4CCuaHNDY= X-Google-Smtp-Source: ABdhPJwdyARdZoc6Y55KTanj8seRN95/jamf11lnAx/tR+rFkqJTVyGuEMC3CBmQso+NPARXZbvYDQ== X-Received: by 2002:a63:e547:: with SMTP id z7mr495600pgj.65.1628150196358; Thu, 05 Aug 2021 00:56:36 -0700 (PDT) Received: from localhost.localdomain ([45.135.186.81]) by smtp.gmail.com with ESMTPSA id 136sm6775573pge.77.2021.08.05.00.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 00:56:35 -0700 (PDT) From: Tuo Li <islituo@gmail.com> To: a.hajda@samsung.com, mchehab@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Tuo Li <islituo@gmail.com>, TOTE Robot <oslab@tsinghua.edu.cn> Subject: [PATCH] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Thu, 5 Aug 2021 00:55:35 -0700 Message-Id: <20210805075535.116097-1-islituo@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_005638_064993_B7510808 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe()
|
expand
|
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index eba2b9f040df..c763c0a03140 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1283,7 +1283,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; }
The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error infomation. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Tuo Li <islituo@gmail.com> --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)