diff mbox series

[1/2] arm64: dts: mediatek: align operating-points table name with dtschema

Message ID 20210820081616.83674-1-krzysztof.kozlowski@canonical.com (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: mediatek: align operating-points table name with dtschema | expand

Commit Message

Krzysztof Kozlowski Aug. 20, 2021, 8:16 a.m. UTC
Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
    opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski April 19, 2022, 10:12 a.m. UTC | #1
On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
> Align the name of operating-points node to dtschema to fix warnings like:
> 
>   arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
>     opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
> 
> 

Applied, thanks!

[1/2] arm64: dts: mediatek: align operating-points table name with dtschema
      commit: c743bb394d35b782ae9d9ab815d6053500914533
[2/2] arm64: dts: mediatek: align thermal zone node names with dtschema
      commit: 54ff423f837db59db0626a00d091e45dcc46787e

Best regards,
Matthias Brugger April 19, 2022, 2:31 p.m. UTC | #2
On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
> On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
>> Align the name of operating-points node to dtschema to fix warnings like:
>>
>>    arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
>>      opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
>>
>>
> 
> Applied, thanks!

Could you please provide a stable branch for this patches? So that I can pull 
that into my branch. This will help to reduce merge conflicts later on.

Thanks,
Matthias

> 
> [1/2] arm64: dts: mediatek: align operating-points table name with dtschema
>        commit: c743bb394d35b782ae9d9ab815d6053500914533
> [2/2] arm64: dts: mediatek: align thermal zone node names with dtschema
>        commit: 54ff423f837db59db0626a00d091e45dcc46787e
> 
> Best regards,
Krzysztof Kozlowski April 19, 2022, 2:34 p.m. UTC | #3
On 19/04/2022 16:31, Matthias Brugger wrote:
> On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
>> On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
>>> Align the name of operating-points node to dtschema to fix warnings like:
>>>
>>>    arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
>>>      opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
>>>
>>>
>>
>> Applied, thanks!
> 
> Could you please provide a stable branch for this patches? So that I can pull 
> that into my branch. This will help to reduce merge conflicts later on.

Then maybe better take them directly? These patches were waiting on
lists for long time, I resent them and pinged. I took them only because
there seems to be little interest but we want to fix all dtbs_check
warnings.

There are three for Mediatek:

https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups

Best regards,
Krzysztof
Matthias Brugger April 19, 2022, 2:50 p.m. UTC | #4
On 19/04/2022 16:34, Krzysztof Kozlowski wrote:
> On 19/04/2022 16:31, Matthias Brugger wrote:
>> On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
>>> On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
>>>> Align the name of operating-points node to dtschema to fix warnings like:
>>>>
>>>>     arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
>>>>       opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
>>>>
>>>>
>>>
>>> Applied, thanks!
>>
>> Could you please provide a stable branch for this patches? So that I can pull
>> that into my branch. This will help to reduce merge conflicts later on.
> 
> Then maybe better take them directly? These patches were waiting on
> lists for long time, I resent them and pinged. I took them only because
> there seems to be little interest but we want to fix all dtbs_check
> warnings.
> 

Yes definitely. I'm just overloaded and forgot about them. Although at least on 
that thread I don't see any ping. Anway thanks for the tag, I merged it into my 
branch now, so we are good.

Regards,
Matthias

> There are three for Mediatek:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index d9e005ae5bb0..49c6b6a5b489 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -57,7 +57,7 @@  aliases {
 		serial3 = &uart3;
 	};
 
-	cluster0_opp: opp_table0 {
+	cluster0_opp: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp-507000000 {
@@ -94,7 +94,7 @@  opp-1703000000 {
 		};
 	};
 
-	cluster1_opp: opp_table1 {
+	cluster1_opp: opp-table-1 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp-507000000 {
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 409cf827970c..caab109add28 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -197,7 +197,7 @@  CLUSTER_SLEEP1: cluster-sleep-1 {
 		};
 	};
 
-	gpu_opp_table: opp_table0 {
+	gpu_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;