diff mbox series

[2/2] arm64: dts: exynos: add proper comaptible FSYS syscon in Exynos5433

Message ID 20210820082149.84613-1-krzysztof.kozlowski@canonical.com (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: exynos: align operating-points table name with dtschema in Exynos5433 | expand

Commit Message

Krzysztof Kozlowski Aug. 20, 2021, 8:21 a.m. UTC
The syscon nodes should come with specific compatible.  Correct theh
FSYS syscon to fix dtbs_check warnings:

  syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
  ['syscon'] is too short

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alim Akhtar Aug. 20, 2021, 2:47 p.m. UTC | #1
On Fri, Aug 20, 2021 at 1:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The syscon nodes should come with specific compatible.  Correct theh
s/theh/the?

> FSYS syscon to fix dtbs_check warnings:
>
>   syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
>   ['syscon'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
With typo fixed above,
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index ebd5091d68b4..4422021cf4b2 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1132,7 +1132,7 @@ syscon_cam1: syscon@145f0000 {
>                 };
>
>                 syscon_fsys: syscon@156f0000 {
> -                       compatible = "syscon";
> +                       compatible = "samsung,exynos5433-sysreg", "syscon";
>                         reg = <0x156f0000 0x1044>;
>                 };
>
> --
> 2.30.2
>
Krzysztof Kozlowski Aug. 20, 2021, 3:05 p.m. UTC | #2
On 20/08/2021 16:47, Alim Akhtar wrote:
> On Fri, Aug 20, 2021 at 1:52 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The syscon nodes should come with specific compatible.  Correct theh
> s/theh/the?

Indeed, thanks!

> 
>> FSYS syscon to fix dtbs_check warnings:
>>
>>   syscon@156f0000: compatible: 'anyOf' conditional failed, one must be fixed:
>>   ['syscon'] is too short
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
> With typo fixed above,
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index ebd5091d68b4..4422021cf4b2 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1132,7 +1132,7 @@  syscon_cam1: syscon@145f0000 {
 		};
 
 		syscon_fsys: syscon@156f0000 {
-			compatible = "syscon";
+			compatible = "samsung,exynos5433-sysreg", "syscon";
 			reg = <0x156f0000 0x1044>;
 		};