| Message ID | 20210824105512.19242-1-rogerq@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay" | expand |
On 13:55-20210824, Roger Quadros wrote: > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. ^^ the above comment might be fine to indicate the side effect of non-compliance > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > Signed-off-by: Roger Quadros <rogerq@kernel.org> Reviewed-by: Nishanth Menon <nm@ti.com> > --- > Changelog: > v2 > -refer to DT spec instead of schema in commit log. > > arch/arm/boot/dts/da850-evm.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts > index 87c517d65f62..9dc79b5977bf 100644 > --- a/arch/arm/boot/dts/da850-evm.dts > +++ b/arch/arm/boot/dts/da850-evm.dts > @@ -415,7 +415,7 @@ > &aemif { > pinctrl-names = "default"; > pinctrl-0 = <&nand_pins>; > - status = "ok"; > + status = "okay"; > cs3 { > #address-cells = <2>; > #size-cells = <1>; > -- > 2.17.1 >
Hi Sekhar, On 25/08/2021 19:15, Nishanth Menon wrote: > On 13:55-20210824, Roger Quadros wrote: >> As per Device Tree Specification [1], the status parameter of nodes can >> be "okay", "disabled", etc. "ok" is not a valid parameter. >> >> U-boot Driver Model does not recognize status="ok" either and treats >> the node as disabled. > > ^^ the above comment might be fine to indicate the side effect of > non-compliance > >> >> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > Reviewed-by: Nishanth Menon <nm@ti.com> Could you please pick this one if not too late for -next. Thanks. > >> --- >> Changelog: >> v2 >> -refer to DT spec instead of schema in commit log. >> >> arch/arm/boot/dts/da850-evm.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts >> index 87c517d65f62..9dc79b5977bf 100644 >> --- a/arch/arm/boot/dts/da850-evm.dts >> +++ b/arch/arm/boot/dts/da850-evm.dts >> @@ -415,7 +415,7 @@ >> &aemif { >> pinctrl-names = "default"; >> pinctrl-0 = <&nand_pins>; >> - status = "ok"; >> + status = "okay"; >> cs3 { >> #address-cells = <2>; >> #size-cells = <1>; >> -- >> 2.17.1 >> > -- cheers, -roger
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts index 87c517d65f62..9dc79b5977bf 100644 --- a/arch/arm/boot/dts/da850-evm.dts +++ b/arch/arm/boot/dts/da850-evm.dts @@ -415,7 +415,7 @@ &aemif { pinctrl-names = "default"; pinctrl-0 = <&nand_pins>; - status = "ok"; + status = "okay"; cs3 { #address-cells = <2>; #size-cells = <1>;
As per Device Tree Specification [1], the status parameter of nodes can be "okay", "disabled", etc. "ok" is not a valid parameter. U-boot Driver Model does not recognize status="ok" either and treats the node as disabled. [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 Signed-off-by: Roger Quadros <rogerq@kernel.org> --- Changelog: v2 -refer to DT spec instead of schema in commit log. arch/arm/boot/dts/da850-evm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)