From patchwork Wed Aug 25 07:24:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12456651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74EFC4338F for ; Wed, 25 Aug 2021 07:27:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86CA26127B for ; Wed, 25 Aug 2021 07:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 86CA26127B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=K6ZWTgGwRM+XatbLj54qCaCTfH1Vl6DEc7+TZqeuCFg=; b=eygtYqHnaJaKF2 UKPkECOKOB4DgMg381/pRU+TnKLyX8auh1P6q99M7iR2pBhQW+8YXL+zPe4yzOrSV3liXyrnTqLMC iADyOmBMlYEzdc90dzJkMHu/v4bbkN0kO9cS6Vg/pFfIcQoQox169X3VWSt6r22FE7/mhBSuvRe/K CJYBopODm8DR2Og8tneD9O7/EUIWUP4aC1Y6a3937sRuJAQWMi+lGRQdqJu3UkAy2g04hcq/rUgJr TguyZfMzYpxHU5sAS/pl9sNxwfBVLE4YDN4B2C+mLKZTdqGPZHQXxwUkblyjUlv2ee4HwB++1kMJ4 IU5SBrPCmWLkVrIgtsaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mInHR-005npn-1A; Wed, 25 Aug 2021 07:25:01 +0000 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mInHN-005npA-Ij for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 07:24:58 +0000 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17P4JUf2015024; Wed, 25 Aug 2021 07:24:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=7y6HS730loG1mEgNVjdx+a8DCIlkpiq6aAoKhves8LI=; b=ahDN9w8yGo4OCXfBf+frrlB2+FH3Hh1WOOUnyLRsLGNcAty12QZ/PSkxFcmmVzB6DohS I2HSbJjDoC/S8xiOBmxVWMToEBMCm7wkso9nxqGSo8iUmcKXBskEXwI5yFEgLQOlW+kM mPNNtIS9q23kLCQNzD62uW7n9ZcFAbttywVET8GVajs4mZgLQ8bCm3bMTlDPleY3cljm uYPpTbFAFsRkL05IHDgg1TKzHe/NpYkvpa0E9QB/nG7zmNSumvQ0476QCQ3x+Wmhb83L 2/xCkem9dT0js2RNzDVp0lJyoZOz3JjxQB3ubiwWaJ/KkDDti+jMF5fsNRXncfJLCVku DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2020-01-29; bh=7y6HS730loG1mEgNVjdx+a8DCIlkpiq6aAoKhves8LI=; b=jsGD32lRbqp/kuGnj/VZQ4VM8ZaNWc0Joh6XRivOIAPbRB+oUQwiaf9IhKUKpjFWii74 G1JiupcwjSitFy2T+uD8oUknyxQgNSYHlkI/lL8iavdcBPIXrO24jwJsQoAkvrjxumtS h1HYJ/dzlmEJjC555q0Y2prR3bt9zVNTwZACMWd4tiNMblmdibxknpRUPtbiu+VSCvJ7 FD0sls0uIbm+NLyeBL+7hVS9lAV2aKaLg6skYXQnv8xr339PCNCt99gornZg7DQbQMj3 REFuoC/0xqi+EkwQCouwC18LWFKlXIZqcODAV4fv1q/pwYTwJtteTmbNgVGDfW2MVb9a mQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3amwh6jmtf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Aug 2021 07:24:53 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 17P7FHZ1020004; Wed, 25 Aug 2021 07:24:52 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by aserp3020.oracle.com with ESMTP id 3ajsa6rngb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Aug 2021 07:24:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c8L14y8VaJDbrUasng82Rs8PAPP29iECrFo8DRbpV/2Y7RJ/ZWWT2qoHHhuLiS9i0QMF6gWiOqdHNF0u99+D75M9mpv27I+V5dSGlXZmR47Hc1wIFeYT7j4yhHLeDPX+qSAN/FFBJsO7OThdqVET5GfASVWQvVhV8Hz4rA5LO1lzKNau3hb92YUnUvYcrDvxsNwSJxDETlVpOqjv3xt6fRP5VDZFpMccCT53SzsawpTxGlPPowSBURV1fs2t5gZJwoAJTKC35SAHMgVRSmCEQT8+9mDDBNKIPw8QnMaKExMcpd3J2/YKB8ZW8JDA2MSkhk6VC4zfcX0bYHqiw8t4ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7y6HS730loG1mEgNVjdx+a8DCIlkpiq6aAoKhves8LI=; b=DFD5e9W2pP0vSTorosIi3X/T0OZAUNR4laI4relkPR/W7XeRyqU6552gIciwE3IQmDlUzlun9arcvQ/7ZiK9OtLtB5fNrYuyhR4ezVt1L0V50byjWZ+PRrkPshrCIIizn7bFGSyyO7gqocDIpQXXjjq5DpoirlB5vo8cmwue44D9M+dlzKoYMhQKVNNAM1n3lks7pHbT1i5d2o3g4MCjMWcKq/h/PNE9UloMmZPQNCDmvcrvTllPc4w49WFP8xJWZVxHZOyvuHcq3YGbhhMn9T6zoDnm4Zb4mjSDYvmEBUF7XNhKrsX+Dvu0Mz2uCDzx/jKQ0jZSvwM0HLiZqYLL2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7y6HS730loG1mEgNVjdx+a8DCIlkpiq6aAoKhves8LI=; b=uIu8VpORVA1dOrLN5eOnyRSthayU1gdg2MXpYcTncJyU/b2XEq984hr/s7ErCNJ10OKdFX31zrCaNAsLBQDHFDnj7D1AttmGCkMZRinwDs3uR3cYIfLecBqR08FxFK8Ia9oxc6j9yQYEpJ4S3NBeCpJY2qRnD2aNW/Kg6wkx4zM= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com; Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR1001MB2096.namprd10.prod.outlook.com (2603:10b6:301:2c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Wed, 25 Aug 2021 07:24:50 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268%7]) with mapi id 15.20.4457.018; Wed, 25 Aug 2021 07:24:50 +0000 Date: Wed, 25 Aug 2021 10:24:35 +0300 From: Dan Carpenter To: Jiri Slaby Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mxser: use semi-colons instead of commas Message-ID: <20210825072435.GB13013@kili> Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: LO2P265CA0375.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::27) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from kili (2a02:6900:8208:1848::11d1) by LO2P265CA0375.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 25 Aug 2021 07:24:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1d2bc46-1084-47e1-f76a-08d967996d06 X-MS-TrafficTypeDiagnostic: MWHPR1001MB2096: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oups4NC2e1tebJQFqyT2eOAp1fhQ1Vl4FJJXl1q3PdFvQ+zQGNta0EPYg7ebkjRwwF1vW/aBbCGeXLxCq8JiNuO9iep1/LRHc0I+m+ITLfFkfr+Zdf/pVBC71w9FQmbx0UNl8LkR9JbT/ogEyWaHb3WN+//EUyQWjMO7hthyoeq14UTPKcZWTTWzMt6lKN842IGNUata1LQWhF7cme7NZuUXtPzvW1GNaGnsYT8OWMBltQfoaWuol48X11ldOan4XEb2el6K3nzocG3YLSdgs9MkjyDUvsHtjME/TM7eBjhUz6tvQ0+O4u8m7ZlP/MJxth+bIabPWVXILqbXpvO5DnicyAigv0YiRVB3pw8NPjuMhFnoTfiaP3h3VLVEX1O/a4cReIMWJe1DqN+Ilt2Zq6Hd2dQ+ZwlUkvOD21x936Cq74uy6ssvy18Wh2B02fi2BFqq0gKElgZ5Vfj33EeSA75zrd3LhuGcGnlp/WbXSNhDm7Ts+II55m9CZBpL6esgzPtgqQTQle1K3a3c4wm6hJMggWTQ43SYXMeVezYxqTDcEB8EhqaQBzxZLw0Iqr0PY2KZGSckhRis7UWETNy3p00cExIjZDUMMDhh4/2piOvYSfjkrMS5G7+0l8rVlBELE+LOpKrGN+gYjBHGyuZ5VQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(396003)(366004)(346002)(39860400002)(478600001)(66476007)(66556008)(6666004)(186003)(33656002)(54906003)(86362001)(8676002)(38100700002)(9686003)(83380400001)(5660300002)(8936002)(33716001)(66946007)(9576002)(6916009)(55016002)(1076003)(4326008)(6496006)(44832011)(316002)(7416002)(2906002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Iz/wnWN7HT3U/dyR6KjnJY9A+bqq50CHJ3wpch9UtfrgQeaSgXWWo8xCPQhmfMJda+lHT/gAyM+DhbOGK8/oHmxsKrRbh9hJ3bzIDz/+n93xGQ3ycMlnTxKCKM7bCLdRBwvIkkl1Q3Z4UBr6KN3C5adfpa8opBnokhTilY6E4VhvN4aSUx3S+Hm+H/9Cw0Dm2jz2nWF3WlFltYjyl5R35XLkvJzE/eN10hwp6bM2lHxkV51NTqwLGJd8HoSpcfiOKa+utQI8TEFKwWypM+tivN4LVnJbBSlUbxwZp8qoMvkk54u+AMEyQcvhK/XctR33X1dY2eH02MKK1S14hdSCsIk9m0GIF7dEaoQMCjN6uUNzLrG1ktu2iisvCYDN3OBfeDAUeDJuuvZO+n6Ld1zDB2hHnZsg242rJrcrsJD/64C2YDr/ZpjOea03LdMjUQU3fP/HeAwymxRF8pbGpy8qHGGvH29IPczTkg1tWwX7xuhV/gENatWrhWTf2WLk0NWCZ3JTZDK69l1mJx29THekftU66B0PF906MJiIUzTFYEffbyfKyWBSW3f+L34JErAgWA8NpX68NwyQB45wxcDANe77+94+OopuYRMhDGkds9qmQYO5ZW158/tCY7lB9Js0ndgsFxBS/3uo8z0qbaaplO7monfPuGvQwyXLMk4j34Y4TkdV7Ur7WoYEsSQcdnuD/2eqIYsiHWABGVPztVjP8/g7//chMjMkGrzhv8vN2xjcZVs5m7sx8JafRJElFzKVGIxwDpgSJxJoTwTT63NG74l+Te+NKTubKJp2KTDfCNlkCTGKj/2t+8yRKSI9btIUWDQPevn2X9b5t52wgJ94kvdve2Ko4Ash/0443UiI2t6VbfohxDIbIHarzQ1Y1Tn8YAoGV8D+BUVYEqelSaFgjDzAi+tRLY8BWmtOlLCJphHTEZLMhnP2drsHfCGGc0i0kMBxJD7tDzItiEbaLM9/ra9DnvA7deZrZuH1hb38QTXhkFqlD00isdUtkrd8i4hrv8i2ej+kqbDxc5BfsunRAas3N4hdOGX9t3tTbj9gfjdPO8E962rHAkVru2ZXub+5Oj2UZos8o94UXwaYhSShvEuNpisraaBguS0rwLxOCVzK3NDylGnrP+TAPafGmnKjcHygRPfjr03cYzBNTOgEeC7keUitQw6jl4xoVWVXs+VoQCpRWMj9VKJT7vkNDAeKO7gIueEExL3qNimVAme1V2eL1liFh2t9Ul0SteWZsf2L02q6eFk+7C3wQyAPNLAQA7GfOAVUQeGPKyYiT4P/Iwk50/WAMJ43o0Fxks+8j87rdL39Yg0bRNgzdxd3Zecbnugo9U+Lk4kf1xIfw3sVYt2nUecHjuD6RUxfkutVK1M= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1d2bc46-1084-47e1-f76a-08d967996d06 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2021 07:24:50.7619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UDvKo1Pvrw3Use0NbtEY4zct0tyU7eOMHjIoW8EX0dW08dOQ88dAZXKPCYrbSoxq/CYIHhDp/88jrJoY6vN8Q6qzKiCmGtd0sxHuubxrdfQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2096 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10086 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108250043 X-Proofpoint-ORIG-GUID: 71R97Xx3OeRH-BnnRnJsCpa9b6MWYiuF X-Proofpoint-GUID: 71R97Xx3OeRH-BnnRnJsCpa9b6MWYiuF X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_002457_672457_D77C4DF0 X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This code works, but it's cleaner to use semi-colons at the end of a statement instead of a comma. Signed-off-by: Dan Carpenter Acked-by: Jiri Slaby --- drivers/tty/mxser.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 335e4e50d679..1216f3985e18 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty, if (closing_wait != ASYNC_CLOSING_WAIT_NONE) closing_wait = jiffies_to_msecs(closing_wait) / 10; - ss->type = info->type, - ss->line = tty->index, - ss->port = info->ioaddr, - ss->irq = info->board->irq, - ss->flags = info->port.flags, - ss->baud_base = MXSER_BAUD_BASE, + ss->type = info->type; + ss->line = tty->index; + ss->port = info->ioaddr; + ss->irq = info->board->irq; + ss->flags = info->port.flags; + ss->baud_base = MXSER_BAUD_BASE; ss->close_delay = close_delay; ss->closing_wait = closing_wait; ss->custom_divisor = MXSER_CUSTOM_DIVISOR,