| Message ID | 20210907074201.2553-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mailbox: sun6i: Make use of the helper function devm_platform_ioremap_resource() | expand |
On 9/7/21 2:42 AM, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/mailbox/sun6i-msgbox.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) Reviewed-by: Samuel Holland <samuel@sholland.org>
diff --git a/drivers/mailbox/sun6i-msgbox.c b/drivers/mailbox/sun6i-msgbox.c index ccecf2e5941d..7f8d931042d3 100644 --- a/drivers/mailbox/sun6i-msgbox.c +++ b/drivers/mailbox/sun6i-msgbox.c @@ -197,7 +197,6 @@ static int sun6i_msgbox_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct mbox_chan *chans; struct reset_control *reset; - struct resource *res; struct sun6i_msgbox *mbox; int i, ret; @@ -246,13 +245,7 @@ static int sun6i_msgbox_probe(struct platform_device *pdev) goto err_disable_unprepare; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - ret = -ENODEV; - goto err_disable_unprepare; - } - - mbox->regs = devm_ioremap_resource(&pdev->dev, res); + mbox->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mbox->regs)) { ret = PTR_ERR(mbox->regs); dev_err(dev, "Failed to map MMIO resource: %d\n", ret);
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/mailbox/sun6i-msgbox.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)