From patchwork Tue Sep 7 07:42:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cai,Huoqing" X-Patchwork-Id: 12477793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D686FC433F5 for ; Tue, 7 Sep 2021 07:44:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 944DF610CB for ; Tue, 7 Sep 2021 07:44:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 944DF610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baidu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hxMQy7igfcxew2mj3OFzQZvR6rzp+bPNjyYUoospOlM=; b=P45nNpv0j5KrSs eo7prC+pVJ8yWsbLp69NIkes4Srl4ZIOWuvNtQLN9v2iWqVmgQy/c3X0ZtJ4Qx3t0E927jsqUc7ZG rcJorgYvBvjZ0TaRM7A8Ir+Qqqiu7XqWjq3fD/2t+6P25bhhs/tepdSn+YEW1PzCZymJLZLpxe47K FVhsuBLJLibXfOVEayHnZNIpQD8xi9kl2phUZzYdA3a58jLbTdavwHQl03KUGB/bgVWIbjd27Jayf SYAYChFC5t6qc+u4V47/iTckS/H80XFZBTEy1FEVKBpf3ysyzyyEi/uY9GxH0xTkO6G+BwEzGovzC V/8/vhewjgMS1rHXeQQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNVkI-002kw1-HR; Tue, 07 Sep 2021 07:42:18 +0000 Received: from mx20.baidu.com ([111.202.115.85] helo=baidu.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNVk8-002ksj-Gt for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 07:42:09 +0000 Received: from BC-Mail-Ex28.internal.baidu.com (unknown [172.31.51.22]) by Forcepoint Email with ESMTPS id 6BC6E84BD3E1C14A2EE7; Tue, 7 Sep 2021 15:42:07 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BC-Mail-Ex28.internal.baidu.com (172.31.51.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 7 Sep 2021 15:42:07 +0800 Received: from LAPTOP-UKSR4ENP.internal.baidu.com (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 7 Sep 2021 15:42:06 +0800 From: Cai Huoqing To: CC: Jassi Brar , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , , , Subject: [PATCH] mailbox: sun6i: Make use of the helper function devm_platform_ioremap_resource() Date: Tue, 7 Sep 2021 15:42:00 +0800 Message-ID: <20210907074201.2553-1-caihuoqing@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BJHW-Mail-Ex09.internal.baidu.com (10.127.64.32) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_004208_795081_D551A3EF X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing Reviewed-by: Samuel Holland --- drivers/mailbox/sun6i-msgbox.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/mailbox/sun6i-msgbox.c b/drivers/mailbox/sun6i-msgbox.c index ccecf2e5941d..7f8d931042d3 100644 --- a/drivers/mailbox/sun6i-msgbox.c +++ b/drivers/mailbox/sun6i-msgbox.c @@ -197,7 +197,6 @@ static int sun6i_msgbox_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct mbox_chan *chans; struct reset_control *reset; - struct resource *res; struct sun6i_msgbox *mbox; int i, ret; @@ -246,13 +245,7 @@ static int sun6i_msgbox_probe(struct platform_device *pdev) goto err_disable_unprepare; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - ret = -ENODEV; - goto err_disable_unprepare; - } - - mbox->regs = devm_ioremap_resource(&pdev->dev, res); + mbox->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mbox->regs)) { ret = PTR_ERR(mbox->regs); dev_err(dev, "Failed to map MMIO resource: %d\n", ret);